From: Tony Lindgren <tony@atomide.com>
To: Johan Hovold <johan@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Dhruva Gole" <d-gole@ti.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
"Maximilian Luz" <luzmaximilian@gmail.com>
Subject: Re: [RFC PATCH 1/2] serial: core: Move tty and serdev to be children of serial core port device
Date: Wed, 25 Oct 2023 11:24:33 +0300 [thread overview]
Message-ID: <20231025082433.GQ34982@atomide.com> (raw)
In-Reply-To: <ZTjEtWcF4a95BWBK@hovoldconsulting.com>
* Johan Hovold <johan@kernel.org> [231025 07:32]:
> Your diff is missing the actual tty devices. 'tty' is just the class
> directory.
Ah right, that explains :) The find must be for ttyS* in this case,
here's the diff for qemu x86 for command:
# find /sys -name ttyS*
--- /tmp/before 2023-10-25 10:50:29.870083012 +0300
+++ /tmp/after 2023-10-25 10:52:52.770393075 +0300
@@ -3,7 +3,7 @@
/sys/class/tty/ttyS0
/sys/class/tty/ttyS3
/sys/class/tty/ttyS1
-/sys/devices/pnp0/00:04/tty/ttyS0
-/sys/devices/platform/serial8250/tty/ttyS2
-/sys/devices/platform/serial8250/tty/ttyS3
-/sys/devices/platform/serial8250/tty/ttyS1
+/sys/devices/pnp0/00:04/00:04:0/00:04:0.0/tty/ttyS0
+/sys/devices/platform/serial8250/serial8250:0/serial8250:0.3/tty/ttyS3
+/sys/devices/platform/serial8250/serial8250:0/serial8250:0.1/tty/ttyS1
+/sys/devices/platform/serial8250/serial8250:0/serial8250:0.2/tty/ttyS2
> And can you post the equivalent diff for serdev as well for completeness?
I don't have an x86 or arm64 testcase for serdev, but here's a armv7 wlcore
hci-uart serdev diff for command:
# find /sys -name ttyS* -o -name serial0
--- /tmp/before 2023-10-25 08:23:15.468382112 +0000
+++ /tmp/after 2023-10-25 08:23:15.468382112 +0000
@@ -1,10 +1,9 @@
-# find /sys -name ttyS* -o -name serial0
-/sys/devices/platform/ocp/48000000.interconnect/48000000.interconnect:segment@0/4806e050.target-module/4806e000.serial/serial0
-/sys/devices/platform/ocp/48000000.interconnect/48000000.interconnect:segment@0/48020050.target-module/48020000.serial/tty/ttyS2
-/sys/devices/platform/ocp/48000000.interconnect/48000000.interconnect:segment@0/4806a050.target-module/4806a000.serial/tty/ttyS0
-/sys/devices/platform/ocp/48000000.interconnect/48000000.interconnect:segment@0/4806c050.target-module/4806c000.serial/tty/ttyS1
-/sys/devices/platform/serial8250/tty/ttyS4
-/sys/devices/platform/serial8250/tty/ttyS5
+/sys/devices/platform/ocp/48000000.interconnect/48000000.interconnect:segment@0/4806e050.target-module/4806e000.serial/4806e000.serial:0/4806e000.serial:0.0/serial0
+/sys/devices/platform/ocp/48000000.interconnect/48000000.interconnect:segment@0/48020050.target-module/48020000.serial/48020000.serial:0/48020000.serial:0.0/tty/ttyS2
+/sys/devices/platform/ocp/48000000.interconnect/48000000.interconnect:segment@0/4806a050.target-module/4806a000.serial/4806a000.serial:0/4806a000.serial:0.0/tty/ttyS0
+/sys/devices/platform/ocp/48000000.interconnect/48000000.interconnect:segment@0/4806c050.target-module/4806c000.serial/4806c000.serial:0/4806c000.serial:0.0/tty/ttyS1
+/sys/devices/platform/serial8250/serial8250:0/serial8250:0.5/tty/ttyS5
+/sys/devices/platform/serial8250/serial8250:0/serial8250:0.4/tty/ttyS4
/sys/class/tty/ttyS4
/sys/class/tty/ttyS2
/sys/class/tty/ttyS0
> > There are multiple ports claimed by serial8250. So I think the new sysfs
> > output is correct showing more ttys. If there's some reason why serial8250
> > should only have one tty and this output is not correct let me know too..
>
> There should not be more class devices, you've just moved them and thus
> there are more class directories (with one device per directory).
OK makes sense.
Thanks,
Tony
next prev parent reply other threads:[~2023-10-25 8:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 11:36 [RFC PATCH 1/2] serial: core: Move tty and serdev to be children of serial core port device Tony Lindgren
2023-10-24 11:36 ` [RFC PATCH 2/2] serial: core: Revert checks for tx runtime PM state Tony Lindgren
2023-10-24 11:52 ` [RFC PATCH 1/2] serial: core: Move tty and serdev to be children of serial core port device Greg Kroah-Hartman
2023-10-24 12:29 ` Tony Lindgren
2023-10-24 12:42 ` Andy Shevchenko
2023-10-24 12:45 ` Tony Lindgren
2023-10-24 14:01 ` Greg Kroah-Hartman
2023-10-25 6:51 ` Tony Lindgren
2023-10-25 7:33 ` Johan Hovold
2023-10-25 8:24 ` Tony Lindgren [this message]
2023-10-24 12:17 ` Andy Shevchenko
2023-10-24 12:43 ` Andy Shevchenko
2023-10-25 6:53 ` Tony Lindgren
2023-10-24 12:48 ` Johan Hovold
2023-10-24 13:37 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025082433.GQ34982@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@intel.com \
--cc=bigeasy@linutronix.de \
--cc=d-gole@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.