From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, Willem de Bruijn <willemb@google.com>,
syzbot+a8c7be6dee0de1b669cc@syzkaller.appspotmail.com
Subject: Re: [PATCH net] llc: verify mac len before reading mac header
Date: Wed, 25 Oct 2023 16:01:19 -0700 [thread overview]
Message-ID: <20231025160119.13d0a8c2@kernel.org> (raw)
In-Reply-To: <20231024194958.3522281-1-willemdebruijn.kernel@gmail.com>
On Tue, 24 Oct 2023 15:49:36 -0400 Willem de Bruijn wrote:
> @@ -153,6 +153,9 @@ int llc_sap_action_send_test_r(struct llc_sap *sap, struct sk_buff *skb)
> int rc = 1;
> u32 data_size;
>
> + if (skb->mac_len < ETH_HLEN)
> + return 0;
I think this one may want 1 to indicate error, technically. No?
next prev parent reply other threads:[~2023-10-25 23:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 19:49 [PATCH net] llc: verify mac len before reading mac header Willem de Bruijn
2023-10-25 3:12 ` Willem de Bruijn
2023-10-25 23:00 ` Jakub Kicinski
2023-10-25 7:09 ` Eric Dumazet
2023-10-25 23:01 ` Jakub Kicinski [this message]
2023-10-25 23:05 ` Willem de Bruijn
2023-10-25 23:14 ` Jakub Kicinski
2023-10-25 23:18 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025160119.13d0a8c2@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+a8c7be6dee0de1b669cc@syzkaller.appspotmail.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.