From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: "Julien Stephan" <jstephan@baylibre.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [RESEND PATCH 2/2] oeqa/selftest/devtool: remove spaces on empty line
Date: Wed, 25 Oct 2023 17:01:44 +0200 [thread overview]
Message-ID: <20231025170144.70459a2d@booty> (raw)
In-Reply-To: <20231024141754.1528786-2-jstephan@baylibre.com>
Hello Julien,
On Tue, 24 Oct 2023 16:17:54 +0200
"Julien Stephan" <jstephan@baylibre.com> wrote:
> Signed-off-by: Julien Stephan <jstephan@baylibre.com>
> ---
> meta/lib/oeqa/selftest/cases/devtool.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/lib/oeqa/selftest/cases/devtool.py b/meta/lib/oeqa/selftest/cases/devtool.py
> index c36b1efa78b..b5c488be8e8 100644
> --- a/meta/lib/oeqa/selftest/cases/devtool.py
> +++ b/meta/lib/oeqa/selftest/cases/devtool.py
> @@ -575,7 +575,7 @@ class DevtoolAddTests(DevtoolBase):
> checkvars['S'] = '${WORKDIR}/MarkupSafe-%s' % testver
> checkvars['SRC_URI'] = url
> self._test_recipe_contents(recipefile, checkvars, [])
> -
> +
This patch does not apply due to the '-' line above having no spaces
after '-'. Perhaps your mailer mangled the content removing training
whitespace (which, ironically, is what the patch itself aims at doing!).
Using 'git send-email' is usually the best way to send patches without
this sort of issues.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-10-25 15:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 14:17 [RESEND PATCH 1/2] oeqa/selftest/devtool: abort if a local workspace already exist Julien Stephan
2023-10-24 14:17 ` [RESEND PATCH 2/2] oeqa/selftest/devtool: remove spaces on empty line Julien Stephan
2023-10-25 15:01 ` Luca Ceresoli [this message]
2023-10-25 16:04 ` [OE-core] " Julien Stephan
-- strict thread matches above, loose matches on Subject: below --
2023-10-25 16:02 [OE-core][RESEND][PATCH 1/2] oeqa/selftest/devtool: abort if a local workspace already exist Julien Stephan
2023-10-25 16:02 ` [OE-core][RESEND][PATCH 2/2] oeqa/selftest/devtool: remove spaces on empty line Julien Stephan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025170144.70459a2d@booty \
--to=luca.ceresoli@bootlin.com \
--cc=jstephan@baylibre.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.