From: Petr Vorel <pvorel@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/2] Refactor and merge symlink04/05 using new LTP API
Date: Thu, 26 Oct 2023 01:09:14 +0200 [thread overview]
Message-ID: <20231025230914.GB507231@pevik> (raw)
In-Reply-To: <1697794677-14892-2-git-send-email-xuyang2018.jy@fujitsu.com>
Hi Xu,
> symlink04 and symlink05 has been merged together, testing
> the results of symlink(2) for the existence or non-existence
> of a file
> + * Copyright (c) International Business Machines Corp., 2001
> + * Copyright (c) Linux Test Project, 2003-2023
nit: IMHO LTP copyright was from 2001.
> + * Author: 07/2001 John George
> */
...
> + TST_EXP_PASS(symlink(*tc->srcfile, SYMFILE), "symlink(%s, %s)",
> + *tc->srcfile, SYMFILE);
nit: I would use just:
TST_EXP_PASS(symlink(*tc->srcfile, SYMFILE));
this:
symlink04.c:45: TFAIL: symlink(testfile, slink_file) failed: EFAULT (14)
is not much more informative than this:
symlink04.c:47: TFAIL: symlink(*tc->srcfile, SYMFILE) failed: EFAULT (14)
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-10-25 23:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 9:37 [LTP] [PATCH v2 1/2] syscalls/symlink02: Convert to new API Yang Xu
2023-10-20 9:37 ` [LTP] [PATCH v2 2/2] Refactor and merge symlink04/05 using new LTP API Yang Xu
2023-10-25 23:09 ` Petr Vorel [this message]
2023-10-26 6:13 ` [LTP] 回复: " Yang Xu (Fujitsu)
2023-10-25 22:46 ` [LTP] [PATCH v2 1/2] syscalls/symlink02: Convert to new API Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025230914.GB507231@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.