From: Kees Cook <keescook@chromium.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Robert Richter <rric@kernel.org>, Borislav Petkov <bp@alien8.de>,
Tony Luck <tony.luck@intel.com>,
James Morse <james.morse@arm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sergey Temerkhanov <s.temerkhanov@gmail.com>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, Borislav Petkov <bp@suse.de>,
linux-edac@vger.kernel.org
Subject: Re: [PATCH v2] EDAC/thunderx: Fix some potential buffer overflow in thunderx_ocx_com_threaded_isr()
Date: Thu, 26 Oct 2023 10:18:33 -0700 [thread overview]
Message-ID: <202310261016.2D17ACACE@keescook> (raw)
In-Reply-To: <202310241629.0A4206316F@keescook>
On Tue, Oct 24, 2023 at 04:39:36PM -0700, Kees Cook wrote:
> As the replacements get longer, I would encourage you to use seq_buf
> instead -- it does all the length math internally. For example:
There's some ongoing work to make seq_buf easier to use:
https://lore.kernel.org/lkml/20231026170722.work.638-kees@kernel.org/
Perhaps we can add an "alloc" and "free" pair too, to handle this case:
> msg = kmalloc(OCX_MESSAGE_SIZE, GFP_KERNEL);
> seq_buf_init(&s, msg, OCX_MESSAGE_SIZE);
But perhaps it's overkill...
--
Kees Cook
prev parent reply other threads:[~2023-10-26 17:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 17:13 [PATCH v2] EDAC/thunderx: Fix some potential buffer overflow in thunderx_ocx_com_threaded_isr() Christophe JAILLET
2023-10-21 19:23 ` Greg KH
2023-10-24 5:35 ` Dan Carpenter
2023-10-24 5:40 ` Dan Carpenter
2023-10-24 23:39 ` Kees Cook
2023-10-26 17:18 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310261016.2D17ACACE@keescook \
--to=keescook@chromium.org \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=james.morse@arm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=s.temerkhanov@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.