From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25E84C25B6B for ; Thu, 26 Oct 2023 11:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Cl1QiXhhPdlibRXrmBECd9WsBT+o8kiancMfjvK7jNc=; b=QzdwkwLmGegNV/ ZBZKUg43hLJfjCbyTWdkQGyRXkh0v+tPbIXgvYMNFN2XdAR/4vW+mqIoBAYPDAIHzbAX02Xk8g18/ jMHGAzMH1BQCWP706zz5CHcfg8yTA8aezwS8AegWuvDLDkvOKc+p93PG3uWAeIuobITI06vLFp0Ka fyFOboREfz+EDvZeZ4OwIfdlrFDi/xfzGuE7iJWC8Nw0Q3B/thMvBsY7pxAejKZf3cU83zVF1VLbq 9Zye75hSNGh02fI5EAMlcRz2dhNparptqY8ocm9/3VXo6dRCw6CDgr7n3Olw1tPnRS5DCw11lNedT VQj/mqBSCQWwxZ6uH1ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvyet-00ENNQ-2R; Thu, 26 Oct 2023 11:36:15 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvyeq-00ENM9-1t for linux-arm-kernel@lists.infradead.org; Thu, 26 Oct 2023 11:36:14 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4C6E983B; Thu, 26 Oct 2023 13:35:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1698320152; bh=3J1zW6vJbN0ZPEVT41jA29B2NH3cxfkd2aquGwq/Rl0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gmSyXJohwrhb64vD0qAeYE5ZQKFoszfn9eG61TKV56cR6LOaJncpo388lxekwAb0V Cf4auU/IuQi+fHPzxDbtMRrc9W44M1fQfd4UVbhOBSBmVUXQuLoQH9ynKibt5VWu0l GnhH5CsdythbIc9q1J35p5BBs6KHoL2JAZB242o4= Date: Thu, 26 Oct 2023 14:36:10 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: Alain Volmat , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Russell King , Philipp Zabel , Dan Scally , Hugues Fruchet , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/5] media: stm32-dcmipp: STM32 DCMIPP camera interface driver Message-ID: <20231026113610.GA26306@pendragon.ideasonboard.com> References: <20231010082413.1717919-1-alain.volmat@foss.st.com> <20231010082413.1717919-4-alain.volmat@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231026_043612_786468_1D6BFA1D X-CRM114-Status: GOOD ( 20.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sakari, On Thu, Oct 26, 2023 at 11:11:53AM +0000, Sakari Ailus wrote: > On Tue, Oct 10, 2023 at 10:24:03AM +0200, Alain Volmat wrote: > > From: Hugues Fruchet > > > > This V4L2 subdev driver enables Digital Camera Memory Interface > > Pixel Processor(DCMIPP) of STMicroelectronics STM32 SoC series. > > > > Signed-off-by: Hugues Fruchet > > Signed-off-by: Alain Volmat > > --- > > drivers/media/platform/st/stm32/Kconfig | 15 + > > drivers/media/platform/st/stm32/Makefile | 1 + > > .../platform/st/stm32/stm32-dcmipp/Makefile | 4 + > > .../st/stm32/stm32-dcmipp/dcmipp-bytecap.c | 916 ++++++++++++++++++ > > .../st/stm32/stm32-dcmipp/dcmipp-byteproc.c | 555 +++++++++++ > > .../st/stm32/stm32-dcmipp/dcmipp-common.c | 106 ++ > > .../st/stm32/stm32-dcmipp/dcmipp-common.h | 216 +++++ > > .../st/stm32/stm32-dcmipp/dcmipp-core.c | 603 ++++++++++++ > > .../st/stm32/stm32-dcmipp/dcmipp-parallel.c | 441 +++++++++ > > 9 files changed, 2857 insertions(+) > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/Makefile > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-byteproc.c > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-common.c > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-common.h > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-parallel.c [snip] > > diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c > > new file mode 100644 > > index 000000000000..4f784c5791e7 > > --- /dev/null > > +++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c > > @@ -0,0 +1,916 @@ [snip] > > +static const struct dcmipp_bytecap_pix_map * > > +dcmipp_bytecap_pix_map_by_pixelformat(u32 pixelformat) > > +{ > > + unsigned int i; > > + > > + for (i = 0; i < ARRAY_SIZE(dcmipp_bytecap_pix_map_list); i++) { > > No need for braces. Up to you. For what it's worth, I usually ask for braces in my reviews for these kind of cases :-) > > + if (dcmipp_bytecap_pix_map_list[i].pixelformat == pixelformat) > > + return &dcmipp_bytecap_pix_map_list[i]; > > + } > > + > > + return NULL; > > +} [snip] -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AE4B2D022 for ; Thu, 26 Oct 2023 11:36:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="gmSyXJoh" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 533EB1A6; Thu, 26 Oct 2023 04:36:10 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4C6E983B; Thu, 26 Oct 2023 13:35:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1698320152; bh=3J1zW6vJbN0ZPEVT41jA29B2NH3cxfkd2aquGwq/Rl0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gmSyXJohwrhb64vD0qAeYE5ZQKFoszfn9eG61TKV56cR6LOaJncpo388lxekwAb0V Cf4auU/IuQi+fHPzxDbtMRrc9W44M1fQfd4UVbhOBSBmVUXQuLoQH9ynKibt5VWu0l GnhH5CsdythbIc9q1J35p5BBs6KHoL2JAZB242o4= Date: Thu, 26 Oct 2023 14:36:10 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: Alain Volmat , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Russell King , Philipp Zabel , Dan Scally , Hugues Fruchet , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/5] media: stm32-dcmipp: STM32 DCMIPP camera interface driver Message-ID: <20231026113610.GA26306@pendragon.ideasonboard.com> References: <20231010082413.1717919-1-alain.volmat@foss.st.com> <20231010082413.1717919-4-alain.volmat@foss.st.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Hi Sakari, On Thu, Oct 26, 2023 at 11:11:53AM +0000, Sakari Ailus wrote: > On Tue, Oct 10, 2023 at 10:24:03AM +0200, Alain Volmat wrote: > > From: Hugues Fruchet > > > > This V4L2 subdev driver enables Digital Camera Memory Interface > > Pixel Processor(DCMIPP) of STMicroelectronics STM32 SoC series. > > > > Signed-off-by: Hugues Fruchet > > Signed-off-by: Alain Volmat > > --- > > drivers/media/platform/st/stm32/Kconfig | 15 + > > drivers/media/platform/st/stm32/Makefile | 1 + > > .../platform/st/stm32/stm32-dcmipp/Makefile | 4 + > > .../st/stm32/stm32-dcmipp/dcmipp-bytecap.c | 916 ++++++++++++++++++ > > .../st/stm32/stm32-dcmipp/dcmipp-byteproc.c | 555 +++++++++++ > > .../st/stm32/stm32-dcmipp/dcmipp-common.c | 106 ++ > > .../st/stm32/stm32-dcmipp/dcmipp-common.h | 216 +++++ > > .../st/stm32/stm32-dcmipp/dcmipp-core.c | 603 ++++++++++++ > > .../st/stm32/stm32-dcmipp/dcmipp-parallel.c | 441 +++++++++ > > 9 files changed, 2857 insertions(+) > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/Makefile > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-byteproc.c > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-common.c > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-common.h > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-parallel.c [snip] > > diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c > > new file mode 100644 > > index 000000000000..4f784c5791e7 > > --- /dev/null > > +++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c > > @@ -0,0 +1,916 @@ [snip] > > +static const struct dcmipp_bytecap_pix_map * > > +dcmipp_bytecap_pix_map_by_pixelformat(u32 pixelformat) > > +{ > > + unsigned int i; > > + > > + for (i = 0; i < ARRAY_SIZE(dcmipp_bytecap_pix_map_list); i++) { > > No need for braces. Up to you. For what it's worth, I usually ask for braces in my reviews for these kind of cases :-) > > + if (dcmipp_bytecap_pix_map_list[i].pixelformat == pixelformat) > > + return &dcmipp_bytecap_pix_map_list[i]; > > + } > > + > > + return NULL; > > +} [snip] -- Regards, Laurent Pinchart