From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: kernel-team@android.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] getpgid01: On Android, pgid(1) is 0 instead of 1
Date: Thu, 26 Oct 2023 13:40:52 +0200 [thread overview]
Message-ID: <20231026114052.GA597564@pevik> (raw)
In-Reply-To: <ZTpJUetaZJyPyDu5@yuki>
Hi,
...
> > #ifndef __ANDROID__
> > TST_EXP_EQ_LI(TST_RET, 0);
> > #else
> > TST_EXP_EQ_LI(TST_RET, 1);
> > #endif
> > Because your code would loosen testing for other libc.
> > Cyril, Li, WDYT?
> @Peter what about the case where we bypass all init and boot with
> init=/bin/sh or init=ltx? I suppose that we will have pgrp set to 0
> as well.
Ah, so v1 version was better, right?
> What about parsing /proc/1/stat and checking that the value there is the
> same as reported here, that should work regardless of what pid is the
> init.
That sounds best to me. I'm sorry Edward, could you please send v3?
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-10-26 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 0:05 [LTP] [PATCH] getpgid01: On Android, pgid(1) is 0 instead of 1 Edward Liaw via ltp
2023-09-30 6:54 ` Petr Vorel
2023-10-02 17:49 ` Edward Liaw via ltp
2023-10-26 11:11 ` Cyril Hrubis
2023-10-26 11:40 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231026114052.GA597564@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=kernel-team@android.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.