From: Rob Herring <robh@kernel.org>
To: Guo Mengqi <guomengqi3@huawei.com>
Cc: vkoul@kernel.org, dmaengine@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, xuqiang36@huawei.com,
chenweilong@huawei.com
Subject: Re: [PATCH v6 2/2] dt-bindings: dma: HiSilicon: Add bindings for HiSilicon Ascend sdma
Date: Thu, 26 Oct 2023 11:55:02 -0500 [thread overview]
Message-ID: <20231026165502.GA3979802-robh@kernel.org> (raw)
In-Reply-To: <20231026072549.103102-3-guomengqi3@huawei.com>
On Thu, Oct 26, 2023 at 03:25:49PM +0800, Guo Mengqi wrote:
> Add device-tree binding documentation for sdma hardware on
> HiSilicon Ascend SoC families.
>
> Signed-off-by: Guo Mengqi <guomengqi3@huawei.com>
> ---
This is where you explain any expected failure. Resending the same patch
with the same failure again is not a great strategy. The patch needs to
stand on its own and not rely on some explanation in a prior version.
> .../bindings/dma/hisilicon,ascend-sdma.yaml | 73 +++++++++++++++++++
> 1 file changed, 73 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/hisilicon,ascend-sdma.yaml
Reviewed-by: Rob Herring <robh@kernel.org>
I had missed that pasid-num-bits and dma-can-stall are IOMMU consumer
properties. (We really should have prefixed them with 'iommu'.) I've now
added them to dtschema which should fix the warning.
Rob
next prev parent reply other threads:[~2023-10-26 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 7:25 [PATCH v6 0/2] Add dma controller driver for HiSilicon Ascend310/910 Guo Mengqi
2023-10-26 7:25 ` [PATCH v6 1/2] dmaengine: Add HiSilicon Ascend SDMA engine support Guo Mengqi
2023-10-26 7:25 ` [PATCH v6 2/2] dt-bindings: dma: HiSilicon: Add bindings for HiSilicon Ascend sdma Guo Mengqi
2023-10-26 13:09 ` Rob Herring
2023-10-26 16:55 ` Rob Herring [this message]
2023-10-27 9:37 ` guomengqi (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231026165502.GA3979802-robh@kernel.org \
--to=robh@kernel.org \
--cc=chenweilong@huawei.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=guomengqi3@huawei.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=vkoul@kernel.org \
--cc=xuqiang36@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.