From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B79C25B48 for ; Thu, 26 Oct 2023 18:07:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231178AbjJZSHb (ORCPT ); Thu, 26 Oct 2023 14:07:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231550AbjJZSHa (ORCPT ); Thu, 26 Oct 2023 14:07:30 -0400 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FBE91B1; Thu, 26 Oct 2023 11:07:26 -0700 (PDT) Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-6cd1918afb2so658527a34.0; Thu, 26 Oct 2023 11:07:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698343646; x=1698948446; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ENEollqMGRKDMhbkSMkHaoD54thLMovQWmP1n7sRCUc=; b=GmE/V+sI1/WQXUB++djPnINZ9rRjRwXRsmMKn+t72afl1UvkxufzdVr4AQOif0mXYj LT65o0au8ksgYEo+VquGLluGdiK2N+kR+O6RF1Bd7GF1KcO15bQmOA93bJK4ME0E6DjD JXFf9uYeyXC19EhfrQMXhz7Poi1V0y88LAue7FLDV4zaHiB0hqJAyTeZIGPtNVkV3ts+ FoSNqGZMCsEnh3wSrm+BZcUZUOnAXjZIx5sAf0+rp6yC1hVYL0EQJhE2qbWeSJAa29mK uS570XXwozahuRGEVfU30zzlStzA8czJA+w94p3EeIB3e3NJuMBs31wdlmkIAxJs6mXX vr9A== X-Gm-Message-State: AOJu0Yz6t0gUEpXxv8qLXFHdzzH5u26qgVTTZAU183w54bRRGI/tu50E 1RdHdQgM6vayvL2UF9s6ew== X-Google-Smtp-Source: AGHT+IET1KctVP9taJ0RgRpXEMx9LPCq13Vxv2nxhaSHIPgh/LGOf33ATDy4SqI5QHe0tIaxDHaL5w== X-Received: by 2002:a05:6830:3110:b0:6b9:3f64:4e8c with SMTP id b16-20020a056830311000b006b93f644e8cmr232430ots.9.1698343645780; Thu, 26 Oct 2023 11:07:25 -0700 (PDT) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m6-20020a05683026c600b006c4d38e12b9sm2746216otu.65.2023.10.26.11.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 11:07:25 -0700 (PDT) Received: (nullmailer pid 4121876 invoked by uid 1000); Thu, 26 Oct 2023 18:07:24 -0000 Date: Thu, 26 Oct 2023 13:07:24 -0500 From: Rob Herring To: Manikanta Guntupalli Cc: git@amd.com, michal.simek@amd.com, gregkh@linuxfoundation.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org, radhey.shyam.pandey@amd.com, srinivas.goud@amd.com, shubhrajyoti.datta@amd.com, manion05gk@gmail.com Subject: Re: [PATCH V3 1/2] dt-bindings: Add optional gpio property to uartps node to support rs485 Message-ID: <20231026180724.GA4108223-robh@kernel.org> References: <20231024144847.2316941-1-manikanta.guntupalli@amd.com> <20231024144847.2316941-2-manikanta.guntupalli@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231024144847.2316941-2-manikanta.guntupalli@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Tue, Oct 24, 2023 at 08:18:46PM +0530, Manikanta Guntupalli wrote: > Add optional gpio property to uartps node and reference to rs485.yaml > > On Xilinx/AMD Kria SOM KD240 board rs485 connects via TI ISOW1432 > Transceiver device, where one GPIO is used for driving DE/RE signals. > With rs485 half duplex configuration, DE and RE are shorted to each other, > and at a time, any node acts as either a driver or a receiver. > > Here, > DE - Driver enable. If pin is floating, driver is disabled. > RE - Receiver enable. If pin is floating, receiver buffer is disabled. What happens when pin is not floating? Is floating (i.e. open drain) for RTS a requirement? And floating doesn't define high or low because it could be pulled either way. > > For more deatils, please find below link which contains Transceiver > device(ISOW1432) datasheet > https://www.ti.com/lit/ds/symlink/isow1432.pdf?ts=1682607122706&ref_url=https%253A%252F%252Fwww.ti.com%252Fproduct%252FISOW1432%252Fpart-details%252FISOW1432DFMR%253FkeyMatch%253DISOW1432DFMR%2526tisearch%253Dsearch-everything%2526usecase%253DOPN > > rts-gpios is optional property, because it is not required > for uart console node. > > Signed-off-by: Manikanta Guntupalli > --- > Changes for V2: > Modify optional gpio name to xlnx,phy-ctrl-gpios. > Update commit description. > Changes for V3: > Modify optional gpio name to rts-gpios. > Update commit description. > --- > Documentation/devicetree/bindings/serial/cdns,uart.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.yaml b/Documentation/devicetree/bindings/serial/cdns,uart.yaml > index e35ad1109efc..7ee305f9a45f 100644 > --- a/Documentation/devicetree/bindings/serial/cdns,uart.yaml > +++ b/Documentation/devicetree/bindings/serial/cdns,uart.yaml > @@ -46,6 +46,11 @@ properties: > power-domains: > maxItems: 1 > > + rts-gpios: > + description: Optional GPIO to control transmit/receive on RS485 phy > + in halfduplex mode. You need to define what 'active' means here because -gpios all have an active flag. Is it always active low (or high) or depends on the board? > + maxItems: 1 > + > required: > - compatible > - reg > @@ -55,6 +60,7 @@ required: > > allOf: > - $ref: serial.yaml# > + - $ref: rs485.yaml# > - if: > properties: > compatible: > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F042DC25B48 for ; Thu, 26 Oct 2023 18:07:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n6sKuw+sVYqWXrgKi89hB4C5M3yV26y7zP/nnHmnYao=; b=b8YDJ/g0T3J4MR cJTT9p1wsDVLwZiy7MRmInjpmpJYBx789L0xSh5P6B2D1c1GBG23I8JLWEqqZzn/t8SLvG77uWY0n LiE01sLsHVWqyfeDjD6ffB9pwD5v3B668Ra0yWj2KInLWzSOf9W/QT0gxVZKdqvDHFxkqZurPN5zt Ba2PbwjnMoRXLDE8eHY+ffQLlx4lobBmHEAtlfAmeeYp6ydsZwXZeBPXEfTK4ijxEG7EwbgNF86J6 i1Z3jvC+yM243dgKtfgSYvUm10+RHGO4SJaqwprdN6J3gnDZ36/Hmq9a1oLWyIe5+FIF8F6CVj/4V gmn/JD9Uuj4lheMkjFEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qw4lW-00EyNj-0X; Thu, 26 Oct 2023 18:07:30 +0000 Received: from mail-ot1-f48.google.com ([209.85.210.48]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qw4lT-00EyMy-2Y for linux-arm-kernel@lists.infradead.org; Thu, 26 Oct 2023 18:07:29 +0000 Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-6cd09f51fe0so655680a34.1 for ; Thu, 26 Oct 2023 11:07:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698343646; x=1698948446; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ENEollqMGRKDMhbkSMkHaoD54thLMovQWmP1n7sRCUc=; b=FioB0/nkpq2W4hqNtrXCgqN2O9DHs30BsvOv6YCLld/Ny+FyeHUctUyDSW9PEHrTr9 /M5W+PhvargQHY3QtNY9tAkSy6WYbdFSEUzIFRrc1Se3dFaAF0Vwhts+Ckgx/NG+pgPj gZvhDA9YSSUNnI1GGJ6CnH/eWl3xqzTFwEDCIqERNjEqc2hgB2dsyR6dq3+BylleRO1w CIMhrGn2keuZA+P+YZJ1apqZnHS2IOlTAoG30WH9H6EA3Fc5q+STZPb+kAjBnQIuKudL pHgU99uYXJ2dpdF9sFfLNZlMIToCFgcVZ0UFZcH7EAcr8YNviB+uhYQ4MKPob1wkbEPc z+ig== X-Gm-Message-State: AOJu0YxVr5WzoAvA7sMkidTVQBjJgBKqyGdBTbCksou1/1d8dy1jZ4Vl 5SzYWSwrO2WGr5tIEZsVMA== X-Google-Smtp-Source: AGHT+IET1KctVP9taJ0RgRpXEMx9LPCq13Vxv2nxhaSHIPgh/LGOf33ATDy4SqI5QHe0tIaxDHaL5w== X-Received: by 2002:a05:6830:3110:b0:6b9:3f64:4e8c with SMTP id b16-20020a056830311000b006b93f644e8cmr232430ots.9.1698343645780; Thu, 26 Oct 2023 11:07:25 -0700 (PDT) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m6-20020a05683026c600b006c4d38e12b9sm2746216otu.65.2023.10.26.11.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 11:07:25 -0700 (PDT) Received: (nullmailer pid 4121876 invoked by uid 1000); Thu, 26 Oct 2023 18:07:24 -0000 Date: Thu, 26 Oct 2023 13:07:24 -0500 From: Rob Herring To: Manikanta Guntupalli Cc: git@amd.com, michal.simek@amd.com, gregkh@linuxfoundation.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org, radhey.shyam.pandey@amd.com, srinivas.goud@amd.com, shubhrajyoti.datta@amd.com, manion05gk@gmail.com Subject: Re: [PATCH V3 1/2] dt-bindings: Add optional gpio property to uartps node to support rs485 Message-ID: <20231026180724.GA4108223-robh@kernel.org> References: <20231024144847.2316941-1-manikanta.guntupalli@amd.com> <20231024144847.2316941-2-manikanta.guntupalli@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231024144847.2316941-2-manikanta.guntupalli@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231026_110727_825855_8DEE9210 X-CRM114-Status: GOOD ( 21.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 24, 2023 at 08:18:46PM +0530, Manikanta Guntupalli wrote: > Add optional gpio property to uartps node and reference to rs485.yaml > > On Xilinx/AMD Kria SOM KD240 board rs485 connects via TI ISOW1432 > Transceiver device, where one GPIO is used for driving DE/RE signals. > With rs485 half duplex configuration, DE and RE are shorted to each other, > and at a time, any node acts as either a driver or a receiver. > > Here, > DE - Driver enable. If pin is floating, driver is disabled. > RE - Receiver enable. If pin is floating, receiver buffer is disabled. What happens when pin is not floating? Is floating (i.e. open drain) for RTS a requirement? And floating doesn't define high or low because it could be pulled either way. > > For more deatils, please find below link which contains Transceiver > device(ISOW1432) datasheet > https://www.ti.com/lit/ds/symlink/isow1432.pdf?ts=1682607122706&ref_url=https%253A%252F%252Fwww.ti.com%252Fproduct%252FISOW1432%252Fpart-details%252FISOW1432DFMR%253FkeyMatch%253DISOW1432DFMR%2526tisearch%253Dsearch-everything%2526usecase%253DOPN > > rts-gpios is optional property, because it is not required > for uart console node. > > Signed-off-by: Manikanta Guntupalli > --- > Changes for V2: > Modify optional gpio name to xlnx,phy-ctrl-gpios. > Update commit description. > Changes for V3: > Modify optional gpio name to rts-gpios. > Update commit description. > --- > Documentation/devicetree/bindings/serial/cdns,uart.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.yaml b/Documentation/devicetree/bindings/serial/cdns,uart.yaml > index e35ad1109efc..7ee305f9a45f 100644 > --- a/Documentation/devicetree/bindings/serial/cdns,uart.yaml > +++ b/Documentation/devicetree/bindings/serial/cdns,uart.yaml > @@ -46,6 +46,11 @@ properties: > power-domains: > maxItems: 1 > > + rts-gpios: > + description: Optional GPIO to control transmit/receive on RS485 phy > + in halfduplex mode. You need to define what 'active' means here because -gpios all have an active flag. Is it always active low (or high) or depends on the board? > + maxItems: 1 > + > required: > - compatible > - reg > @@ -55,6 +60,7 @@ required: > > allOf: > - $ref: serial.yaml# > + - $ref: rs485.yaml# > - if: > properties: > compatible: > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel