From: Rob Herring <robh@kernel.org>
To: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Cc: netdev@vger.kernel.org, linus.walleij@linaro.org,
alsi@bang-olufsen.dk, andrew@lunn.ch, vivien.didelot@gmail.com,
f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net,
kuba@kernel.org, pabeni@redhat.com, krzk+dt@kernel.org,
arinc.unal@arinc9.com, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] dt-bindings: net: dsa: realtek: add reset controller
Date: Thu, 26 Oct 2023 15:58:07 -0500 [thread overview]
Message-ID: <20231026205807.GA347941-robh@kernel.org> (raw)
In-Reply-To: <20231024205805.19314-3-luizluca@gmail.com>
On Tue, Oct 24, 2023 at 05:58:06PM -0300, Luiz Angelo Daros de Luca wrote:
> Realtek switches can now be reset using a reset controller.
>
> The 'reset-gpios' were never mandatory for the driver, although they
> are required for some devices if the switch reset was left asserted by
> a previous driver, such as the bootloader.
>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
> Cc: devicetree@vger.kernel.org
> ---
> Documentation/devicetree/bindings/net/dsa/realtek.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> index cce692f57b08..070821eae2a7 100644
> --- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml
> @@ -59,6 +59,12 @@ properties:
> description: GPIO to be used to reset the whole device
> maxItems: 1
>
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + const: switch
$block-name is not really a useful name for resources. Generally, you
don't need -names if there's only 1 entry.
> +
> realtek,disable-leds:
> type: boolean
> description: |
> @@ -127,7 +133,6 @@ else:
> - mdc-gpios
> - mdio-gpios
> - mdio
> - - reset-gpios
>
> required:
> - compatible
> --
> 2.42.0
>
next prev parent reply other threads:[~2023-10-26 20:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 20:58 [PATCH net-next 1/2] net: dsa: realtek: support reset controller Luiz Angelo Daros de Luca
2023-10-24 20:58 ` [PATCH net-next 2/2] dt-bindings: net: dsa: realtek: add " Luiz Angelo Daros de Luca
2023-10-24 22:39 ` Vladimir Oltean
2023-10-26 10:34 ` Arınç ÜNAL
2023-10-26 20:09 ` Luiz Angelo Daros de Luca
2023-10-26 20:58 ` Rob Herring [this message]
2023-10-26 22:03 ` Luiz Angelo Daros de Luca
2023-10-24 21:09 ` [PATCH net-next 1/2] net: dsa: realtek: support " Florian Fainelli
2023-10-24 22:02 ` Luiz Angelo Daros de Luca
2023-10-24 22:06 ` Florian Fainelli
2023-10-24 22:07 ` Vladimir Oltean
2023-10-24 22:17 ` Luiz Angelo Daros de Luca
2023-10-24 22:32 ` Andrew Lunn
2023-10-24 22:33 ` Vladimir Oltean
2023-10-25 18:30 ` Luiz Angelo Daros de Luca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231026205807.GA347941-robh@kernel.org \
--to=robh@kernel.org \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=arinc.unal@arinc9.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.