Re: [bitbake-devel] [PATCH v2] bitbake: fetch2: git: Add git-lfs install step

[Luca Ceresoli <luca.ceresoli@bootlin.com>]

Hello Desone,

On Thu, 26 Oct 2023 15:08:20 -0400
"Desone Burns" <dburns@seegrid.com> wrote:

> When downloading a Git repository containing an LFS, the Git hooks
> are not always initialized correctly to perform the download. This
> change updates the Git downloader to run the "git lfs install" command
> in order to "smudge" the LFS files. The tests have also been updated
> to do checks for situations in which git lfs is not installed, as
> the application was required to be installed for any of the tests
> to run previously.
> 
> The Git LFS functionality was working to some degree previously,
> but this change also updates the fetcher to allow LFS downloads for
> nobranch SRC_URIs.
> 
> Signed-off-by: Desone Burns II <dburns@seegrid.com>
> ---
>  bitbake/lib/bb/fetch2/git.py  | 14 ++++++--
>  bitbake/lib/bb/tests/fetch.py | 61 ++++++++++++++++++++---------------
>  2 files changed, 47 insertions(+), 28 deletions(-)
> 
> diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
> index 27a0d05144..5fb573a381 100644
> --- a/bitbake/lib/bb/fetch2/git.py
> +++ b/bitbake/lib/bb/fetch2/git.py
> @@ -52,6 +52,11 @@ Supported SRC_URI options are:
>     For local git:// urls to use the current branch HEAD as the
> revision for use with
>     AUTOREV. Implies nobranch.
> 
> +- lfs
> +    Enable the checkout to use LFS for large files. This will
> download all LFS files

This patch does not apply. The wrapped line here is the reason, or one
of the reasons.

Can you use 'git send-email'? That would simplify life to everybody.

Also check the Contributor guide:
https://docs.yoctoproject.org/contributor-guide/submit-changes.html#sending-the-patches-via-email

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com