All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: David Wei <davidhwei@meta.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [isilence:zc/veth 1010/1018] io_uring/net.c:1071:40: sparse: sparse: Using plain integer as NULL pointer
Date: Fri, 27 Oct 2023 04:55:22 +0800	[thread overview]
Message-ID: <202310270410.i2YHUIFm-lkp@intel.com> (raw)

tree:   https://github.com/isilence/linux zc/veth
head:   cff8a226d561bc0db814b65ca5d2c97894d4d1cd
commit: 8206eff884a896c949649e8a9160b085a6f8cc82 [1010/1018] io_uring: add io_recvzc request
config: i386-randconfig-061-20231026 (https://download.01.org/0day-ci/archive/20231027/202310270410.i2YHUIFm-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231027/202310270410.i2YHUIFm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310270410.i2YHUIFm-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
   io_uring/net.c: note: in included file (through io_uring/io_uring.h):
   include/linux/io_uring_types.h:308:48: sparse: sparse: array of flexible structures
>> io_uring/net.c:1071:40: sparse: sparse: Using plain integer as NULL pointer

vim +1071 io_uring/net.c

  1016	
  1017	int io_recvzc(struct io_kiocb *req, unsigned int issue_flags)
  1018	{
  1019		struct io_recvzc *zc = io_kiocb_to_cmd(req, struct io_recvzc);
  1020		struct socket *sock;
  1021		unsigned flags;
  1022		int ret, min_ret = 0;
  1023		bool force_nonblock = issue_flags & IO_URING_F_NONBLOCK;
  1024	
  1025		if (!(req->flags & REQ_F_POLLED) &&
  1026		    (zc->flags & IORING_RECVSEND_POLL_FIRST))
  1027			return -EAGAIN;
  1028	
  1029		sock = sock_from_file(req->file);
  1030		if (unlikely(!sock))
  1031			return -ENOTSOCK;
  1032	
  1033	retry_multishot:
  1034		flags = zc->msg_flags;
  1035		if (force_nonblock)
  1036			flags |= MSG_DONTWAIT;
  1037		if (flags & MSG_WAITALL)
  1038			min_ret = zc->len;
  1039	
  1040		ret = io_zc_rx_recv(sock, zc->datalen, flags);
  1041		if (ret < min_ret) {
  1042			if (ret == -EAGAIN && force_nonblock) {
  1043				if (issue_flags & IO_URING_F_MULTISHOT) {
  1044					io_kbuf_recycle(req, issue_flags);
  1045					return IOU_ISSUE_SKIP_COMPLETE;
  1046				}
  1047	
  1048				return -EAGAIN;
  1049			}
  1050			if (ret > 0 && io_net_retry(sock, flags)) {
  1051				zc->len -= ret;
  1052				zc->buf += ret;
  1053				zc->done_io += ret;
  1054				req->flags |= REQ_F_PARTIAL_IO;
  1055				return -EAGAIN;
  1056			}
  1057			if (ret == -ERESTARTSYS)
  1058				ret = -EINTR;
  1059			req_set_fail(req);
  1060		} else if ((flags & MSG_WAITALL) && (flags & (MSG_TRUNC | MSG_CTRUNC))) {
  1061			req_set_fail(req);
  1062		}
  1063	
  1064		if (ret > 0)
  1065			ret += zc->done_io;
  1066		else if (zc->done_io)
  1067			ret = zc->done_io;
  1068		else
  1069			io_kbuf_recycle(req, issue_flags);
  1070	
> 1071		if (!io_recv_finish(req, &ret, 0, ret <= 0, issue_flags))
  1072			goto retry_multishot;
  1073	
  1074		return ret;
  1075	}
  1076	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-10-26 20:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202310270410.i2YHUIFm-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=davidhwei@meta.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.