From: Christoph Hellwig <hch@lst.de>
To: Pankaj Raghav <kernel@pankajraghav.com>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
willy@infradead.org, djwong@kernel.org, mcgrof@kernel.org,
hch@lst.de, da.gomez@samsung.com, gost.dev@samsung.com,
david@fromorbit.com, Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCH] iomap: fix iomap_dio_zero() for fs bs > system page size
Date: Fri, 27 Oct 2023 07:18:47 +0200 [thread overview]
Message-ID: <20231027051847.GA7885@lst.de> (raw)
In-Reply-To: <20231026140832.1089824-1-kernel@pankajraghav.com>
>
> - __bio_add_page(bio, page, len, 0);
> + while (len) {
> + unsigned int io_len = min_t(unsigned int, len, PAGE_SIZE);
> +
> + __bio_add_page(bio, page, io_len, 0);
> + len -= io_len;
> + }
Maybe out of self-interest, but shouldn't we replace ZERO_PAGE with a
sufficiently larger ZERO_FOLIO? Right now I have a case where I have
to have a zero padding of up to MAX_PAGECACHE_ORDER minus block size,
so having a MAX_PAGECACHE_ORDER folio would have been really helpful
for me, but I suspect there are many other such cases as well.
next prev parent reply other threads:[~2023-10-27 5:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 14:08 [PATCH] iomap: fix iomap_dio_zero() for fs bs > system page size Pankaj Raghav
2023-10-26 22:10 ` Dave Chinner
2023-10-27 7:53 ` Pankaj Raghav
2023-10-27 22:07 ` Dave Chinner
2023-10-26 23:20 ` Luis Chamberlain
2023-10-27 5:18 ` Christoph Hellwig [this message]
2023-10-27 8:03 ` Pankaj Raghav
2023-10-27 10:47 ` Matthew Wilcox
2023-10-27 15:41 ` Pankaj Raghav
2023-10-27 22:59 ` Matthew Wilcox
2023-10-28 19:57 ` Pankaj Raghav
2023-10-28 13:17 ` Hannes Reinecke
2023-10-28 16:57 ` Pankaj Raghav
2023-10-27 22:10 ` Dave Chinner
2023-10-28 17:20 ` Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231027051847.GA7885@lst.de \
--to=hch@lst.de \
--cc=da.gomez@samsung.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=gost.dev@samsung.com \
--cc=kernel@pankajraghav.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.