From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,
edumazet@google.com
Subject: Re: [patch net-next v3] tools: ynl: introduce option to process unknown attributes or types
Date: Fri, 27 Oct 2023 07:08:15 -0700 [thread overview]
Message-ID: <20231027070815.43036c75@kernel.org> (raw)
In-Reply-To: <ZTt2o294RMW+MwKs@nanopsycho>
On Fri, 27 Oct 2023 10:36:51 +0200 Jiri Pirko wrote:
> >Maybe a good compromise is to stick it into the key, instead of the
> >value. Replacing the stringified type id. Then you can keep the
> >value as binary.
>
> Okay, that sounds good. But "key": \bvalue is not something to be
> printed out by __repr__() as it outs string. Therefore I don't
> understand how this compiles with your key requirement above.
> I have to be missing something, pardon my ignorance.
FWIW the assignment would then become (pseudo-code):
if real attr:
rsp[name] = [decoded]
else:
rsp[UnknownNlAttrKey(nla)] = self._decode_unknown(nla)
prev parent reply other threads:[~2023-10-27 14:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 9:57 [patch net-next v3] tools: ynl: introduce option to process unknown attributes or types Jiri Pirko
2023-10-26 0:56 ` Jakub Kicinski
2023-10-26 5:42 ` Jiri Pirko
2023-10-26 14:41 ` Jakub Kicinski
2023-10-26 14:46 ` Jakub Kicinski
2023-10-26 16:24 ` Jiri Pirko
2023-10-26 16:25 ` Jiri Pirko
2023-10-26 19:30 ` Jakub Kicinski
2023-10-27 8:36 ` Jiri Pirko
2023-10-27 14:08 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231027070815.43036c75@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.