From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Christian Brauner <brauner@kernel.org>,
Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH RFC 4/6] bdev: simplify waiting for concurrent claimers
Date: Fri, 27 Oct 2023 09:21:21 +0200 [thread overview]
Message-ID: <20231027072121.GA11134@lst.de> (raw)
In-Reply-To: <20231025155439.5otniolu5mydjoon@quack3>
On Wed, Oct 25, 2023 at 05:54:39PM +0200, Jan Kara wrote:
> This test implicitely assumes that 0 is BD_CLAIM_DEFAULT. I guess that's
> fine although I somewhat prefer explicit value test like:
>
> if (whole->bd_claim != BD_CLAIM_DEFAULT)
I find the BD_CLAIM_DEFAULT confusing to be honest. I'd expect null
to just be check as:
if (whole->bd_claim)
That being said, instead of doing all the manual atomic magic, why
not add an
unsigned long bd_state;
to struct block_device instead of bd_claim, then define a single
bit for a device being clamed and simply everything while also
giving us space for more bits if we ever need them?
next prev parent reply other threads:[~2023-10-27 7:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 14:53 [PATCH RFC 0/6] fs,block: yield devices Christian Brauner
2023-10-24 14:53 ` [PATCH RFC 1/6] fs: simplify setup_bdev_super() calls Christian Brauner
2023-10-25 15:29 ` Jan Kara
2023-10-27 6:42 ` Christoph Hellwig
2023-10-24 14:53 ` [PATCH RFC 2/6] xfs: simplify device handling Christian Brauner
2023-10-25 15:30 ` Jan Kara
2023-10-27 6:42 ` Christoph Hellwig
2023-10-24 14:53 ` [PATCH RFC 3/6] ext4: " Christian Brauner
2023-10-25 15:30 ` Jan Kara
2023-10-27 6:42 ` Christoph Hellwig
2023-10-24 14:53 ` [PATCH RFC 4/6] bdev: simplify waiting for concurrent claimers Christian Brauner
2023-10-25 15:54 ` Jan Kara
2023-10-27 7:21 ` Christoph Hellwig [this message]
2023-10-24 14:53 ` [PATCH RFC 5/6] block: mark device as about to be released Christian Brauner
2023-10-24 14:53 ` [PATCH RFC 6/6] fs: add ->yield_devices() Christian Brauner
2023-10-25 17:20 ` [PATCH RFC 0/6] fs,block: yield devices Jan Kara
2023-10-25 20:46 ` Christian Brauner
2023-10-26 10:35 ` Jan Kara
2023-10-26 12:07 ` Christian Brauner
2023-10-26 13:04 ` Jan Kara
2023-10-26 15:08 ` Christian Brauner
2023-10-26 15:58 ` Jan Kara
2023-10-27 7:24 ` Christoph Hellwig
2023-10-26 11:50 ` (subset) " Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231027072121.GA11134@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.