From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Arnd Bergmann <arnd@arndb.de>,
Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/2] nvme: keyring: fix conditional compilation
Date: Fri, 27 Oct 2023 10:56:44 +0200 [thread overview]
Message-ID: <20231027085644.GA19366@lst.de> (raw)
In-Reply-To: <9bd4e078-b206-48b8-b94b-bc411317bb3d@suse.de>
On Fri, Oct 27, 2023 at 10:54:42AM +0200, Hannes Reinecke wrote:
>> I don't really mind the link order, for these cases I usually add a
>> comment to the Makefile so that people don't accidentally change it.
>
> Point is not that it has to be initialized first, point is it has to be
> initialized only _once_.
module_init ensure it is only initialized once except for the case where
the module is unloaded and reloaded, in which case you actually do need
to initialize it again.
> So when moving it into a separate module we cannot use the Makefile trick
> from Christoph
why?
next prev parent reply other threads:[~2023-10-27 8:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 13:08 [PATCH 0/2] [v4] nvme: fixup module compilation Hannes Reinecke
2023-10-26 13:08 ` [PATCH 1/2] nvme: common: make keyring and auth separate modules Hannes Reinecke
2023-10-26 13:08 ` [PATCH 2/2] nvme: keyring: fix conditional compilation Hannes Reinecke
2023-10-26 13:37 ` Arnd Bergmann
2023-10-26 14:20 ` Hannes Reinecke
2023-10-26 14:44 ` Arnd Bergmann
2023-10-27 5:21 ` Christoph Hellwig
2023-10-27 6:01 ` Hannes Reinecke
2023-10-27 8:12 ` Arnd Bergmann
2023-10-27 8:30 ` Christoph Hellwig
2023-10-27 8:54 ` Hannes Reinecke
2023-10-27 8:56 ` Christoph Hellwig [this message]
2023-10-27 9:08 ` Hannes Reinecke
2023-10-27 9:14 ` Arnd Bergmann
2023-10-27 9:21 ` Christoph Hellwig
2023-11-07 17:49 ` Keith Busch
-- strict thread matches above, loose matches on Subject: below --
2023-10-25 8:12 [PATCH 0/2] [v3]: nvme: fixup module compilation Hannes Reinecke
2023-10-25 8:12 ` [PATCH 2/2] nvme: keyring: fix conditional compilation Hannes Reinecke
2023-10-25 8:20 ` Arnd Bergmann
2023-10-25 9:11 ` Hannes Reinecke
2023-10-25 12:16 ` Arnd Bergmann
2023-10-25 15:00 ` Hannes Reinecke
2023-10-25 15:35 ` Arnd Bergmann
2023-10-26 11:58 ` Christoph Hellwig
2023-10-20 13:05 [PATCH 1/2] nvme: common: make keyring and auth separate modules Arnd Bergmann
2023-10-20 13:05 ` [PATCH 2/2] nvme: keyring: fix conditional compilation Arnd Bergmann
2023-10-20 13:50 ` Hannes Reinecke
2023-10-20 14:56 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231027085644.GA19366@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.