From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA1B98F75 for ; Fri, 27 Oct 2023 07:07:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1cKRZ/dq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51BD8C433C7; Fri, 27 Oct 2023 07:07:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698390461; bh=wJS+QNrJXp1MsR3/ZUU86Cl8sI9OcARWlPbkBdr/bKk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1cKRZ/dqG1UPyK7jGIKlc7d4qyLaGMVNalQpqY5YHNuJmLJssUWMCh6+DxStZzOCx ycijrCqRKHCwG3bBlKXxj6ROCUqVDwp9sptIHEiJoXAY5OMP9E1PBCQQoH3nnqTxU/ IxMV/TmCRUpp4AVho4hqjROmuArhRVLTI/EHMcDk= Date: Fri, 27 Oct 2023 09:07:36 +0200 From: Greg KH To: Kalle Valo Cc: Witold Baryluk , arnd@kernel.org, Larry.Finger@lwfinger.net, alexandre.belloni@bootlin.com, arnd@arndb.de, claudiu.beznea@tuxon.dev, davem@davemloft.net, geert@linux-m68k.org, geoff@infradead.org, gregory.greenman@intel.com, ilw@linux.intel.com, johannes@sipsolutions.net, kuba@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, nicolas.ferre@microchip.com, pavel@ucw.cz, quic_jjohnson@quicinc.com, stas.yakovlev@gmail.com, stf_xl@wp.pl Subject: Re: [PATCH 10/10] [RFC] wifi: remove ipw2100/ipw2200 drivers Message-ID: <2023102709-purse-repressed-d8b9@gregkh> References: <87o7gld8l4.fsf@kernel.org> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o7gld8l4.fsf@kernel.org> On Thu, Oct 26, 2023 at 12:41:27PM +0300, Kalle Valo wrote: > For example, I see lots of dead code under '#ifdef NOT_YET' and '#if 0', > removing those is a good a start. Also converting the ugly debug_level > procfs file to something more modern would be nice, maybe using just > dev_dbg() throught the driver is a good option? Or maybe use a module > parameter instead? Ick, no new module parameters, this isn't the 1990's, please just use the netdev debug lines instead :) thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DE02C25B67 for ; Fri, 27 Oct 2023 07:08:38 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=1cKRZ/dq; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SGv045vpkz3cTs for ; Fri, 27 Oct 2023 18:08:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=1cKRZ/dq; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SGtz529zlz2xgw for ; Fri, 27 Oct 2023 18:07:45 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5A83D6127C; Fri, 27 Oct 2023 07:07:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51BD8C433C7; Fri, 27 Oct 2023 07:07:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698390461; bh=wJS+QNrJXp1MsR3/ZUU86Cl8sI9OcARWlPbkBdr/bKk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1cKRZ/dqG1UPyK7jGIKlc7d4qyLaGMVNalQpqY5YHNuJmLJssUWMCh6+DxStZzOCx ycijrCqRKHCwG3bBlKXxj6ROCUqVDwp9sptIHEiJoXAY5OMP9E1PBCQQoH3nnqTxU/ IxMV/TmCRUpp4AVho4hqjROmuArhRVLTI/EHMcDk= Date: Fri, 27 Oct 2023 09:07:36 +0200 From: Greg KH To: Kalle Valo Subject: Re: [PATCH 10/10] [RFC] wifi: remove ipw2100/ipw2200 drivers Message-ID: <2023102709-purse-repressed-d8b9@gregkh> References: <87o7gld8l4.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o7gld8l4.fsf@kernel.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, Witold Baryluk , pavel@ucw.cz, gregory.greenman@intel.com, stf_xl@wp.pl, linux-staging@lists.linux.dev, ilw@linux.intel.com, geert@linux-m68k.org, kuba@kernel.org, stas.yakovlev@gmail.com, arnd@arndb.de, nicolas.ferre@microchip.com, linux-arm-kernel@lists.infradead.org, arnd@kernel.org, geoff@infradead.org, linuxppc-dev@lists.ozlabs.org, linux-wireless@vger.kernel.org, claudiu.beznea@tuxon.dev, johannes@sipsolutions.net, quic_jjohnson@quicinc.com, davem@davemloft.net, Larry.Finger@lwfinger.net Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Oct 26, 2023 at 12:41:27PM +0300, Kalle Valo wrote: > For example, I see lots of dead code under '#ifdef NOT_YET' and '#if 0', > removing those is a good a start. Also converting the ugly debug_level > procfs file to something more modern would be nice, maybe using just > dev_dbg() throught the driver is a good option? Or maybe use a module > parameter instead? Ick, no new module parameters, this isn't the 1990's, please just use the netdev debug lines instead :) thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CAF0C25B47 for ; Fri, 27 Oct 2023 07:08:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tXj9OsQtdL0C9u29qMt+Y81xNogm+cshdNhPSCq8xOA=; b=dvM4lIBdJ3mcxt 5e6p4bUylwnfRoxzvFg8TnG5ui/glJzrwbpJLcFQpQshNMpvtT2LGMaD43oP9xPawH6cedxIFppxA ARULcoT05lYWCIl96DKsxo6Dpt4A/Du/MhvuDUO1MiyxLxJ3ZltstZYttXftCTDVRzo6cFzDYuMkl lZPWFT5HibD9aml0eQ2HTOoNfUWTxoVDiT2a+OEm4f0ZU3sAFnWRQyrWp1kVBr4MXzGWpVkRAdu78 pALcrtxGFh3StGZc/x3aDTCrA2hQ5sb5cQNusqSCjrxJqob3NVPzE0mQZuQLl2z3xd08UNrCcdSNs Ca53eStTrODSFE/wotBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qwGwc-00Fjbu-16; Fri, 27 Oct 2023 07:07:46 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qwGwZ-00Fjb5-0u for linux-arm-kernel@lists.infradead.org; Fri, 27 Oct 2023 07:07:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5A83D6127C; Fri, 27 Oct 2023 07:07:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51BD8C433C7; Fri, 27 Oct 2023 07:07:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698390461; bh=wJS+QNrJXp1MsR3/ZUU86Cl8sI9OcARWlPbkBdr/bKk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1cKRZ/dqG1UPyK7jGIKlc7d4qyLaGMVNalQpqY5YHNuJmLJssUWMCh6+DxStZzOCx ycijrCqRKHCwG3bBlKXxj6ROCUqVDwp9sptIHEiJoXAY5OMP9E1PBCQQoH3nnqTxU/ IxMV/TmCRUpp4AVho4hqjROmuArhRVLTI/EHMcDk= Date: Fri, 27 Oct 2023 09:07:36 +0200 From: Greg KH To: Kalle Valo Subject: Re: [PATCH 10/10] [RFC] wifi: remove ipw2100/ipw2200 drivers Message-ID: <2023102709-purse-repressed-d8b9@gregkh> References: <87o7gld8l4.fsf@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87o7gld8l4.fsf@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231027_000743_380020_731A074D X-CRM114-Status: UNSURE ( 9.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, Witold Baryluk , pavel@ucw.cz, gregory.greenman@intel.com, stf_xl@wp.pl, linux-staging@lists.linux.dev, ilw@linux.intel.com, geert@linux-m68k.org, kuba@kernel.org, stas.yakovlev@gmail.com, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, arnd@kernel.org, geoff@infradead.org, linuxppc-dev@lists.ozlabs.org, linux-wireless@vger.kernel.org, claudiu.beznea@tuxon.dev, johannes@sipsolutions.net, quic_jjohnson@quicinc.com, davem@davemloft.net, Larry.Finger@lwfinger.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 26, 2023 at 12:41:27PM +0300, Kalle Valo wrote: > For example, I see lots of dead code under '#ifdef NOT_YET' and '#if 0', > removing those is a good a start. Also converting the ugly debug_level > procfs file to something more modern would be nice, maybe using just > dev_dbg() throught the driver is a good option? Or maybe use a module > parameter instead? Ick, no new module parameters, this isn't the 1990's, please just use the netdev debug lines instead :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel