From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Stefan Hajnoczi" <stefanha@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Emmanouil Pitsidianakis" <manos.pitsidianakis@linaro.org>
Subject: [PULL 03/11] tests/virtio-scsi: Clean up global variable shadowing
Date: Fri, 27 Oct 2023 11:37:02 +0200 [thread overview]
Message-ID: <20231027093710.273558-4-thuth@redhat.com> (raw)
In-Reply-To: <20231027093710.273558-1-thuth@redhat.com>
From: Philippe Mathieu-Daudé <philmd@linaro.org>
Rename the (unused) 'allow' argument, following the pattern
used by the other tests in this file. This fixes:
tests/qtest/virtio-scsi-test.c:159:61: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
static void hotplug(void *obj, void *data, QGuestAllocator *alloc)
^
tests/qtest/virtio-scsi-test.c:37:25: note: previous declaration is here
static QGuestAllocator *alloc;
^
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-By: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20231009100251.56019-4-philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/virtio-scsi-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/virtio-scsi-test.c b/tests/qtest/virtio-scsi-test.c
index ceaa7f2415..db10d572d0 100644
--- a/tests/qtest/virtio-scsi-test.c
+++ b/tests/qtest/virtio-scsi-test.c
@@ -156,7 +156,7 @@ static QVirtioSCSIQueues *qvirtio_scsi_init(QVirtioDevice *dev)
return vs;
}
-static void hotplug(void *obj, void *data, QGuestAllocator *alloc)
+static void hotplug(void *obj, void *data, QGuestAllocator *t_alloc)
{
QTestState *qts = global_qtest;
--
2.41.0
next prev parent reply other threads:[~2023-10-27 9:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 9:36 [PULL 00/11] testing patches (+ 1 deprecation patch) Thomas Huth
2023-10-27 9:37 ` [PULL 01/11] system/qtest: Clean up global variable shadowing in qtest_server_init() Thomas Huth
2023-10-27 9:37 ` [PULL 02/11] tests/throttle: Clean up global variable shadowing Thomas Huth
2023-10-27 9:37 ` Thomas Huth [this message]
2023-10-27 9:37 ` [PULL 04/11] tests/cdrom-test: Clean up global variable shadowing in prepare_image() Thomas Huth
2023-10-27 9:37 ` [PULL 05/11] tests/rtl8139: Clean up global variable shadowing Thomas Huth
2023-10-27 9:37 ` [PULL 06/11] tests/npcm7xx_adc: " Thomas Huth
2023-10-27 9:37 ` [PULL 07/11] tests/aio: " Thomas Huth
2023-10-27 9:37 ` [PULL 08/11] tests/coroutine: " Thomas Huth
2023-10-27 9:37 ` [PULL 09/11] docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated Thomas Huth
2023-10-27 9:37 ` [PULL 10/11] tests/vm/freebsd: Add additional library paths for libfdt Thomas Huth
2023-10-27 9:37 ` [PULL 11/11] ipmi-bt-test: force ipv4 Thomas Huth
2023-10-30 4:39 ` [PULL 00/11] testing patches (+ 1 deprecation patch) Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231027093710.273558-4-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.