From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 467F41F5E7 for ; Fri, 27 Oct 2023 15:36:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="pLc5ImBo" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C03AEAF; Fri, 27 Oct 2023 08:36:45 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F01B7669; Fri, 27 Oct 2023 17:36:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1698420990; bh=b3A03icKhof/bCKcdoueaGodz3vHUmATSsrQoo3PrOM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pLc5ImBozwGf/fB1YV8wN9FdlMgkafES9rB0OXk85tjhGv76RY1rrihNwQLIO8iqM v68xIxHsQg0SvVXHumBc+ODCNBqhv7LyvpBHuPjocMoO4+yoZTnrWaYrmW5jo0CjM/ PVWK8BnKQr3GaFtbwMtpI7Z829Pzlq3MLm908dr8= Date: Fri, 27 Oct 2023 18:36:49 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, Paul Elder , Hans Verkuil , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Julien Stephan , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v4 1/3] dt-bindings: media: Add bindings for THine THP7312 ISP Message-ID: <20231027153649.GE12144@pendragon.ideasonboard.com> References: <20231017132103.9914-1-laurent.pinchart@ideasonboard.com> <20231017132103.9914-2-laurent.pinchart@ideasonboard.com> <20231027121929.GC12144@pendragon.ideasonboard.com> <20231027124634.GB19539@pendragon.ideasonboard.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Fri, Oct 27, 2023 at 02:52:38PM +0000, Sakari Ailus wrote: > Hi Laurent, > > On Fri, Oct 27, 2023 at 03:46:34PM +0300, Laurent Pinchart wrote: > > > > > > + port: > > > > > > + $ref: /schemas/graph.yaml#/$defs/port-base > > > > > > + additionalProperties: false > > > > > > + > > > > > > + properties: > > > > > > + endpoint: > > > > > > + $ref: /schemas/media/video-interfaces.yaml# > > > > > > + unevaluatedProperties: false > > > > > > + > > > > > > + properties: > > > > > > + data-lanes: > > > > > > + description: > > > > > > + This property is for lane reordering between the THP7312 and the > > > > > > + SoC. The sensor supports either two-lane, or four-lane operation. > > > > > > + If this property is omitted four-lane operation is assumed. For > > > > > > + two-lane operation the property must be set to <1 2>. > > > > > > > > > > How are link frequencies determined by the device? > > > > > > > > The link frequency is not under direct control of the host. There are > > > > registers to select between mode presets, each of them producing a > > > > particular link frequency. > > > > > > If they are known, one could only allow setting the modes with known-good > > > link requencies. This could be added later on, too, affecting systems with > > > link-frequencies set. I guess you could also add it now, as optional. > > > > I vote for later :-) > > > > > Where's the link frequency information available? In documentation or in > > > on the firmware API? > > > > In the documentation (which is not public I'm afraid). > > Could you add this information in the driver? > > Co-incidentally, the driver is lacking the LINK_FREQ control. It should be > added. Oops. Seems I got caught red-handed. I'll fix that (and add the PIXEL_RATE control too). -- Regards, Laurent Pinchart