From: Greg KH <greg@kroah.com>
To: LihaSika <lihasika@gmail.com>
Cc: Linux USB <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility
Date: Fri, 27 Oct 2023 15:53:07 +0200 [thread overview]
Message-ID: <2023102720-emotion-overlying-9bb4@gregkh> (raw)
In-Reply-To: <21c2b8ee-7753-413e-98f9-d1401edf5c73@gmail.com>
On Fri, Oct 27, 2023 at 04:41:23PM +0300, LihaSika wrote:
> Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match
> 1.50. I have such an older device with bcdDevice=1.50 and it will not work
> otherwise.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Liha Sikanen <lihasika@gmail.com>
> ---
>
> diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h
> index 0547daf..7b3d5f0 100644
> --- a/drivers/usb/storage/unusual_cypress.h
> +++ b/drivers/usb/storage/unusual_cypress.h
> @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999,
> "Cypress ISD-300LP",
> USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0),
>
> -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160,
> +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160,
> "Super Top",
> "USB 2.0 SATA BRIDGE",
> USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0),
>
Much better, thanks, the subject and changelog text are great!
But the patch is still corrupted, with tabs turned into spaces, and we
can't apply it at all :(
Can you fix that up and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-27 13:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 15:32 Linux kernel 6.1 - drivers/usb/storage/unusual_cypress.h "Super Top" minimum bcdDevice too high LihaSika
2023-10-26 19:14 ` Greg KH
2023-10-26 19:39 ` LihaSika
2023-10-27 1:27 ` Bagas Sanjaya
2023-10-27 12:15 ` [PATCH] set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h LihaSika
2023-10-27 12:22 ` Greg KH
2023-10-27 12:37 ` LihaSika
2023-10-27 12:46 ` Greg KH
2023-10-27 13:06 ` [PATCH] usb: storage: set 1.50 as the lower bcdDevice compatibility for older "Super Top"-device to work LihaSika
2023-10-27 13:41 ` [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility LihaSika
2023-10-27 13:53 ` Greg KH [this message]
2023-10-27 17:26 ` LihaSika
2023-10-27 17:28 ` LihaSika
2023-10-28 7:02 ` Bagas Sanjaya
2023-10-28 10:23 ` Greg Kroah-Hartman
2023-10-28 11:05 ` Bagas Sanjaya
2023-10-28 11:20 ` LihaSika
2023-10-27 12:56 ` [PATCH] set 1.50 as the lower bcdDevice value for "Super Top"-device in drivers/usb/storage/unusual_cypress.h Bagas Sanjaya
2023-10-27 13:05 ` Greg KH
2023-10-27 13:09 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023102720-emotion-overlying-9bb4@gregkh \
--to=greg@kroah.com \
--cc=lihasika@gmail.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.