From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 401A9C25B67 for ; Fri, 27 Oct 2023 07:17:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235080AbjJ0HRJ (ORCPT ); Fri, 27 Oct 2023 03:17:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345425AbjJ0HQ5 (ORCPT ); Fri, 27 Oct 2023 03:16:57 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A3AA1985; Fri, 27 Oct 2023 00:16:45 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5A3EC433C8; Fri, 27 Oct 2023 07:16:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698391004; bh=CBkxV/uFvpzCOvXq/7DVXjOGLxxi3GTw/t/A+HTWNJE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0nGMnJTiNrrl2+rN9XPzMH2IcacHjDqVSv6UlJ/cULBbI+YiCV5QLG5YHCkoLKuZK eeItrfl/qeCk8SU0jS7rudj7Bw5yKwjE7UVm1sMMjxhAuaTUyeUJGdRosPS0Nhtjfx hoafJV4TNcsIqxE1mhrXswdKwYOML9x0OuA/Xw6c= Date: Fri, 27 Oct 2023 09:16:41 +0200 From: Greg KH To: Su Hui Cc: joel@jms.id.au, andrew@codeconstruct.com.au, robh@kernel.org, arnd@arndb.de, roblip@gmail.com, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] soc: aspeed: lpc: Fix impossible judgment condition Message-ID: <2023102730-outmatch-rising-14f0@gregkh> References: <20231027020703.1231875-1-suhui@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231027020703.1231875-1-suhui@nfschina.com> Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Fri, Oct 27, 2023 at 10:07:04AM +0800, Su Hui wrote: > smatch error： > drivers/soc/aspeed/aspeed-lpc-snoop.c:169 > aspeed_lpc_snoop_config_irq() warn: platform_get_irq() does not return zero > > platform_get_irq() return non-zero IRQ number or negative error code, > change '!lpc_snoop->irq' to 'lpc_snoop->irq < 0' to fix this. > > Fixes: 9f4f9ae81d0a ("drivers/misc: add Aspeed LPC snoop driver") > Signed-off-by: Su Hui > --- > drivers/soc/aspeed/aspeed-lpc-snoop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Fri, 27 Oct 2023 09:16:41 +0200 Subject: [PATCH] soc: aspeed: lpc: Fix impossible judgment condition In-Reply-To: <20231027020703.1231875-1-suhui@nfschina.com> References: <20231027020703.1231875-1-suhui@nfschina.com> Message-ID: <2023102730-outmatch-rising-14f0@gregkh> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Oct 27, 2023 at 10:07:04AM +0800, Su Hui wrote: > smatch error? > drivers/soc/aspeed/aspeed-lpc-snoop.c:169 > aspeed_lpc_snoop_config_irq() warn: platform_get_irq() does not return zero > > platform_get_irq() return non-zero IRQ number or negative error code, > change '!lpc_snoop->irq' to 'lpc_snoop->irq < 0' to fix this. > > Fixes: 9f4f9ae81d0a ("drivers/misc: add Aspeed LPC snoop driver") > Signed-off-by: Su Hui > --- > drivers/soc/aspeed/aspeed-lpc-snoop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F3D9C25B67 for ; Fri, 27 Oct 2023 07:17:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H/EVPlkUkvVZh1GcD3FIuq+8oATsgpBDFNdJvdn5CMQ=; b=G5GfaxDxSnFCkY Qne6WM/sxOfnus3hz3IMkhE+KgKz3rZVZQe8TPvrH425EczuNXIkp9qu4mMy02CxKanjzN+FdhGDt 1+Nb8JiHFWui/IPzDHfbY2hpY57hJ7mFRtdfqvhvz6TvsfMSxuPDEmNfGTFHRrA8mZEvx7lCyRxMK 4kGLzKcdCihlcmcm5BXVXv8fMKCxOR8QTF7s34GjOKPutlNZLdYNbnUeOwbIeqDch1BKh/EUNjA5w BojHdOIiHE6xQOHofRlpQ37eJ3pC4qD+XB2V96KjUVjo2KRxGcuqJ2fNOHJiu1w1Fcjes82BeKxfg DWi82x9pgaQhtOD/P+QA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qwH5R-00FlhB-0U; Fri, 27 Oct 2023 07:16:53 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qwH5O-00Flfs-26 for linux-arm-kernel@lists.infradead.org; Fri, 27 Oct 2023 07:16:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 3E88BCE444F; Fri, 27 Oct 2023 07:16:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5A3EC433C8; Fri, 27 Oct 2023 07:16:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698391004; bh=CBkxV/uFvpzCOvXq/7DVXjOGLxxi3GTw/t/A+HTWNJE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0nGMnJTiNrrl2+rN9XPzMH2IcacHjDqVSv6UlJ/cULBbI+YiCV5QLG5YHCkoLKuZK eeItrfl/qeCk8SU0jS7rudj7Bw5yKwjE7UVm1sMMjxhAuaTUyeUJGdRosPS0Nhtjfx hoafJV4TNcsIqxE1mhrXswdKwYOML9x0OuA/Xw6c= Date: Fri, 27 Oct 2023 09:16:41 +0200 From: Greg KH To: Su Hui Cc: joel@jms.id.au, andrew@codeconstruct.com.au, robh@kernel.org, arnd@arndb.de, roblip@gmail.com, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] soc: aspeed: lpc: Fix impossible judgment condition Message-ID: <2023102730-outmatch-rising-14f0@gregkh> References: <20231027020703.1231875-1-suhui@nfschina.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231027020703.1231875-1-suhui@nfschina.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231027_001650_878767_FE592B52 X-CRM114-Status: GOOD ( 17.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBPY3QgMjcsIDIwMjMgYXQgMTA6MDc6MDRBTSArMDgwMCwgU3UgSHVpIHdyb3RlOgo+ IHNtYXRjaCBlcnJvcu+8mgo+IGRyaXZlcnMvc29jL2FzcGVlZC9hc3BlZWQtbHBjLXNub29wLmM6 MTY5Cj4gYXNwZWVkX2xwY19zbm9vcF9jb25maWdfaXJxKCkgd2FybjogcGxhdGZvcm1fZ2V0X2ly cSgpIGRvZXMgbm90IHJldHVybiB6ZXJvCj4gCj4gcGxhdGZvcm1fZ2V0X2lycSgpIHJldHVybiBu b24temVybyBJUlEgbnVtYmVyIG9yIG5lZ2F0aXZlIGVycm9yIGNvZGUsCj4gY2hhbmdlICchbHBj X3Nub29wLT5pcnEnIHRvICdscGNfc25vb3AtPmlycSA8IDAnIHRvIGZpeCB0aGlzLgo+IAo+IEZp eGVzOiA5ZjRmOWFlODFkMGEgKCJkcml2ZXJzL21pc2M6IGFkZCBBc3BlZWQgTFBDIHNub29wIGRy aXZlciIpCj4gU2lnbmVkLW9mZi1ieTogU3UgSHVpIDxzdWh1aUBuZnNjaGluYS5jb20+Cj4gLS0t Cj4gIGRyaXZlcnMvc29jL2FzcGVlZC9hc3BlZWQtbHBjLXNub29wLmMgfCAyICstCj4gIDEgZmls ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKSGksCgpUaGlzIGlzIHRo ZSBmcmllbmRseSBwYXRjaC1ib3Qgb2YgR3JlZyBLcm9haC1IYXJ0bWFuLiAgWW91IGhhdmUgc2Vu dCBoaW0KYSBwYXRjaCB0aGF0IGhhcyB0cmlnZ2VyZWQgdGhpcyByZXNwb25zZS4gIEhlIHVzZWQg dG8gbWFudWFsbHkgcmVzcG9uZAp0byB0aGVzZSBjb21tb24gcHJvYmxlbXMsIGJ1dCBpbiBvcmRl ciB0byBzYXZlIGhpcyBzYW5pdHkgKGhlIGtlcHQKd3JpdGluZyB0aGUgc2FtZSB0aGluZyBvdmVy IGFuZCBvdmVyLCB5ZXQgdG8gZGlmZmVyZW50IHBlb3BsZSksIEkgd2FzCmNyZWF0ZWQuICBIb3Bl ZnVsbHkgeW91IHdpbGwgbm90IHRha2Ugb2ZmZW5jZSBhbmQgd2lsbCBmaXggdGhlIHByb2JsZW0K aW4geW91ciBwYXRjaCBhbmQgcmVzdWJtaXQgaXQgc28gdGhhdCBpdCBjYW4gYmUgYWNjZXB0ZWQg aW50byB0aGUgTGludXgKa2VybmVsIHRyZWUuCgpZb3UgYXJlIHJlY2VpdmluZyB0aGlzIG1lc3Nh Z2UgYmVjYXVzZSBvZiB0aGUgZm9sbG93aW5nIGNvbW1vbiBlcnJvcihzKQphcyBpbmRpY2F0ZWQg YmVsb3c6CgotIFlvdSBoYXZlIG1hcmtlZCBhIHBhdGNoIHdpdGggYSAiRml4ZXM6IiB0YWcgZm9y IGEgY29tbWl0IHRoYXQgaXMgaW4gYW4KICBvbGRlciByZWxlYXNlZCBrZXJuZWwsIHlldCB5b3Ug ZG8gbm90IGhhdmUgYSBjYzogc3RhYmxlIGxpbmUgaW4gdGhlCiAgc2lnbmVkLW9mZi1ieSBhcmVh IGF0IGFsbCwgd2hpY2ggbWVhbnMgdGhhdCB0aGUgcGF0Y2ggd2lsbCBub3QgYmUKICBhcHBsaWVk IHRvIGFueSBvbGRlciBrZXJuZWwgcmVsZWFzZXMuICBUbyBwcm9wZXJseSBmaXggdGhpcywgcGxl YXNlCiAgZm9sbG93IHRoZSBkb2N1bWVudGVkIHJ1bGVzIGluIHRoZQogIERvY3VtZW50YXRpb24v cHJvY2Vzcy9zdGFibGUta2VybmVsLXJ1bGVzLnJzdCBmaWxlIGZvciBob3cgdG8gcmVzb2x2ZQog IHRoaXMuCgpJZiB5b3Ugd2lzaCB0byBkaXNjdXNzIHRoaXMgcHJvYmxlbSBmdXJ0aGVyLCBvciB5 b3UgaGF2ZSBxdWVzdGlvbnMgYWJvdXQKaG93IHRvIHJlc29sdmUgdGhpcyBpc3N1ZSwgcGxlYXNl IGZlZWwgZnJlZSB0byByZXNwb25kIHRvIHRoaXMgZW1haWwgYW5kCkdyZWcgd2lsbCByZXBseSBv bmNlIGhlIGhhcyBkdWcgb3V0IGZyb20gdGhlIHBlbmRpbmcgcGF0Y2hlcyByZWNlaXZlZApmcm9t IG90aGVyIGRldmVsb3BlcnMuCgp0aGFua3MsCgpncmVnIGstaCdzIHBhdGNoIGVtYWlsIGJvdAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo=