From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED0C9C25B47 for ; Fri, 27 Oct 2023 11:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L979kz7GZu7rmM0iFQ4Qk1DD8WZKEFbcBETLP7GDOnA=; b=1CB6IJ442NaL5j o+IWsbEavZdZt99Tpcovc6N88YGTLeQLkE3jR11sajEpoT47dAhZ91xblhDCTzdWOEFyzTsEg+T3D lnYzxYUGysuPLtr0LRa4PeAVwr52JAMPmmBgkd7NTxn+RrefZOPA4xD+wHmWz1m1lVwCRcQIwAXYF jl6mlc3Iy1vfa905Ix6SBxa6X+C/AqImJ7O3pM3xtRuL4XvmkFouUbVUv+3HwWy3acKb2JKUNMyp2 9epS6XsBobB37rYDTzaFkntWBeD+2Wn07g5qcCZjTGFsO5+o5KuCvqYxiwdIHm8tgwG4JHpCJntKe L4dhsVvXo4RB8PK980TA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qwKrb-00GIqS-2b; Fri, 27 Oct 2023 11:18:51 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qwKrY-00GIpd-10 for linux-mtd@lists.infradead.org; Fri, 27 Oct 2023 11:18:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id B001DB81975; Fri, 27 Oct 2023 11:18:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AACCFC433C8; Fri, 27 Oct 2023 11:18:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698405526; bh=ChKI5CnRqli2HtpDxqYBsjQ7jd8800uzKWtd8Vt64oU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HLXTITAHInEv6CDg60jpeXI1TJctnEsGS/2JqotMkdQtv7TEvs3wO0dkdd/AeGMZf JhZ4UmNcDRGStzoSc0uixwv36lkBkwjROEueWNEqQWLzpQgek1uCfhtKOb7VFQXe2c CKdLHqfz1IN71X7/WrbsxqyCbnvV3bt3Cxh9RfKg= Date: Fri, 27 Oct 2023 13:18:43 +0200 From: Greg Kroah-Hartman To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Srinivas Kandagatla , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH reworded] Revert "nvmem: add new config option" Message-ID: <2023102731-scorebook-equator-3f11@gregkh> References: <20231023102759.31529-1-zajec5@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231023102759.31529-1-zajec5@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231027_041848_495981_DDBBE594 X-CRM114-Status: GOOD ( 12.09 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gTW9uLCBPY3QgMjMsIDIwMjMgYXQgMTI6Mjc6NTlQTSArMDIwMCwgUmFmYcWCIE1pxYJlY2tp IHdyb3RlOgo+IEZyb206IFJhZmHFgiBNacWCZWNraSA8cmFmYWxAbWlsZWNraS5wbD4KPiAKPiBU aGlzIHJldmVydHMgY29tbWl0IDUxN2YxNGQ5Y2YzNTMzZDVhYjRmZGVkMTk1YWI2ZjgwYTkyZTM3 OGYuCj4gCj4gQ29uZmlnIG9wdGlvbiAibm9fb2Zfbm9kZSIgaXMgbm8gbG9uZ2VyIG5lZWRlZCBz aW5jZSBhZGRpbmcgYSBtb3JlCj4gZXhwbGljaXQgYW5kIHRhcmdldGVkIG9wdGlvbiAiYWRkX2xl Z2FjeV9maXhlZF9vZl9jZWxscyIuCj4gCj4gVGhhdCAibm9fb2Zfbm9kZSIgY29uZmlnIG9wdGlv biB3YXMgbmVlZGVkICplYXJsaWVyKiB0byBoZWxwIG10ZCdzIGNhc2UuCj4gCj4gRFQgbm9kZXMg b2YgTVREIHBhcnRpdGlvbnMgKHRoYXQgYXJlIGFsc28gTlZNRU0gZGV2aWNlcykgbWF5IGNvbnRh aW4KPiBzdWJub2Rlcy4gVGhvc2UgU0hPVUxEIE5PVCBiZSB0cmVhdGVkIGFzIE5WTUVNIGZpeGVk IGNlbGxzLgo+IAo+IFRvIHByZXZlbnQgTlZNRU0gY29yZSBjb2RlIGZyb20gcGFyc2luZyBzdWJu b2RlcyBhICJub19vZl9ub2RlIiBvcHRpb24KPiB3YXMgYWRkZWQgKGFuZCBzZXQgdG8gdHJ1ZSBp biBtdGQpIHRvIG1ha2UgZm9yX2VhY2hfY2hpbGRfb2Zfbm9kZSgpIGluCj4gTlZNRU0gYSBuby1v cC4gVGhhdCB3YXMgYSBiaXQgaGFja3kgYmVjYXVzZSBpdCB3YXMgbWVzc2luZyB3aXRoCj4gIm9m X25vZGUiIHBvaW50ZXIgdG8gYWNoaWV2ZSBzb21lIHNpZGUtZWZmZWN0Lgo+IAo+IFdpdGggdGhl IGludHJvZHVjdGlvbiBvZiAiYWRkX2xlZ2FjeV9maXhlZF9vZl9jZWxscyIgY29uZmlnIG9wdGlv bgo+IHRoaW5ncyBnb3QgbW9yZSBleHBsaWNpdC4gTVREIHN1YnN5c3RlbSBzaW1wbHkgdGVsbHMg TlZNRU0gd2hlbiB0byBsb29rCj4gZm9yIGZpeGVkIGNlbGxzIGFuZCB0aGVyZSBpcyBubyBuZWVk IHRvIGhhY2sgIm9mX25vZGUiIHBvaW50ZXIgYW55bW9yZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBS YWZhxYIgTWnFgmVja2kgPHJhZmFsQG1pbGVja2kucGw+Cj4gUmV2aWV3ZWQtYnk6IE1pcXVlbCBS YXluYWwgPG1pcXVlbC5yYXluYWxAYm9vdGxpbi5jb20+Cj4gU2lnbmVkLW9mZi1ieTogU3Jpbml2 YXMgS2FuZGFnYXRsYSA8c3Jpbml2YXMua2FuZGFnYXRsYUBsaW5hcm8ub3JnPgo+IC0tLQo+IEdy ZWc6IEkgcmV3b3JkZWQgdGhpcyBQQVRDSCdzIGNvbW1pdCBtZXNzYWdlLiBJdCdzIGhvcGVmdWxs eSBjbGVhciBub3cKPiAgICAgICB0aGF0IHRoaXMgcmV2ZXJ0IGlzIE9LIG9ubHkgd2l0aCB0aGUg ImFkZF9sZWdhY3lfZml4ZWRfb2ZfY2VsbHMiLgoKTXVjaCBuaWNlciwgbm93IGFwcGxpZWQsIHRo YW5rcyEKCmdyZWcgay1oCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8D25C25B6E for ; Fri, 27 Oct 2023 11:18:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345705AbjJ0LSv (ORCPT ); Fri, 27 Oct 2023 07:18:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231461AbjJ0LSt (ORCPT ); Fri, 27 Oct 2023 07:18:49 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6876D187 for ; Fri, 27 Oct 2023 04:18:46 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AACCFC433C8; Fri, 27 Oct 2023 11:18:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698405526; bh=ChKI5CnRqli2HtpDxqYBsjQ7jd8800uzKWtd8Vt64oU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HLXTITAHInEv6CDg60jpeXI1TJctnEsGS/2JqotMkdQtv7TEvs3wO0dkdd/AeGMZf JhZ4UmNcDRGStzoSc0uixwv36lkBkwjROEueWNEqQWLzpQgek1uCfhtKOb7VFQXe2c CKdLHqfz1IN71X7/WrbsxqyCbnvV3bt3Cxh9RfKg= Date: Fri, 27 Oct 2023 13:18:43 +0200 From: Greg Kroah-Hartman To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Srinivas Kandagatla , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH reworded] Revert "nvmem: add new config option" Message-ID: <2023102731-scorebook-equator-3f11@gregkh> References: <20231023102759.31529-1-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231023102759.31529-1-zajec5@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 23, 2023 at 12:27:59PM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > This reverts commit 517f14d9cf3533d5ab4fded195ab6f80a92e378f. > > Config option "no_of_node" is no longer needed since adding a more > explicit and targeted option "add_legacy_fixed_of_cells". > > That "no_of_node" config option was needed *earlier* to help mtd's case. > > DT nodes of MTD partitions (that are also NVMEM devices) may contain > subnodes. Those SHOULD NOT be treated as NVMEM fixed cells. > > To prevent NVMEM core code from parsing subnodes a "no_of_node" option > was added (and set to true in mtd) to make for_each_child_of_node() in > NVMEM a no-op. That was a bit hacky because it was messing with > "of_node" pointer to achieve some side-effect. > > With the introduction of "add_legacy_fixed_of_cells" config option > things got more explicit. MTD subsystem simply tells NVMEM when to look > for fixed cells and there is no need to hack "of_node" pointer anymore. > > Signed-off-by: Rafał Miłecki > Reviewed-by: Miquel Raynal > Signed-off-by: Srinivas Kandagatla > --- > Greg: I reworded this PATCH's commit message. It's hopefully clear now > that this revert is OK only with the "add_legacy_fixed_of_cells". Much nicer, now applied, thanks! greg k-h