From: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
To: Alex Elder <elder@ieee.org>
Cc: Viresh Kumar <vireshk@kernel.org>,
Johan Hovold <johan@kernel.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, kumaran.4353@gmail.com
Subject: Re: [PATCH v2 3/3] staging: greybus: bootrom: fixed prefer using ftrace warning
Date: Sat, 28 Oct 2023 13:25:31 -0700 [thread overview]
Message-ID: <20231028202531.GB2432@ubuntu> (raw)
In-Reply-To: <5d457162-d20a-43a5-989e-ef263fbd91b2@ieee.org>
On Thu, Oct 26, 2023 at 01:20:47PM -0500, Alex Elder wrote:
> On 10/22/23 7:22 AM, Nandha Kumar Singaram wrote:
> > Adhere to linux coding style. Reported by checkpatch.pl:
> > WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> >
> > Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
>
> This change looks reasonable to me, though I don't think
> ftrace provides device information.
>
> Acked-by: Alex Elder <elder@linaro.org>
>
> > ---
> > drivers/staging/greybus/bootrom.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c
> > index a8efb86de140..79581457c4af 100644
> > --- a/drivers/staging/greybus/bootrom.c
> > +++ b/drivers/staging/greybus/bootrom.c
> > @@ -491,8 +491,6 @@ static void gb_bootrom_disconnect(struct gb_bundle *bundle)
> > {
> > struct gb_bootrom *bootrom = greybus_get_drvdata(bundle);
> > - dev_dbg(&bundle->dev, "%s\n", __func__);
> > -
> > gb_connection_disable(bootrom->connection);
> > /* Disable timeouts */
>
Thanks Alex for the review and feedback.
Regards,
Nandha Kumar
prev parent reply other threads:[~2023-10-28 20:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 12:13 [PATCH v2 0/3] staging: greybus: Coding style cleanup patches Nandha Kumar Singaram
2023-10-22 12:15 ` [PATCH v2 1/3] staging: greybus: camera: Alignment should match open parenthesis Nandha Kumar Singaram
2023-10-26 18:18 ` Alex Elder
2023-10-28 20:22 ` Nandha Kumar Singaram
2023-10-22 12:18 ` [PATCH v2 2/3] staging: greybus: camera: Modify lines end with a '(' Nandha Kumar Singaram
2023-10-22 12:22 ` [PATCH v2 3/3] staging: greybus: bootrom: fixed prefer using ftrace warning Nandha Kumar Singaram
2023-10-26 18:20 ` Alex Elder
2023-10-28 20:25 ` Nandha Kumar Singaram [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231028202531.GB2432@ubuntu \
--to=nandhakumar.singaram@gmail.com \
--cc=elder@ieee.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=kumaran.4353@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.