From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: Stanislav Kholmanskikh <stanislav.kholmanskikh@bell-sw.com>,
ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] compat_16.mk: Cleanup INTERMEDIATE object syntax
Date: Mon, 30 Oct 2023 08:28:19 +0100 [thread overview]
Message-ID: <20231030072819.GA9167@pevik> (raw)
In-Reply-To: <CAEemH2fuA+YfFGNzSResMprEeT8+zhO1S_2Kscc14d2T828YYw@mail.gmail.com>
Hi Li,
> Hi Petr,
> Petr Vorel <pvorel@suse.cz> wrote:
> > DEF_16 := TST_USE_COMPAT16_SYSCALL
> > ...
> > -%_16: CPPFLAGS += -D$(DEF_16)=1
Not related to this effort: shouldn't we convert all CPPFLAGS to CFLAGS? Or the
LTP build system it just prepared to the crazy ideas about using C++? :)
> Seems we need to keep this one line, otherwise it can't transfer the
> 'TST_USE_COMPAT16_SYSCALL=1' macro in the compilation.
Ah, thanks!
> The rest looks good to me.
> Reviewed-by: Li Wang <liwang@redhat.com>
BTW I'm going to push it with you as an author + with your Signed-off-by: tag
(you're effectively the autor of the code) and with my RBT.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-10-30 7:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 17:43 [LTP] [PATCH 1/1] compat_16.mk: Cleanup INTERMEDIATE object syntax Petr Vorel
2023-10-30 3:29 ` Li Wang
2023-10-30 7:28 ` Petr Vorel [this message]
2023-10-30 8:22 ` Li Wang
2023-10-30 14:20 ` Petr Vorel
2025-03-07 23:45 ` Petr Vorel
2025-03-10 2:40 ` Li Wang
2025-03-11 21:41 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231030072819.GA9167@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=stanislav.kholmanskikh@bell-sw.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.