From: Stephen Hemminger <stephen@networkplumber.org>
To: Weiguo Li <liwg06@foxmail.com>
Cc: dev@dpdk.org, stable@dpdk.org, Weiguo Li <liweiguo@xencore.cn>
Subject: Re: [PATCH] devargs: fix derefrence before null test
Date: Mon, 30 Oct 2023 09:24:06 -0700 [thread overview]
Message-ID: <20231030092406.29ebcafa@fedora> (raw)
In-Reply-To: <tencent_CF44B0629A79704E5F22C0749CBFED469809@qq.com>
On Mon, 30 Oct 2023 19:45:29 +0800
Weiguo Li <liwg06@foxmail.com> wrote:
> diff --git a/lib/eal/common/eal_common_devargs.c
> b/lib/eal/common/eal_common_devargs.c index fb5d0a293b..8d6c3938eb
> 100644 --- a/lib/eal/common/eal_common_devargs.c
> +++ b/lib/eal/common/eal_common_devargs.c
> @@ -185,11 +185,13 @@ rte_devargs_parse(struct rte_devargs *da, const
> char *dev) {
> struct rte_bus *bus = NULL;
> const char *devname;
> - const size_t maxlen = sizeof(da->name);
> size_t i;
>
> if (da == NULL)
> return -EINVAL;
> +
> + const size_t maxlen = sizeof(da->name);
> +
> memset(da, 0, sizeof(*da));
>
> /* First parse according global device syntax. */
NAK
This patch is not necessary. Doing sizeof() on a NULL structure pointer
is allowed. It is valid C.
prev parent reply other threads:[~2023-10-30 16:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 11:45 [PATCH] devargs: fix derefrence before null test Weiguo Li
2023-10-30 16:24 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231030092406.29ebcafa@fedora \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=liweiguo@xencore.cn \
--cc=liwg06@foxmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.