From: Jakub Kicinski <kuba@kernel.org>
To: Frederik Deweerdt <deweerdt.lkml@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] Add missing NULL check in `tls_strp_check_queue_ok`
Date: Mon, 30 Oct 2023 15:05:12 -0700 [thread overview]
Message-ID: <20231030150512.254220a5@kernel.org> (raw)
In-Reply-To: <ZUAmyb44sy309V6H@urola>
On Mon, 30 Oct 2023 14:57:29 -0700 Frederik Deweerdt wrote:
> We see `tls_strp_check_queue_ok` running into a NULL deref when
> evaluating `TCP_SKB_CB(skb)->seq`.
>
> This commit attempts to address the issue by exiting the loop if
> skb->next is NULL, and has proven stable under load.
>
> That said i don't understand the code enough to convince myself that
> the NULL check is indeed required, and i would be happy gather data if
> that's useful.
Hm. Can you share the decoded stack trace?
next prev parent reply other threads:[~2023-10-30 22:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 21:57 [PATCH] [RFC] Add missing NULL check in `tls_strp_check_queue_ok` Frederik Deweerdt
2023-10-30 22:05 ` Jakub Kicinski [this message]
2023-10-30 22:20 ` Frederik Deweerdt
2023-10-30 23:24 ` Jakub Kicinski
2023-10-30 23:48 ` Frederik Deweerdt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231030150512.254220a5@kernel.org \
--to=kuba@kernel.org \
--cc=deweerdt.lkml@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.