From: Greg KH <gregkh@linuxfoundation.org>
To: ChenXiaoSong <chenxiaosongemail@foxmail.com>
Cc: trond.myklebust@hammerspace.com, chenxiaosong@kylinos.cn,
Anna.Schumaker@netapp.com, sashal@kernel.org,
liuzhengyuan@kylinos.cn, huangjinhui@kylinos.cn,
liuyun01@kylinos.cn, huhai@kylinos.cn, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: Question about LTS 4.19 patch "89047634f5ce NFS: Don't interrupt file writeout due to fatal errors"
Date: Mon, 30 Oct 2023 10:19:03 +0100 [thread overview]
Message-ID: <2023103023-playmaker-jingle-9d15@gregkh> (raw)
In-Reply-To: <tencent_21E20176E2E5AB7C33CB5E67F10D02763508@qq.com>
On Mon, Oct 30, 2023 at 05:04:35PM +0800, ChenXiaoSong wrote:
>
> On 2023/10/30 16:58, Greg KH wrote:
> > If you just revert that one patch, is the issue resolved? And what
> > about other stable releases that have that change in it?
> >
> > If this does need to be reverted, please submit a patch that does so and
> > we can review it that way.
> >
> > thanks,
> >
> > greg k-h
>
>
> In my opinion, this patch is not for fixing a bug, but is part of a
> refactoring patchset. The 'Fixes:' tag should not be added.
Nothing we can do about that now, right? And to try to ask developers
about a change they made in 2019 is a bit rough, don't you think? If
you think the change is incorrect, please submit a patch to resolve it
after you have tested that it works properly.
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-30 9:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 8:39 Question about LTS 4.19 patch "89047634f5ce NFS: Don't interrupt file writeout due to fatal errors" ChenXiaoSong
2023-10-30 8:43 ` Greg KH
2023-10-30 8:54 ` ChenXiaoSong
2023-10-30 8:58 ` Greg KH
2023-10-30 9:04 ` ChenXiaoSong
2023-10-30 9:19 ` Greg KH [this message]
2023-10-30 14:56 ` Trond Myklebust
2023-11-17 3:28 ` ChenXiaoSong
2023-11-17 4:09 ` ChenXiaoSong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023103023-playmaker-jingle-9d15@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Anna.Schumaker@netapp.com \
--cc=chenxiaosong@kylinos.cn \
--cc=chenxiaosongemail@foxmail.com \
--cc=huangjinhui@kylinos.cn \
--cc=huhai@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
--cc=liuzhengyuan@kylinos.cn \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.