Re: [PATCH] linux/igb_uio: make module parameters visible in sysfs

[Stephen Hemminger <stephen@networkplumber.org>]

On Sun, 21 Aug 2022 16:19:50 -0700
Shinae Woo <shinae@alkira.net> wrote:

> diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c
> index 33e0e02..c927ae6 100644
> --- a/linux/igb_uio/igb_uio.c
> +++ b/linux/igb_uio/igb_uio.c
> @@ -44,7 +44,7 @@ struct rte_uio_pci_dev {
>  };
>  
>  static int wc_activate;
> -static char *intr_mode;
> +static char *intr_mode = RTE_INTR_MODE_MSIX_NAME;

Since intr_mode is now initialized you can remove the code that checks for
it being NULL.


diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c
index aea67da..11141d4 100644
--- a/linux/igb_uio/igb_uio.c
+++ b/linux/igb_uio/igb_uio.c
@@ -44,7 +44,7 @@ struct rte_uio_pci_dev {
 };
 
 static int wc_activate;
-static char *intr_mode;
+static char *intr_mode = RTE_INTR_MODE_MSIX_NAME;
 static enum rte_intr_mode igbuio_intr_mode_preferred = RTE_INTR_MODE_MSIX;
 /* sriov sysfs */
 static ssize_t
@@ -591,11 +591,6 @@ igbuio_pci_remove(struct pci_dev *dev)
 static int
 igbuio_config_intr_mode(char *intr_str)
 {
-	if (!intr_str) {
-		pr_info("Use MSIX interrupt by default\n");
-		return 0;
-	}
-
 	if (!strcmp(intr_str, RTE_INTR_MODE_MSIX_NAME)) {
 		igbuio_intr_mode_preferred = RTE_INTR_MODE_MSIX;
 		pr_info("Use MSIX interrupt\n");