Re: [PATCH] iommufd: Organize the mock domain alloc functions closer to Joerg's tree

[Jason Gunthorpe <jgg@nvidia.com>]

On Tue, Oct 31, 2023 at 12:13:50PM +0800, Yi Liu wrote:

> > @@ -264,16 +260,11 @@ __mock_domain_alloc_nested(struct mock_iommu_domain *mock_parent,
> >   static struct iommu_domain *mock_domain_alloc(unsigned int iommu_domain_type)
> >   {
> > -	struct iommu_domain *domain;
> > -
> >   	if (iommu_domain_type == IOMMU_DOMAIN_BLOCKED)
> >   		return &mock_blocking_domain;
> > -	if (iommu_domain_type != IOMMU_DOMAIN_UNMANAGED)
> > -		return NULL;
> > -	domain = __mock_domain_alloc_paging(iommu_domain_type, false);
> > -	if (IS_ERR(domain))
> > -		domain = NULL;
> > -	return domain;
> > +	if (iommu_domain_type == IOMMU_DOMAIN_UNMANAGED)
> > +		return mock_domain_alloc_paging(NULL);
> > +	return NULL;
> 
> a nit, will success oriented better suit here? if otherwise looks good to me.

The merge deletes this function..

Thanks,
Jason