From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F1D0C4332F for ; Tue, 31 Oct 2023 05:48:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id E133682499; Tue, 31 Oct 2023 05:48:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org E133682499 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=rl2xXr8n X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EqjgAdocNpkX; Tue, 31 Oct 2023 05:48:37 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id AC24282486; Tue, 31 Oct 2023 05:48:36 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org AC24282486 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 94B6EC0071; Tue, 31 Oct 2023 05:48:36 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 59DF8C0032 for ; Tue, 31 Oct 2023 05:48:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 339CD401A4 for ; Tue, 31 Oct 2023 05:48:35 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 339CD401A4 Authentication-Results: smtp2.osuosl.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=rl2xXr8n X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hd8uk0i-aVg8 for ; Tue, 31 Oct 2023 05:48:34 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp2.osuosl.org (Postfix) with ESMTPS id 3DD7F4013D for ; Tue, 31 Oct 2023 05:48:34 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 3DD7F4013D Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EA3C360C2C; Tue, 31 Oct 2023 05:48:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14AB9C433CA; Tue, 31 Oct 2023 05:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698731312; bh=ZL86179SQNnH59nO9ZdsjOEwSLJlQ/T8PyWZqwTE7cg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rl2xXr8n+alSL/G+gmf7W7osy2QKqZ/XO2v0vxwyI1mgZzbPlnmeavVHcWzMVQTZ1 boFAFoTtuz/nV6SJ49p0TSyf5SsSQw7rXf6Zg/6xhbAXqvDQ3vZmkQoBlUkRDkSHkK 2GyYv5I7h6c3ZBh+IWHlOc42jk8oRV4ESdsAIcA8= Date: Tue, 31 Oct 2023 06:48:29 +0100 From: Greg KH To: =?iso-8859-1?Q?Jos=E9?= Pekkarinen Subject: Re: [PATCH] drm/amd/display: remove redundant check Message-ID: <2023103115-obstruct-smudgy-6cc6@gregkh> References: <20231030171748.35482-1-jose.pekkarinen@foxhound.fi> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231030171748.35482-1-jose.pekkarinen@foxhound.fi> Cc: dillon.varone@amd.com, george.shen@amd.com, sunpeng.li@amd.com, linux-kernel-mentees@lists.linuxfoundation.org, Xinhui.Pan@amd.com, Rodrigo.Siqueira@amd.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, alexander.deucher@amd.com, aurabindo.pillai@amd.com, samson.tam@amd.com, daniel@ffwll.ch, SyedSaaem.Rizvi@amd.com, stable@vger.kernel.org, airlied@gmail.com, Jun.Lei@amd.com, harry.wentland@amd.com, christian.koenig@amd.com X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Mon, Oct 30, 2023 at 07:17:48PM +0200, Jos=E9 Pekkarinen wrote: > This patch addresses the following warning spotted by > using coccinelle where the case checked does the same > than the else case. > = > drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:= 8-10: WARNING: possible condition with no effect (if =3D=3D else) > = > Fixes: 974ce181 ("drm/amd/display: Add check for PState change in DCN32") > = > Cc: stable@vger.kernel.org Why is this relevant for stable? _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA059C4332F for ; Tue, 31 Oct 2023 05:48:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233285AbjJaFsg (ORCPT ); Tue, 31 Oct 2023 01:48:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229772AbjJaFsf (ORCPT ); Tue, 31 Oct 2023 01:48:35 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2C87E8; Mon, 30 Oct 2023 22:48:32 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14AB9C433CA; Tue, 31 Oct 2023 05:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698731312; bh=ZL86179SQNnH59nO9ZdsjOEwSLJlQ/T8PyWZqwTE7cg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rl2xXr8n+alSL/G+gmf7W7osy2QKqZ/XO2v0vxwyI1mgZzbPlnmeavVHcWzMVQTZ1 boFAFoTtuz/nV6SJ49p0TSyf5SsSQw7rXf6Zg/6xhbAXqvDQ3vZmkQoBlUkRDkSHkK 2GyYv5I7h6c3ZBh+IWHlOc42jk8oRV4ESdsAIcA8= Date: Tue, 31 Oct 2023 06:48:29 +0100 From: Greg KH To: =?iso-8859-1?Q?Jos=E9?= Pekkarinen Cc: harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, skhan@linuxfoundation.org, dillon.varone@amd.com, linux-kernel-mentees@lists.linuxfoundation.org, dri-devel@lists.freedesktop.org, Xinhui.Pan@amd.com, linux-kernel@vger.kernel.org, samson.tam@amd.com, SyedSaaem.Rizvi@amd.com, aurabindo.pillai@amd.com, stable@vger.kernel.org, daniel@ffwll.ch, george.shen@amd.com, alexander.deucher@amd.com, Jun.Lei@amd.com, airlied@gmail.com, christian.koenig@amd.com Subject: Re: [PATCH] drm/amd/display: remove redundant check Message-ID: <2023103115-obstruct-smudgy-6cc6@gregkh> References: <20231030171748.35482-1-jose.pekkarinen@foxhound.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231030171748.35482-1-jose.pekkarinen@foxhound.fi> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote: > This patch addresses the following warning spotted by > using coccinelle where the case checked does the same > than the else case. > > drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10: WARNING: possible condition with no effect (if == else) > > Fixes: 974ce181 ("drm/amd/display: Add check for PState change in DCN32") > > Cc: stable@vger.kernel.org Why is this relevant for stable? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78B34C4167B for ; Tue, 31 Oct 2023 05:48:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B4BA10E401; Tue, 31 Oct 2023 05:48:35 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id ECF0110E402 for ; Tue, 31 Oct 2023 05:48:33 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EA3C360C2C; Tue, 31 Oct 2023 05:48:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14AB9C433CA; Tue, 31 Oct 2023 05:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698731312; bh=ZL86179SQNnH59nO9ZdsjOEwSLJlQ/T8PyWZqwTE7cg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rl2xXr8n+alSL/G+gmf7W7osy2QKqZ/XO2v0vxwyI1mgZzbPlnmeavVHcWzMVQTZ1 boFAFoTtuz/nV6SJ49p0TSyf5SsSQw7rXf6Zg/6xhbAXqvDQ3vZmkQoBlUkRDkSHkK 2GyYv5I7h6c3ZBh+IWHlOc42jk8oRV4ESdsAIcA8= Date: Tue, 31 Oct 2023 06:48:29 +0100 From: Greg KH To: =?iso-8859-1?Q?Jos=E9?= Pekkarinen Subject: Re: [PATCH] drm/amd/display: remove redundant check Message-ID: <2023103115-obstruct-smudgy-6cc6@gregkh> References: <20231030171748.35482-1-jose.pekkarinen@foxhound.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231030171748.35482-1-jose.pekkarinen@foxhound.fi> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dillon.varone@amd.com, george.shen@amd.com, sunpeng.li@amd.com, linux-kernel-mentees@lists.linuxfoundation.org, Xinhui.Pan@amd.com, Rodrigo.Siqueira@amd.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, alexander.deucher@amd.com, aurabindo.pillai@amd.com, samson.tam@amd.com, skhan@linuxfoundation.org, SyedSaaem.Rizvi@amd.com, stable@vger.kernel.org, Jun.Lei@amd.com, christian.koenig@amd.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote: > This patch addresses the following warning spotted by > using coccinelle where the case checked does the same > than the else case. > > drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10: WARNING: possible condition with no effect (if == else) > > Fixes: 974ce181 ("drm/amd/display: Add check for PState change in DCN32") > > Cc: stable@vger.kernel.org Why is this relevant for stable?