From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH, realtime-rmap branch] xfs: lock the RT bitmap inode in xfs_efi_item_recover
Date: Tue, 31 Oct 2023 18:14:59 +0100 [thread overview]
Message-ID: <20231031171459.GB31580@lst.de> (raw)
In-Reply-To: <20231031165330.GC1041814@frogsfrogsfrogs>
On Tue, Oct 31, 2023 at 09:53:30AM -0700, Darrick J. Wong wrote:
> > if (!requeue_only) {
> > xfs_extent_free_get_group(mp, &fake);
> > + if (xfs_efi_is_realtime(&fake))
> > + xfs_rtbitmap_lock(tp, mp);
>
> Curious, I thought that patch "xfs: support logging EFIs for realtime
> extents" already locked the rt bitmap?
> So that by the time we get to this part of the loop, the rtbitmap will
> be locked already?
Yes. Indeed that problem was caused by my hacked tree. Feel free to
discard this message.
prev parent reply other threads:[~2023-10-31 17:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 9:50 [PATCH, realtime-rmap branch] xfs: lock the RT bitmap inode in xfs_efi_item_recover Christoph Hellwig
2023-10-31 16:47 ` kernel test robot
2023-10-31 16:53 ` Darrick J. Wong
2023-10-31 17:14 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031171459.GB31580@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.