From: Conor Dooley <conor@kernel.org>
To: Vincent Knecht <vincent.knecht@mailoo.org>
Cc: Tianshu Qiu <tian.shu.qiu@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Yassine Oudjana <y.oudjana@protonmail.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] media: dt-bindings: ak7375: Add ak7345 support
Date: Wed, 1 Nov 2023 15:33:30 +0000 [thread overview]
Message-ID: <20231101-floss-mortified-452c96c9af46@spud> (raw)
In-Reply-To: <0f294695fdfed60c385deadc9d030c225816b4f9.camel@mailoo.org>
[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]
On Wed, Nov 01, 2023 at 04:29:20PM +0100, Vincent Knecht wrote:
> Le mercredi 01 novembre 2023 à 15:10 +0000, Conor Dooley a écrit :
> > On Wed, Nov 01, 2023 at 11:22:56AM +0100, Vincent Knecht wrote:
> > > Document AK7345 bindings.
> >
> > The commit message should mention why this device is incompatible with
> > the 7375. Something like
> >
> > "Document the ak7345 voice coil motor actuator. Similar to the ak7375,
> > this model has 4 unilateral phase detractors instead of 8."
> >
> > Otherwise,
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> >
> > Cheers,
> > Conor.
>
> Thank you for the review!
>
> I don't know anything about phase detractors, nor any other details
hah, that was just me putting techobabble in the example text rather
than using foo. See also:
https://www.youtube.com/watch?v=RXJKdh1KZ0w
> (having found no datasheets for either of these ICs)
> apart what could be infered from vendor/downstream drivers
> like in the commit text for patch 3/3...
>
> So I guess I'll send a v2 with a commit text along these lines :
> Document AK7345 bindings.
> Compared to AK7375, it has only 9 bits position values (instead of 12),
> 20 ms power-up delay (instead of 10), and no known standby register setting.
Yah, that is the exact sort of information that is good to have, thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-11-01 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 10:22 [PATCH 1/3] media: i2c: ak7375: Prepare for supporting another chip Vincent Knecht
2023-11-01 10:22 ` [PATCH 2/3] media: dt-bindings: ak7375: Add ak7345 support Vincent Knecht
2023-11-01 15:10 ` Conor Dooley
2023-11-01 15:29 ` Vincent Knecht
2023-11-01 15:33 ` Conor Dooley [this message]
2023-11-01 10:22 ` [PATCH 3/3] media: i2c: ak7375: Add support for ak7345 Vincent Knecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231101-floss-mortified-452c96c9af46@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=vincent.knecht@mailoo.org \
--cc=y.oudjana@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.