From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99843C4167B for ; Tue, 31 Oct 2023 23:53:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C37F10E5E8; Tue, 31 Oct 2023 23:53:08 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9C0A510E5DB; Tue, 31 Oct 2023 23:53:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698796385; x=1730332385; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=4i1y3DVKkpZNztiXnFlc1I3XO3HIruaCd99l2W6lqvs=; b=LPjOSX8S2cubHOJwNJpFs7YZg4OBdWnU5F5Q/BG7SnhB1jxKdosydYd0 eUoN08JtylQejdBtqlP6EEOsQiGbWZ6dBcAfI9M8dQsgVEjFstLphxsFP tEbCVe6lHnuP1bS/ojjOy1wTvU86zlgYbdVZ2DvkmgRbx8xRzVvvlf6sr 0BJgqYWSgnDyla4whTP2A+3bLwZmqBViWsDXeQbqkICzC1QohnupUzCBd wFSu1Y0171IXlh//4Q6zIRdSe5ijD32VDgUmwDkZ+HhWuYvd3S8Q1MM9m VVVuFpnPbokMcNITibk+85LEEpHmmVme8jvK0NhjraTzcTAEPnhuiYYie A==; X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="419516381" X-IronPort-AV: E=Sophos;i="6.03,266,1694761200"; d="scan'208";a="419516381" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2023 16:53:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="1092168372" X-IronPort-AV: E=Sophos;i="6.03,266,1694761200"; d="scan'208";a="1092168372" Received: from lkp-server01.sh.intel.com (HELO 17d9e85e5079) ([10.239.97.150]) by fmsmga005.fm.intel.com with ESMTP; 31 Oct 2023 16:53:03 -0700 Received: from kbuild by 17d9e85e5079 with local (Exim 4.96) (envelope-from ) id 1qxyXd-0000T8-0Z; Tue, 31 Oct 2023 23:53:01 +0000 Date: Wed, 1 Nov 2023 07:52:21 +0800 From: kernel test robot To: Tatsuyuki Ishi , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/6] drm/amdgpu: Separate eviction from VM status. Message-ID: <202311010709.XbwKjVaq-lkp@intel.com> References: <20231031134059.171277-3-ishitatsuyuki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231031134059.171277-3-ishitatsuyuki@gmail.com> X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tatsuyuki Ishi , christian.koenig@amd.com, oe-kbuild-all@lists.linux.dev Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Hi Tatsuyuki, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.6 next-20231031] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Tatsuyuki-Ishi/drm-amdgpu-Don-t-implicit-sync-PRT-maps/20231031-224530 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20231031134059.171277-3-ishitatsuyuki%40gmail.com patch subject: [PATCH 2/6] drm/amdgpu: Separate eviction from VM status. config: arc-randconfig-001-20231101 (https://download.01.org/0day-ci/archive/20231101/202311010709.XbwKjVaq-lkp@intel.com/config) compiler: arceb-elf-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231101/202311010709.XbwKjVaq-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202311010709.XbwKjVaq-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:178: warning: Function parameter or member 'evicted' not described in 'amdgpu_vm_bo_set_evicted' >> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:178: warning: expecting prototype for amdgpu_vm_bo_evicted(). Prototype was for amdgpu_vm_bo_set_evicted() instead vim +178 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c dcb388eddb5f1b Nirmoy Das 2021-06-28 168 bcdc9fd634d1f0 Christian König 2018-08-30 169 /** bcdc9fd634d1f0 Christian König 2018-08-30 170 * amdgpu_vm_bo_evicted - vm_bo is evicted bcdc9fd634d1f0 Christian König 2018-08-30 171 * bcdc9fd634d1f0 Christian König 2018-08-30 172 * @vm_bo: vm_bo which is evicted bcdc9fd634d1f0 Christian König 2018-08-30 173 * bcdc9fd634d1f0 Christian König 2018-08-30 174 * State for PDs/PTs and per VM BOs which are not at the location they should bcdc9fd634d1f0 Christian König 2018-08-30 175 * be. bcdc9fd634d1f0 Christian König 2018-08-30 176 */ cac82290238e47 Tatsuyuki Ishi 2023-10-31 177 static void amdgpu_vm_bo_set_evicted(struct amdgpu_vm_bo_base *vm_bo, bool evicted) bcdc9fd634d1f0 Christian König 2018-08-30 @178 { bcdc9fd634d1f0 Christian König 2018-08-30 179 struct amdgpu_vm *vm = vm_bo->vm; bcdc9fd634d1f0 Christian König 2018-08-30 180 struct amdgpu_bo *bo = vm_bo->bo; bcdc9fd634d1f0 Christian König 2018-08-30 181 757eb2bedd08a1 Philip Yang 2022-09-15 182 spin_lock(&vm_bo->vm->status_lock); cac82290238e47 Tatsuyuki Ishi 2023-10-31 183 if (evicted && bo->tbo.base.resv == vm->root.bo->tbo.base.resv) { bcdc9fd634d1f0 Christian König 2018-08-30 184 if (bo->tbo.type == ttm_bo_type_kernel) cac82290238e47 Tatsuyuki Ishi 2023-10-31 185 list_move(&vm_bo->eviction_status, &vm->evicted); bcdc9fd634d1f0 Christian König 2018-08-30 186 else cac82290238e47 Tatsuyuki Ishi 2023-10-31 187 list_move_tail(&vm_bo->eviction_status, &vm->evicted); cac82290238e47 Tatsuyuki Ishi 2023-10-31 188 } else { cac82290238e47 Tatsuyuki Ishi 2023-10-31 189 list_del_init(&vm_bo->eviction_status); cac82290238e47 Tatsuyuki Ishi 2023-10-31 190 } 757eb2bedd08a1 Philip Yang 2022-09-15 191 spin_unlock(&vm_bo->vm->status_lock); bcdc9fd634d1f0 Christian König 2018-08-30 192 } cac82290238e47 Tatsuyuki Ishi 2023-10-31 193 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ABE62232E for ; Tue, 31 Oct 2023 23:53:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="AGmElZUy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698796388; x=1730332388; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=4i1y3DVKkpZNztiXnFlc1I3XO3HIruaCd99l2W6lqvs=; b=AGmElZUy7eJWzJ8Ymqm2APowv7+8SXVUa8+T+sjxQ9NNLQKvQbFmCqSA yAyby6Hwfw/pGNxTnfM1fuLtIYKodmorspPoU5xiGmnMgo1zReImnRTZV zzM2cZZBCyqSGhybo13e27/FPf7rKOmMUMPRtVi5/s0ajEZQI7IQngpO4 FSKRZa2LlrL2h8L5CZmlWFuWcWM9xu7HsCj0rkH0VkId+qoixkAKWmi7l CD+aylDTRo8rG5NE32xumJnykyzHWmxYK9I8ZVUBRaYeOeVy6o8MO4ejv GEz7//egWPs7QSQkGOZkC9rgrUHcM2qa2AODkSvO8VluvjGvq4YVVWa7o g==; X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="419516379" X-IronPort-AV: E=Sophos;i="6.03,266,1694761200"; d="scan'208";a="419516379" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2023 16:53:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="1092168372" X-IronPort-AV: E=Sophos;i="6.03,266,1694761200"; d="scan'208";a="1092168372" Received: from lkp-server01.sh.intel.com (HELO 17d9e85e5079) ([10.239.97.150]) by fmsmga005.fm.intel.com with ESMTP; 31 Oct 2023 16:53:03 -0700 Received: from kbuild by 17d9e85e5079 with local (Exim 4.96) (envelope-from ) id 1qxyXd-0000T8-0Z; Tue, 31 Oct 2023 23:53:01 +0000 Date: Wed, 1 Nov 2023 07:52:21 +0800 From: kernel test robot To: Tatsuyuki Ishi , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Cc: oe-kbuild-all@lists.linux.dev, Tatsuyuki Ishi , christian.koenig@amd.com Subject: Re: [PATCH 2/6] drm/amdgpu: Separate eviction from VM status. Message-ID: <202311010709.XbwKjVaq-lkp@intel.com> References: <20231031134059.171277-3-ishitatsuyuki@gmail.com> Precedence: bulk X-Mailing-List: oe-kbuild-all@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231031134059.171277-3-ishitatsuyuki@gmail.com> Hi Tatsuyuki, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.6 next-20231031] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Tatsuyuki-Ishi/drm-amdgpu-Don-t-implicit-sync-PRT-maps/20231031-224530 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20231031134059.171277-3-ishitatsuyuki%40gmail.com patch subject: [PATCH 2/6] drm/amdgpu: Separate eviction from VM status. config: arc-randconfig-001-20231101 (https://download.01.org/0day-ci/archive/20231101/202311010709.XbwKjVaq-lkp@intel.com/config) compiler: arceb-elf-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231101/202311010709.XbwKjVaq-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202311010709.XbwKjVaq-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:178: warning: Function parameter or member 'evicted' not described in 'amdgpu_vm_bo_set_evicted' >> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:178: warning: expecting prototype for amdgpu_vm_bo_evicted(). Prototype was for amdgpu_vm_bo_set_evicted() instead vim +178 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c dcb388eddb5f1b Nirmoy Das 2021-06-28 168 bcdc9fd634d1f0 Christian König 2018-08-30 169 /** bcdc9fd634d1f0 Christian König 2018-08-30 170 * amdgpu_vm_bo_evicted - vm_bo is evicted bcdc9fd634d1f0 Christian König 2018-08-30 171 * bcdc9fd634d1f0 Christian König 2018-08-30 172 * @vm_bo: vm_bo which is evicted bcdc9fd634d1f0 Christian König 2018-08-30 173 * bcdc9fd634d1f0 Christian König 2018-08-30 174 * State for PDs/PTs and per VM BOs which are not at the location they should bcdc9fd634d1f0 Christian König 2018-08-30 175 * be. bcdc9fd634d1f0 Christian König 2018-08-30 176 */ cac82290238e47 Tatsuyuki Ishi 2023-10-31 177 static void amdgpu_vm_bo_set_evicted(struct amdgpu_vm_bo_base *vm_bo, bool evicted) bcdc9fd634d1f0 Christian König 2018-08-30 @178 { bcdc9fd634d1f0 Christian König 2018-08-30 179 struct amdgpu_vm *vm = vm_bo->vm; bcdc9fd634d1f0 Christian König 2018-08-30 180 struct amdgpu_bo *bo = vm_bo->bo; bcdc9fd634d1f0 Christian König 2018-08-30 181 757eb2bedd08a1 Philip Yang 2022-09-15 182 spin_lock(&vm_bo->vm->status_lock); cac82290238e47 Tatsuyuki Ishi 2023-10-31 183 if (evicted && bo->tbo.base.resv == vm->root.bo->tbo.base.resv) { bcdc9fd634d1f0 Christian König 2018-08-30 184 if (bo->tbo.type == ttm_bo_type_kernel) cac82290238e47 Tatsuyuki Ishi 2023-10-31 185 list_move(&vm_bo->eviction_status, &vm->evicted); bcdc9fd634d1f0 Christian König 2018-08-30 186 else cac82290238e47 Tatsuyuki Ishi 2023-10-31 187 list_move_tail(&vm_bo->eviction_status, &vm->evicted); cac82290238e47 Tatsuyuki Ishi 2023-10-31 188 } else { cac82290238e47 Tatsuyuki Ishi 2023-10-31 189 list_del_init(&vm_bo->eviction_status); cac82290238e47 Tatsuyuki Ishi 2023-10-31 190 } 757eb2bedd08a1 Philip Yang 2022-09-15 191 spin_unlock(&vm_bo->vm->status_lock); bcdc9fd634d1f0 Christian König 2018-08-30 192 } cac82290238e47 Tatsuyuki Ishi 2023-10-31 193 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki