From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6D17C4332F for ; Wed, 1 Nov 2023 08:11:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=lNoPA4v+8DYV5WJECUBzQVeUAZOqMkmOJjfSsKQHv7E=; b=UEwzgXkr0hlASb GZWMeZ/yejq9/BVkEjwTMI2LZzEgeqzeqo4KkpZSuGh4FYWiI1R4BoxGvnt/xBkTErxREx9CYTqfc 0oJ4U59NqI8kooTx6Inq1cZzAhsq/RaIcvK5AmsFPoxxFxgVZ7d8H4PUZbWQekYxI5bpBEcyZ5x8m 6LYYjEukLrGkKmr+c2A6Shk0bX2EZX0es7XZgZK/uVxV1QsIIzFiaJ3nWYQ30jMzL1V1KcpDXeLNa ay/eJC11jpuZMK73Y/PuqM9njyhPy0WHPSu/3632mc4JdPhoO1Z2fuQE5Ol+4FJnc8JQEZEYN0EqT ItdJPD1XEaxreV4MsY/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qy6JL-006rfU-35; Wed, 01 Nov 2023 08:10:47 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qy6JI-006rf4-2i for linux-arm-kernel@lists.infradead.org; Wed, 01 Nov 2023 08:10:46 +0000 Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-280200949c3so3265780a91.0 for ; Wed, 01 Nov 2023 01:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698826242; x=1699431042; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AScPjIzL2IRVVNBJtQbhX+2QHkK1rr3R5KLOy9omBhE=; b=EhJJ3uG7D4ZMvno2G36K6HvVwIv/8Uk1egHqqOMc175q9Q6X2O2pT9yAt8Wy9o7TuW 9GP+VAcmtPQc67RhY2hx7VMWhTI3klWfOqoyQAIsE8fdwi+Cgjl/QSj3Tqgf6ORGsMiI bm0emv7GLknDc9VBEO35ez1UPprpdNeKs/0VmGh6Jk9hFp9RwKFw01iOd65nIdJ5HRdq nvueSOxF9WAm6q8EFAp2Gz+UZ8I6zyDsZ6VarzIrdpuCMdmYIPb6bAyzWmQCapDo09Xv /MciOzsV304msNhncMe3VOj+lV4tdIb4FDJBykZyf9WcXbDkCN+l19ruH6IDaV8PZEVX oHog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698826242; x=1699431042; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AScPjIzL2IRVVNBJtQbhX+2QHkK1rr3R5KLOy9omBhE=; b=Qta3GpAqBOFG417aCCI8HxTuW061bcW8JZVb1xZJFE+TGFYE/DeBPcQagxV+rzTSJq hBllfPzEz5t/voM2Q4dT2cOGe7TdzGZJbpmvz0M40y3Rt97CGKSpA/fCeK2DW+IPKdyL /kCi0HQ/X4JPD6iJEGCEdjSnPvxqEevaLx3iJlRG4lIe+xP046lxLWGRAnjhtR4gQFIA Pny+qLfBE/bSUCJAxyGGFycCKWfMuiQgwl8yj52z0xNaJKVyy2xK+UEZVD/VOOxIgqQn YBnHaw4ze+4U0aWcqhgjDFwC0krrnvncf8xHuz/e2EpDhtSU/mJJlmQqcsUl8bjWGPOo tPvQ== X-Gm-Message-State: AOJu0YxyzkDh4wK1SxK1UWnCjGVZzB0mKXLIUYeqkKMI8Fz4hf2Ze+Lb LWxOaD8WK8rbnNdpzkjNnfb0akCDGMU= X-Google-Smtp-Source: AGHT+IHTuEAHkoFnIOfwtVgnuinYZJiyAHatwC2eG39LOjFJwerslfN9LOsZwFQRdaxRMXpCuFsirg== X-Received: by 2002:a17:90a:ce85:b0:280:8c99:1801 with SMTP id g5-20020a17090ace8500b002808c991801mr5413579pju.16.1698826242553; Wed, 01 Nov 2023 01:10:42 -0700 (PDT) Received: from localhost.localdomain ([58.48.52.254]) by smtp.gmail.com with ESMTPSA id qa2-20020a17090b4fc200b0028095e2edb8sm393765pjb.5.2023.11.01.01.10.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 01:10:42 -0700 (PDT) From: "xinglong.yang" X-Google-Original-From: "xinglong.yang" To: xinglong.yang@cixtech.com, sudeep.holla@arm.com, cristian.marussi@arm.com Cc: linux-arm-kernel@lists.infradead.org Subject: [PATCH] firmware: arm_scmi: Remove inappropriate error log. Date: Wed, 1 Nov 2023 16:10:35 +0800 Message-ID: <20231101081035.1162993-1-xinglong.yang@cixtech.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231101_011044_881396_87E28F6A X-CRM114-Status: GOOD ( 13.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The platform may not support fastchannel, but this is a legal operation. -Before this patch, when the platform not support fastchannel, goto err_xfer will print "Failed to ...". This log is misleading. -With this patch, when the fastchannel is not been supported, the "Failed to ..." log will be skipped. Signed-off-by: xinglong.yang --- drivers/firmware/arm_scmi/driver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index b5957cc12fee..2b990e50c8a5 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -1642,7 +1642,10 @@ scmi_common_fastchannel_init(const struct scmi_protocol_handle *ph, * fastchannels at all. */ ret = ph->xops->do_xfer(ph, t); - if (ret) + if (ret == -EOPNOTSUPP) { + ph->xops->xfer_put(ph, t); + goto return_normal; + } else if (ret) goto err_xfer; resp = t->rx.buf; @@ -1695,6 +1698,7 @@ scmi_common_fastchannel_init(const struct scmi_protocol_handle *ph, "Using valid FC for protocol %X [MSG_ID:%u / RES_ID:%u]\n", pi->proto->id, message_id, domain); +return_normal: return; err_db_mem: -- 2.42.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel