From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B34BC4332F for ; Wed, 1 Nov 2023 13:59:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F85A10E6F9; Wed, 1 Nov 2023 13:59:47 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id A3FDC10E6F9 for ; Wed, 1 Nov 2023 13:59:45 +0000 (UTC) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B1998D; Wed, 1 Nov 2023 14:59:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1698847167; bh=Kk3cjpPlYgWjFuX7ru0ITvm8imGQnvx+xHTP55Nst3A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XoNlyhp61ZZwdbxNajaWf/3bxNhh9B4faX5CGYslMRpd22WVCTUkSZcGng3ZelBFg qUvuBfblVMaazuyzO341Ekx1lDdX9RVskSp5L+l1hJreb53muRxOD+WKTaPxBU8B1k wv6UEBV6B0kL7zT4JIWfqoryTUWZyOjuQURKhqcI= Date: Wed, 1 Nov 2023 15:59:51 +0200 From: Laurent Pinchart To: Tomi Valkeinen Subject: Re: [PATCH 05/10] drm/tidss: Return error value from from softreset Message-ID: <20231101135951.GU12764@pendragon.ideasonboard.com> References: <20231101-tidss-probe-v1-0-45149e0f9415@ideasonboard.com> <20231101-tidss-probe-v1-5-45149e0f9415@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231101-tidss-probe-v1-5-45149e0f9415@ideasonboard.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aradhya Bhatia , Devarsh Thakkar , linux-kernel@vger.kernel.org, Maxime Ripard , dri-devel@lists.freedesktop.org, Thomas Zimmermann , Jyri Sarha Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Tomi, Thank you for the patch. On Wed, Nov 01, 2023 at 11:17:42AM +0200, Tomi Valkeinen wrote: > Return an error value from dispc_softreset() so that the caller can > handle the errors. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/tidss/tidss_dispc.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c > index 9430625e2d62..cdbb88289082 100644 > --- a/drivers/gpu/drm/tidss/tidss_dispc.c > +++ b/drivers/gpu/drm/tidss/tidss_dispc.c > @@ -2702,7 +2702,7 @@ static void dispc_init_errata(struct dispc_device *dispc) > } > } > > -static void dispc_softreset(struct dispc_device *dispc) > +static int dispc_softreset(struct dispc_device *dispc) > { > u32 val; > int ret; > @@ -2712,8 +2712,12 @@ static void dispc_softreset(struct dispc_device *dispc) > /* Wait for reset to complete */ > ret = readl_poll_timeout(dispc->base_common + DSS_SYSSTATUS, > val, val & 1, 100, 5000); > - if (ret) > - dev_warn(dispc->dev, "failed to reset dispc\n"); > + if (ret) { > + dev_err(dispc->dev, "failed to reset dispc\n"); > + return ret; > + } > + > + return 0; > } > > int dispc_init(struct tidss_device *tidss) > @@ -2828,8 +2832,11 @@ int dispc_init(struct tidss_device *tidss) > tidss->dispc = dispc; > > /* K2G display controller does not support soft reset */ > - if (feat->subrev != DISPC_K2G) > - dispc_softreset(dispc); > + if (feat->subrev != DISPC_K2G) { > + r = dispc_softreset(dispc); > + if (r) > + return r; tidss->dispc will be set in this case. Could that cause problems ? > + } > > return 0; > } > -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA5BC4332F for ; Wed, 1 Nov 2023 13:59:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343489AbjKAN7x (ORCPT ); Wed, 1 Nov 2023 09:59:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231555AbjKAN7v (ORCPT ); Wed, 1 Nov 2023 09:59:51 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3032C1 for ; Wed, 1 Nov 2023 06:59:45 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B1998D; Wed, 1 Nov 2023 14:59:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1698847167; bh=Kk3cjpPlYgWjFuX7ru0ITvm8imGQnvx+xHTP55Nst3A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XoNlyhp61ZZwdbxNajaWf/3bxNhh9B4faX5CGYslMRpd22WVCTUkSZcGng3ZelBFg qUvuBfblVMaazuyzO341Ekx1lDdX9RVskSp5L+l1hJreb53muRxOD+WKTaPxBU8B1k wv6UEBV6B0kL7zT4JIWfqoryTUWZyOjuQURKhqcI= Date: Wed, 1 Nov 2023 15:59:51 +0200 From: Laurent Pinchart To: Tomi Valkeinen Cc: Aradhya Bhatia , Devarsh Thakkar , Jyri Sarha , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/10] drm/tidss: Return error value from from softreset Message-ID: <20231101135951.GU12764@pendragon.ideasonboard.com> References: <20231101-tidss-probe-v1-0-45149e0f9415@ideasonboard.com> <20231101-tidss-probe-v1-5-45149e0f9415@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231101-tidss-probe-v1-5-45149e0f9415@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomi, Thank you for the patch. On Wed, Nov 01, 2023 at 11:17:42AM +0200, Tomi Valkeinen wrote: > Return an error value from dispc_softreset() so that the caller can > handle the errors. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/tidss/tidss_dispc.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c > index 9430625e2d62..cdbb88289082 100644 > --- a/drivers/gpu/drm/tidss/tidss_dispc.c > +++ b/drivers/gpu/drm/tidss/tidss_dispc.c > @@ -2702,7 +2702,7 @@ static void dispc_init_errata(struct dispc_device *dispc) > } > } > > -static void dispc_softreset(struct dispc_device *dispc) > +static int dispc_softreset(struct dispc_device *dispc) > { > u32 val; > int ret; > @@ -2712,8 +2712,12 @@ static void dispc_softreset(struct dispc_device *dispc) > /* Wait for reset to complete */ > ret = readl_poll_timeout(dispc->base_common + DSS_SYSSTATUS, > val, val & 1, 100, 5000); > - if (ret) > - dev_warn(dispc->dev, "failed to reset dispc\n"); > + if (ret) { > + dev_err(dispc->dev, "failed to reset dispc\n"); > + return ret; > + } > + > + return 0; > } > > int dispc_init(struct tidss_device *tidss) > @@ -2828,8 +2832,11 @@ int dispc_init(struct tidss_device *tidss) > tidss->dispc = dispc; > > /* K2G display controller does not support soft reset */ > - if (feat->subrev != DISPC_K2G) > - dispc_softreset(dispc); > + if (feat->subrev != DISPC_K2G) { > + r = dispc_softreset(dispc); > + if (r) > + return r; tidss->dispc will be set in this case. Could that cause problems ? > + } > > return 0; > } > -- Regards, Laurent Pinchart