Re: [Buildroot] [PATCH] package/openldap: bump version to 2.5.16

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Hmaied

On Mon, 23 Oct 2023 17:32:29 +0200
Hmaied Ben Abdellatif <hmaied.benabdellatif@etictelecom.com> wrote:

>  From 45fa861afacd95367e716e21f3987dbbe865cf74 Mon Sep 17 00:00:00 2001
> From: Hmaied Ben Abdellatif <hmaied.benabdellatif@etictelecom.com>
> Date: Mon, 23 Oct 2023 16:53:01 +0200
> Subject: [PATCH] package/openldap: bump version to 2.5.16
> 
> Signed-off-by: Hmaied Ben Abdellatif <hmaied.benabdellatif@etictelecom.com>

Thanks for your patch. However, it looks like you have done "git
format-patch", and then send the contents of that file with your
regular e-mail client (Thunderbird). Due to this, the patch is badly
line-wrapped, and it cannot be applied.

Could you instead follow the instructions at
https://buildroot.org/downloads/manual/manual.html#submitting-patches
and use "git send-email" to submit your patch? This will ensure it
arrives properly formatted on the mailing list.

> +Initially-Signed by "Yann E. MORIN" <yann.morin.1998@free.fr> fixed for
> +openldap-2.5.16

Don't do this. Instead, keep the Signed-off-by from Yann E. Morin, and
add yours below Yann's Signed-off-by. Of course, this only makes sense
if you did some substantial changes to this patch. If you did only some
minor updates to ensure it applies against the new version of openldap,
adding your Signed-off-by within this patch is not even needed.

Could you fix those two issues and submitted an updated patch?

Thanks a lot!

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot