Re: [Buildroot] [PATCH] package/zenoh-c: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Alex,

On Wed, 18 Oct 2023 08:15:28 +0000
Michel Alex <Alex.Michel@wiedemann-group.com> wrote:

> This package provides a C binding based on the main
> Zenoh implementation written in Rust.
> 
> https://github.com/eclipse-zenoh/zenoh-c
> 
> Signed-off-by: Alex Michel <alex.michel@wiedemann-group.com>

Thanks for this contribution.

>  package/Config.in            |  1 +
>  package/zenoh-c/Config.in    |  9 +++++++++
>  package/zenoh-c/zenoh-c.hash |  3 +++
>  package/zenoh-c/zenoh-c.mk   | 26 ++++++++++++++++++++++++++
>  4 files changed, 39 insertions(+)

Entry in the DEVELOPERS file is missing.


> +ZENOH_C_VERSION = 0.10.0-rc
> +ZENOH_C_SITE = $(call github,eclipse-zenoh,zenoh-c,$(ZENOH_C_VERSION))
> +ZENOH_C_LICENSE = EPL-2.0

License is:

Apache-2.0 or EPL-2.0

> +ZENOH_C_LICENSE_FILES = LICENSE
> +
> +# Install default config file
> +define ZENOH_C_INSTALL_FILES
> +       $(INSTALL) -D -m 644 $(@D)/target/*/release/libzenohc.so $(TARGET_DIR)/usr/lib/
> +       $(INSTALL) -D -m 644 $(@D)/include/* $(STAGING_DIR)/usr/include/

Meh, you're installing things to staging in the post install target
hook. Also, the shared library should also be installed to staging.

> +endef
> +ZENOH_C_POST_INSTALL_TARGET_HOOKS += ZENOH_C_INSTALL_FILES
> +
> +# no install step necessary because it is not possible to install libraries using cargo command
> +# library and header files are installed above
> +define ZENOH_C_INSTALL_TARGET_CMDS
> +       # empty
> +endef

Then what you should do is:

define ZENOH_C_INSTALL_FILES
	$(INSTALL) -D -m 644 $(@D)/target/*/release/libzenohc.so $(1)/usr/lib/libzenohc.so
	mkdir -p $(STAGING_DIR)/usr/include/
	cp -dpfr $(@D)/include/* $(STAGING_DIR)/usr/include/
endif

define ZENOH_C_INSTALL_TARGET_CMDS
	$(call ZENOH_C_INSTALL_FILES,$(TARGET_DIR))
endef

define ZENOH_C_INSTALL_STAGING_CMDS
	$(call ZENOH_C_INSTALL_FILES,$(STAGING_DIR))
endef

However, I have some other questions:

- You're using cargo to build this package, but at
  https://github.com/eclipse-zenoh/zenoh-c they suggest to use CMake.
  Any opinion on this?

- When using cargo to build,
  https://github.com/eclipse-zenoh/zenoh-c/blob/master/Cargo.toml is
  used, and I'm worried by the following lines:

zenoh = { git = "https://github.com/eclipse-zenoh/zenoh.git", branch = "master", features = [ "shared-memory", "unstable" ] }
zenoh-protocol = { git = "https://github.com/eclipse-zenoh/zenoh.git", branch = "master", features = [ "shared-memory" ] }
zenoh-util = { git = "https://github.com/eclipse-zenoh/zenoh.git", branch = "master" }

  I'm not too familiar with Cargo, but to me this looks like it is
  going to pull the latest "master" branch of zenoh, zenoh-protocol,
  zenoh-util. So it means that the build of zenoh-c is not
  reproducible, as you will pull different things from those master
  branches depending on when you do your build. Could you comment on
  this?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot