From: Jakub Kicinski <kuba@kernel.org>
To: Ren Mingshuai <renmingshuai@huawei.com>
Cc: <caowangbao@huawei.com>, <davem@davemloft.net>,
<khlebnikov@openvz.org>, <liaichun@huawei.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<oneukum@suse.com>, <yanan@huawei.com>
Subject: Re: [PATCH] net: usbnet: Fix potential NULL pointer dereference
Date: Wed, 1 Nov 2023 21:38:32 -0700 [thread overview]
Message-ID: <20231101213832.77bd657b@kernel.org> (raw)
In-Reply-To: <20231101125511.222629-1-renmingshuai@huawei.com>
On Wed, 1 Nov 2023 20:55:11 +0800 Ren Mingshuai wrote:
> >23ba07991dad said SKB can be NULL without describing the triggering
> >scenario. Always Check it before dereference to void potential NULL
> >pointer dereference.
> I've tried to find out the scenarios where SKB is NULL, but failed.
> It seems impossible for SKB to be NULL. If SKB can be NULL, please tell
> me the reason and I'd be very grateful.
What do you mean? Grepping the function name shows call sites with NULL
getting passed as skb.
next prev parent reply other threads:[~2023-11-02 4:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 12:35 [PATCH] net: usbnet: Fix potential NULL pointer dereference Ren Mingshuai
2023-11-01 12:55 ` Ren Mingshuai
2023-11-02 4:38 ` Jakub Kicinski [this message]
2023-11-02 9:06 ` Ren Mingshuai
2023-11-06 10:18 ` Oliver Neukum
2023-11-06 10:55 ` Bjørn Mork
2023-11-06 12:53 ` Oliver Neukum
2023-11-06 12:59 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231101213832.77bd657b@kernel.org \
--to=kuba@kernel.org \
--cc=caowangbao@huawei.com \
--cc=davem@davemloft.net \
--cc=khlebnikov@openvz.org \
--cc=liaichun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=renmingshuai@huawei.com \
--cc=yanan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.