Re: [Buildroot] [PATCH 1/1] package/libgeos: needs gcc >= 4.9

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Maxim Kochetkov <fido_max@inbox.ru>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libgeos: needs gcc >= 4.9
Date: Wed, 1 Nov 2023 23:13:18 +0100	[thread overview]
Message-ID: <20231101231318.496e60ea@windsurf> (raw)
In-Reply-To: <20231015201449.1279312-1-fontaine.fabrice@gmail.com>

On Sun, 15 Oct 2023 22:14:49 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> libgeos needs gcc >= 4.9 since bump to version 3.12.0 in commit
> 16727d4595dd1972a46e92bbd2260a896cc19b60 and
> https://github.com/libgeos/geos/commit/289ed4efb26a9944f4385381e1574184b1e7448e:
> 
> In file included from /home/thomas/autobuild/instance-0/output-1/build/libgeos-3.12.0/src/algorithm/ConvexHull.cpp:30:0:
> /home/thomas/autobuild/instance-0/output-1/build/libgeos-3.12.0/include/geos/util.h:38:12: error: 'std::make_unique' has not been declared
>  using std::make_unique;
>             ^
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/56bb572fb1d56d45dbb950a73b9b888239fa6968
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libgeos/Config.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

I've applied, but you had forgotten to look at the reverse dependencies
of BR2_PACKAGE_LIBGEOS. Namely, BR2_PACKAGE_POSTGIS selects
BR2_PACKAGE_LIBGEOS, so it needs to inherit this dependency on gcc >=
4.9, so I fixed that when applying.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot