From: Florian Westphal <fw@strlen.de>
To: Thomas Haller <thaller@redhat.com>
Cc: NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft 2/7] json: drop messages "warning: stmt ops chain have no json callback"
Date: Thu, 2 Nov 2023 09:04:54 +0100 [thread overview]
Message-ID: <20231102080454.GA23579@breakpoint.cc> (raw)
In-Reply-To: <20231031185449.1033380-3-thaller@redhat.com>
Thomas Haller <thaller@redhat.com> wrote:
> This message purely depends on the internal callbacks and at the program
> code. This is not useful. What is the user going to do with this warning?
Report a bug.
> Maybe there is a bug here, but then we shouldn't print a warning but fix
> the bug.
How on earth do we do that, fix a bug before we know its there?
> For example, calling `nft -j list ruleset` after test "tests/shell/testcases/chains/0041chain_binding_0"
> will trigger messages like:
>
> warning: stmt ops chain have no json callback
> warning: stmt ops chain have no json callback
That means that chain ops needs a bug fix as they do not support
json output?
next prev parent reply other threads:[~2023-11-02 8:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 18:53 [PATCH nft 0/7] add and check dump files for JSON in tests/shell Thomas Haller
2023-10-31 18:53 ` [PATCH nft 1/7] json: fix use after free in table_flags_json() Thomas Haller
2023-10-31 18:53 ` [PATCH nft 2/7] json: drop messages "warning: stmt ops chain have no json callback" Thomas Haller
2023-11-02 8:04 ` Florian Westphal [this message]
2023-11-02 8:39 ` Thomas Haller
2023-11-02 11:23 ` Thomas Haller
2023-10-31 18:53 ` [PATCH nft 3/7] tests/shell: check and generate JSON dump files Thomas Haller
2023-10-31 18:53 ` [PATCH nft 5/7] tools: simplify error handling in "check-tree.sh" by adding msg_err()/msg_warn() Thomas Haller
2023-10-31 18:53 ` [PATCH nft 6/7] tools: check more strictly for bash shebang in "check-tree.sh" Thomas Haller
2023-10-31 18:53 ` [PATCH nft 7/7] tools: check for consistency of .json-nft dumps " Thomas Haller
2023-10-31 19:17 ` [PATCH nft 0/7] add and check dump files for JSON in tests/shell Thomas Haller
2023-11-01 8:28 ` Pablo Neira Ayuso
2023-11-01 9:55 ` Thomas Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231102080454.GA23579@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.