From: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Chris Wilson <chris.p.wilson@linux.intel.com>
Subject: [Intel-gfx] [PATCH] drm/i915/mtl: Increase guard pages when vt-d is enabled
Date: Thu, 2 Nov 2023 09:06:44 -0700 [thread overview]
Message-ID: <20231102160644.1279801-1-radhakrishna.sripada@intel.com> (raw)
Experiments were conducted with different multipliers to VTD_GUARD macro
with multiplier of 185 we were observing occasional pipe faults when
running kms_cursor_legacy --run-subtest single-bo
There could possibly be an underlying issue that is being investigated, for
now bump the guard pages for MTL.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2017
Cc: Gustavo Sousa <gustavo.sousa@intel.com>
Cc: Chris Wilson <chris.p.wilson@linux.intel.com>
Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_domain.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_domain.c b/drivers/gpu/drm/i915/gem/i915_gem_domain.c
index 3770828f2eaf..b65f84c6bb3f 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_domain.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_domain.c
@@ -456,6 +456,9 @@ i915_gem_object_pin_to_display_plane(struct drm_i915_gem_object *obj,
if (intel_scanout_needs_vtd_wa(i915)) {
unsigned int guard = VTD_GUARD;
+ if (IS_METEORLAKE(i915))
+ guard *= 200;
+
if (i915_gem_object_is_tiled(obj))
guard = max(guard,
i915_gem_object_get_tile_row_size(obj));
--
2.34.1
next reply other threads:[~2023-11-02 16:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 16:06 Radhakrishna Sripada [this message]
2023-11-02 16:35 ` [Intel-gfx] [PATCH] drm/i915/mtl: Increase guard pages when vt-d is enabled Gustavo Sousa
2023-11-02 18:01 ` Gustavo Sousa
2023-11-03 15:35 ` Rodrigo Vivi
2023-11-03 17:38 ` Sripada, Radhakrishna
2023-11-02 16:58 ` Andrzej Hajda
2023-11-02 17:41 ` Tvrtko Ursulin
2023-11-02 22:14 ` Sripada, Radhakrishna
2023-11-03 8:30 ` Tvrtko Ursulin
2023-11-03 15:53 ` Sripada, Radhakrishna
2023-11-03 21:18 ` Andrzej Hajda
2023-11-03 22:23 ` Sripada, Radhakrishna
2023-11-03 1:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-11-03 17:43 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231102160644.1279801-1-radhakrishna.sripada@intel.com \
--to=radhakrishna.sripada@intel.com \
--cc=chris.p.wilson@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.