From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF31C1DA53 for ; Thu, 2 Nov 2023 16:58:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="A72pkk6X" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3add37de892so652549b6e.1 for ; Thu, 02 Nov 2023 09:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698944299; x=1699549099; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=DfyS21pSAaN9Ul5DPXfGOsxbkU+EJCrhzTnYRsGJibU=; b=A72pkk6X7NRWhCE9edWCP1z01ztvBLGkw0P02uEbow5/eWtfrgqSnT3dAao+Twwh36 Ote9RqArLuvEpvHDjEWS6269LKolgoMeWyQxFaBRqQkn6m9crhOLXAzsr9wt/7ix4hpV evzkRLRUFnzdCo7UQ4mHmtP72GhOxcF9hkiAI7jSg5KIEe+i19vYkgimETjcSj0g/8cl iVXtLQuNgEMIHVuFmdLPciKGi+muXgxjapqhcGG6oXkSZn5tCIkSIFKmXbgztmYLOIuk wGjHdtl9Bphr3aFQA58ajS1GRvsyoEFw4Ttxu0WITBMKdheqionfGkt9vpm4C6brV75A 2NrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698944299; x=1699549099; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DfyS21pSAaN9Ul5DPXfGOsxbkU+EJCrhzTnYRsGJibU=; b=Ls7ODdQrtwaWZ7Xk9RFQjIkM2ubFyJmrlhuw2p9S58vXQBjzbZUhAVV8DHHIMgmimx 2UE/36JR2mN6jrt3DF9Tv7DPSZoLGW1lG8wulyHXmwiykr/8hPkz3zVT933ouTHTFmLG fDlMDCIBDQRsAkSdmNFUtGnlsSCgUMI8z2glRp6KfNfCOmCqrOJMBs0wmWo7uTj8m1o+ OouwpkIqcqHN08NlYQzEOFS6WaHFUO/jQJIDSSpKupARt0A/pKsrZpPY7uqu4rPEcegH Wu8ij59PqZiY/Elz6gi9Vi1rFexsTj9P666jg+vIaLqHOFw0pdRRmaEIqClfHZ0QInAn AojA== X-Gm-Message-State: AOJu0YzK8oym7WcOrv/Z8XIqGHCIymqptzhjsHK9rwzUCMuD66bqRWJe jO/LhYHom3n2G1jANLJacEEZ X-Google-Smtp-Source: AGHT+IGcPZMPmb6P3crHIYT6MoFFJH19w/pybMCanZfpyJq0eFqq7TsGozYLDzAec+P33O2PTiZXzg== X-Received: by 2002:a05:6808:209f:b0:3ad:fe8d:dfae with SMTP id s31-20020a056808209f00b003adfe8ddfaemr20056494oiw.57.1698944298897; Thu, 02 Nov 2023 09:58:18 -0700 (PDT) Received: from thinkpad ([117.217.189.228]) by smtp.gmail.com with ESMTPSA id z26-20020a05620a08da00b0077263636a95sm89742qkz.93.2023.11.02.09.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 09:58:18 -0700 (PDT) Date: Thu, 2 Nov 2023 22:28:08 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: bhelgaas@google.com, imx@lists.linux.dev, kw@linux.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, lpieralisi@kernel.org, minghuan.Lian@nxp.com, mingkai.hu@nxp.com, robh@kernel.org, roy.zang@nxp.com Subject: Re: [PATCH v3 1/4] PCI: layerscape: Add function pointer for exit_from_l2() Message-ID: <20231102165808.GC20943@thinkpad> References: <20231017193145.3198380-1-Frank.Li@nxp.com> <20231017193145.3198380-2-Frank.Li@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231017193145.3198380-2-Frank.Li@nxp.com> On Tue, Oct 17, 2023 at 03:31:42PM -0400, Frank Li wrote: > Since difference SoCs require different sequence for exiting L2, let's add > a separate "exit_from_l2()" callback. This callback can be used to execute > SoC specific sequence. > I missed the fact that this patch honors the return value of the callback (which was ignored previously). So this should be added to the description as well. > Signed-off-by: Frank Li With that, Reviewed-by: Manivannan Sadhasivam - Mani > --- > > Notes: > Change from v2 to v3 > - fixed according to mani's feedback > 1. update commit message > 2. move dw_pcie_host_ops to next patch > 3. check return value from exit_from_l2() > Change from v1 to v2 > - change subject 'a' to 'A' > > Change from v1 to v2 > - change subject 'a' to 'A' > > drivers/pci/controller/dwc/pci-layerscape.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c > index 37956e09c65bd..aea89926bcc4f 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape.c > +++ b/drivers/pci/controller/dwc/pci-layerscape.c > @@ -39,6 +39,7 @@ > > struct ls_pcie_drvdata { > const u32 pf_off; > + int (*exit_from_l2)(struct dw_pcie_rp *pp); > bool pm_support; > }; > > @@ -125,7 +126,7 @@ static void ls_pcie_send_turnoff_msg(struct dw_pcie_rp *pp) > dev_err(pcie->pci->dev, "PME_Turn_off timeout\n"); > } > > -static void ls_pcie_exit_from_l2(struct dw_pcie_rp *pp) > +static int ls_pcie_exit_from_l2(struct dw_pcie_rp *pp) > { > struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > struct ls_pcie *pcie = to_ls_pcie(pci); > @@ -150,6 +151,8 @@ static void ls_pcie_exit_from_l2(struct dw_pcie_rp *pp) > 10000); > if (ret) > dev_err(pcie->pci->dev, "L2 exit timeout\n"); > + > + return ret; > } > > static int ls_pcie_host_init(struct dw_pcie_rp *pp) > @@ -180,6 +183,7 @@ static const struct ls_pcie_drvdata ls1021a_drvdata = { > static const struct ls_pcie_drvdata layerscape_drvdata = { > .pf_off = 0xc0000, > .pm_support = true, > + .exit_from_l2 = ls_pcie_exit_from_l2, > }; > > static const struct of_device_id ls_pcie_of_match[] = { > @@ -247,11 +251,14 @@ static int ls_pcie_suspend_noirq(struct device *dev) > static int ls_pcie_resume_noirq(struct device *dev) > { > struct ls_pcie *pcie = dev_get_drvdata(dev); > + int ret; > > if (!pcie->drvdata->pm_support) > return 0; > > - ls_pcie_exit_from_l2(&pcie->pci->pp); > + ret = pcie->drvdata->exit_from_l2(&pcie->pci->pp); > + if (ret) > + return ret; > > return dw_pcie_resume_noirq(pcie->pci); > } > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13680C4167D for ; Thu, 2 Nov 2023 16:59:19 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=TncAICxe; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SLqps1Wthz3cW7 for ; Fri, 3 Nov 2023 03:59:17 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=TncAICxe; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::235; helo=mail-oi1-x235.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=lists.ozlabs.org) Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SLqnr1mJQz3cVr for ; Fri, 3 Nov 2023 03:58:21 +1100 (AEDT) Received: by mail-oi1-x235.google.com with SMTP id 5614622812f47-3b5714439b3so649707b6e.3 for ; Thu, 02 Nov 2023 09:58:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698944299; x=1699549099; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=DfyS21pSAaN9Ul5DPXfGOsxbkU+EJCrhzTnYRsGJibU=; b=TncAICxeuz4KO+ZiuEFXTDGmDtEg9Go5hq20plVja9WJIRWVTMC0jBBhvDHebaO9fA qgsSOfOVBjJUnUzt/sOc0zS0hC6V/tZ44gUHdB5wXhPpNDafdEl7x3Coqjj8jxKEa8RB rd62o8eGN+mzOcPSNDPkUyKJwdWK1nm+lr8qiUaXMvcqSFYl86f0xTThv7t1F+52TIyS PmSaDMXdN26Pldeitbx1Zb44FpryQJs/SmdjD6DlmZb15jTsbXBaqI/UKpTEPK64Ut1f 0he1GmrjMrG49I+ou/DJuS+YO/BvG5lnQhyO3hi1azPwrACXA+eBs6TqfwQCScBQVgxc q9Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698944299; x=1699549099; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DfyS21pSAaN9Ul5DPXfGOsxbkU+EJCrhzTnYRsGJibU=; b=FHPWSmLRy2JvA8U9oRb/HFnXr9OX0E3072u9fY0E1qsVBhT5kW1TikqTVQaEl1gxr+ 0aVgGg5cBQAeX/ndm6cGb2fAVPcUnNKk36GcKka8rinbWP+nXXmhmXG3Z6Mr2p6KTeZD x3tjacULwB4nyyJg4iTgNgFtYoWDT2iydTZGVtddl1SmUIveVieKrjhMDKz1F1/TaarJ 5vCB0YtTzetUSZ+oFSTN21L3jiP2hsZUBbJ6ESqEvTFMhEbPwVeUzaS7p9Tvvvkj3tsI mt++qDLTxMrdNxN2Do/vq1kZwW6XhLEivHRPKK6BPnUOF96JZlG3TIfE9HVZH3kzA7UZ 4x2g== X-Gm-Message-State: AOJu0YyAsVYdF93uXHOK9KvUrLcxYARA0ucu+eyEKZMx51d5iv0AFtIJ 07IbsBgk4OYXXIG5pBrQcY0S X-Google-Smtp-Source: AGHT+IGcPZMPmb6P3crHIYT6MoFFJH19w/pybMCanZfpyJq0eFqq7TsGozYLDzAec+P33O2PTiZXzg== X-Received: by 2002:a05:6808:209f:b0:3ad:fe8d:dfae with SMTP id s31-20020a056808209f00b003adfe8ddfaemr20056494oiw.57.1698944298897; Thu, 02 Nov 2023 09:58:18 -0700 (PDT) Received: from thinkpad ([117.217.189.228]) by smtp.gmail.com with ESMTPSA id z26-20020a05620a08da00b0077263636a95sm89742qkz.93.2023.11.02.09.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 09:58:18 -0700 (PDT) Date: Thu, 2 Nov 2023 22:28:08 +0530 From: Manivannan Sadhasivam To: Frank Li Subject: Re: [PATCH v3 1/4] PCI: layerscape: Add function pointer for exit_from_l2() Message-ID: <20231102165808.GC20943@thinkpad> References: <20231017193145.3198380-1-Frank.Li@nxp.com> <20231017193145.3198380-2-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231017193145.3198380-2-Frank.Li@nxp.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imx@lists.linux.dev, kw@linux.com, linux-pci@vger.kernel.org, lpieralisi@kernel.org, linux-kernel@vger.kernel.org, minghuan.Lian@nxp.com, mingkai.hu@nxp.com, roy.zang@nxp.com, bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org, robh@kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Oct 17, 2023 at 03:31:42PM -0400, Frank Li wrote: > Since difference SoCs require different sequence for exiting L2, let's add > a separate "exit_from_l2()" callback. This callback can be used to execute > SoC specific sequence. > I missed the fact that this patch honors the return value of the callback (which was ignored previously). So this should be added to the description as well. > Signed-off-by: Frank Li With that, Reviewed-by: Manivannan Sadhasivam - Mani > --- > > Notes: > Change from v2 to v3 > - fixed according to mani's feedback > 1. update commit message > 2. move dw_pcie_host_ops to next patch > 3. check return value from exit_from_l2() > Change from v1 to v2 > - change subject 'a' to 'A' > > Change from v1 to v2 > - change subject 'a' to 'A' > > drivers/pci/controller/dwc/pci-layerscape.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c > index 37956e09c65bd..aea89926bcc4f 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape.c > +++ b/drivers/pci/controller/dwc/pci-layerscape.c > @@ -39,6 +39,7 @@ > > struct ls_pcie_drvdata { > const u32 pf_off; > + int (*exit_from_l2)(struct dw_pcie_rp *pp); > bool pm_support; > }; > > @@ -125,7 +126,7 @@ static void ls_pcie_send_turnoff_msg(struct dw_pcie_rp *pp) > dev_err(pcie->pci->dev, "PME_Turn_off timeout\n"); > } > > -static void ls_pcie_exit_from_l2(struct dw_pcie_rp *pp) > +static int ls_pcie_exit_from_l2(struct dw_pcie_rp *pp) > { > struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > struct ls_pcie *pcie = to_ls_pcie(pci); > @@ -150,6 +151,8 @@ static void ls_pcie_exit_from_l2(struct dw_pcie_rp *pp) > 10000); > if (ret) > dev_err(pcie->pci->dev, "L2 exit timeout\n"); > + > + return ret; > } > > static int ls_pcie_host_init(struct dw_pcie_rp *pp) > @@ -180,6 +183,7 @@ static const struct ls_pcie_drvdata ls1021a_drvdata = { > static const struct ls_pcie_drvdata layerscape_drvdata = { > .pf_off = 0xc0000, > .pm_support = true, > + .exit_from_l2 = ls_pcie_exit_from_l2, > }; > > static const struct of_device_id ls_pcie_of_match[] = { > @@ -247,11 +251,14 @@ static int ls_pcie_suspend_noirq(struct device *dev) > static int ls_pcie_resume_noirq(struct device *dev) > { > struct ls_pcie *pcie = dev_get_drvdata(dev); > + int ret; > > if (!pcie->drvdata->pm_support) > return 0; > > - ls_pcie_exit_from_l2(&pcie->pci->pp); > + ret = pcie->drvdata->exit_from_l2(&pcie->pci->pp); > + if (ret) > + return ret; > > return dw_pcie_resume_noirq(pcie->pci); > } > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE639C4332F for ; Thu, 2 Nov 2023 16:59:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hWJzWCoT2cidae7tz02Ciml0g/c9lwOWsCtKp39xfPI=; b=OEqKVWzreCKBf3 GPnaX5exYMF4PXUT4kB9ge5bckslDn9iF0AiCGEqMHLBXI3ICie7F+qcX4h0Ti/1pCCPdfZwMJ8iy zm5H/BoGfnpwoh5+c+WRz1w9HpElrBJTYc88wLAfwfgCcQFeKSwLWfloRwDfCRyqryw1RlBxzHfJA 6EN17jEL+S72/0LlRAkzNo2qFhySptjOMiWJ7vM2oafIVPvEgsMSNs3CKAXkEOtlBKk0P8jumBe9y a0+TBdk+h29c7Tfk5Y9HVeSlb3ch1EyfGb1li9rWQGUrE9Q3nqww2S62tAnNI0UisXniPoKFL1UV6 gfbsObSf0+uRwZHYMksg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qyb1V-009vq8-2t; Thu, 02 Nov 2023 16:58:25 +0000 Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qyb1Q-009vog-2A for linux-arm-kernel@lists.infradead.org; Thu, 02 Nov 2023 16:58:24 +0000 Received: by mail-oi1-x229.google.com with SMTP id 5614622812f47-3add37de892so652551b6e.1 for ; Thu, 02 Nov 2023 09:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698944299; x=1699549099; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=DfyS21pSAaN9Ul5DPXfGOsxbkU+EJCrhzTnYRsGJibU=; b=BjZ54tFr5vO1M5vdipcD2MlmjzdYq4FJeVi91bshRHBQGKtflZ0Z7M7rdQvTzzVkXo NtLWLHndQf5NdEFXzZvNtb3bBI3YWybQ29AEup/hUlsUdCuKKc3RyrlUoyL57z13E6wE xHsXCHsxrb+PNUL1M2efnsknZmHwe5V2MMHT0S4Go2G+cDqOEqwpU64748Tutg6Tzcko PtNIU8jQ3JhyUAcBbhw1WIwgefIDnZgFaDXV298VFKv8zk3wI6Y5yif98+wg2M4nMT9Y F1DyL93hYTosOxm/5SpOjN1E1pGPyrR5VuHgRO5b4NA6cQZFc8Xb7fB+K4hd4MTj+OqS EO5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698944299; x=1699549099; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DfyS21pSAaN9Ul5DPXfGOsxbkU+EJCrhzTnYRsGJibU=; b=RmnpcAFlTS1JNdgcpaGWwL9KEkJUFxveLkD2nlZX415fMqMg7IRgvsLEB0u9ZfDJXK D/oHsr8asyW/S47pcdR1Qnef/2LahsQzu/HxO6R+5uUQ9Vn2z4hxubKS2qnc7Fj7BH8L RkY4e9bpszZ8xtWiXYM3vUAdeZUDWKDfp7072g5jH7yN1ClgLC0c20g3ITXeepmamNeg zaX2P8AfGMsiB3aV05PyGwpqtbyh9pX+vrZrk09C5UsJTGUXbx6o0qGEUS0mm2O+m3PL XCXjP8m5rpmcXQqX9A+tC5l1u0bhxSg7NqHRhvvs6Y4YAn2QTnwK8Evv48HZOfY7x3sI E+cg== X-Gm-Message-State: AOJu0Yx+HGasHayzDkHVPlaDPoBxx5hk9tQyiqruondcfwmMRuUOu2um WbHQVsllRjHVHhw/O+674XyC X-Google-Smtp-Source: AGHT+IGcPZMPmb6P3crHIYT6MoFFJH19w/pybMCanZfpyJq0eFqq7TsGozYLDzAec+P33O2PTiZXzg== X-Received: by 2002:a05:6808:209f:b0:3ad:fe8d:dfae with SMTP id s31-20020a056808209f00b003adfe8ddfaemr20056494oiw.57.1698944298897; Thu, 02 Nov 2023 09:58:18 -0700 (PDT) Received: from thinkpad ([117.217.189.228]) by smtp.gmail.com with ESMTPSA id z26-20020a05620a08da00b0077263636a95sm89742qkz.93.2023.11.02.09.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 09:58:18 -0700 (PDT) Date: Thu, 2 Nov 2023 22:28:08 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: bhelgaas@google.com, imx@lists.linux.dev, kw@linux.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, lpieralisi@kernel.org, minghuan.Lian@nxp.com, mingkai.hu@nxp.com, robh@kernel.org, roy.zang@nxp.com Subject: Re: [PATCH v3 1/4] PCI: layerscape: Add function pointer for exit_from_l2() Message-ID: <20231102165808.GC20943@thinkpad> References: <20231017193145.3198380-1-Frank.Li@nxp.com> <20231017193145.3198380-2-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231017193145.3198380-2-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231102_095820_756987_600D307F X-CRM114-Status: GOOD ( 23.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBPY3QgMTcsIDIwMjMgYXQgMDM6MzE6NDJQTSAtMDQwMCwgRnJhbmsgTGkgd3JvdGU6 Cj4gU2luY2UgZGlmZmVyZW5jZSBTb0NzIHJlcXVpcmUgZGlmZmVyZW50IHNlcXVlbmNlIGZvciBl eGl0aW5nIEwyLCBsZXQncyBhZGQKPiBhIHNlcGFyYXRlICJleGl0X2Zyb21fbDIoKSIgY2FsbGJh Y2suIFRoaXMgY2FsbGJhY2sgY2FuIGJlIHVzZWQgdG8gZXhlY3V0ZQo+IFNvQyBzcGVjaWZpYyBz ZXF1ZW5jZS4KPiAKCkkgbWlzc2VkIHRoZSBmYWN0IHRoYXQgdGhpcyBwYXRjaCBob25vcnMgdGhl IHJldHVybiB2YWx1ZSBvZiB0aGUgY2FsbGJhY2sgKHdoaWNoCndhcyBpZ25vcmVkIHByZXZpb3Vz bHkpLiBTbyB0aGlzIHNob3VsZCBiZSBhZGRlZCB0byB0aGUgZGVzY3JpcHRpb24gYXMgd2VsbC4K Cj4gU2lnbmVkLW9mZi1ieTogRnJhbmsgTGkgPEZyYW5rLkxpQG54cC5jb20+CgpXaXRoIHRoYXQs CgpSZXZpZXdlZC1ieTogTWFuaXZhbm5hbiBTYWRoYXNpdmFtIDxtYW5pdmFubmFuLnNhZGhhc2l2 YW1AbGluYXJvLm9yZz4KCi0gTWFuaQoKPiAtLS0KPiAKPiBOb3RlczoKPiAgICAgQ2hhbmdlIGZy b20gdjIgdG8gdjMKPiAgICAgLSBmaXhlZCBhY2NvcmRpbmcgdG8gbWFuaSdzIGZlZWRiYWNrCj4g ICAgICAgMS4gdXBkYXRlIGNvbW1pdCBtZXNzYWdlCj4gICAgICAgMi4gbW92ZSBkd19wY2llX2hv c3Rfb3BzIHRvIG5leHQgcGF0Y2gKPiAgICAgICAzLiBjaGVjayByZXR1cm4gdmFsdWUgZnJvbSBl eGl0X2Zyb21fbDIoKQo+ICAgICBDaGFuZ2UgZnJvbSB2MSB0byB2Mgo+ICAgICAtIGNoYW5nZSBz dWJqZWN0ICdhJyB0byAnQScKPiAgICAgCj4gICAgIENoYW5nZSBmcm9tIHYxIHRvIHYyCj4gICAg IC0gY2hhbmdlIHN1YmplY3QgJ2EnIHRvICdBJwo+IAo+ICBkcml2ZXJzL3BjaS9jb250cm9sbGVy L2R3Yy9wY2ktbGF5ZXJzY2FwZS5jIHwgMTEgKysrKysrKysrLS0KPiAgMSBmaWxlIGNoYW5nZWQs IDkgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWxheWVyc2NhcGUuYyBiL2RyaXZlcnMvcGNpL2NvbnRy b2xsZXIvZHdjL3BjaS1sYXllcnNjYXBlLmMKPiBpbmRleCAzNzk1NmUwOWM2NWJkLi5hZWE4OTky NmJjYzRmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1sYXll cnNjYXBlLmMKPiArKysgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktbGF5ZXJzY2Fw ZS5jCj4gQEAgLTM5LDYgKzM5LDcgQEAKPiAgCj4gIHN0cnVjdCBsc19wY2llX2RydmRhdGEgewo+ ICAJY29uc3QgdTMyIHBmX29mZjsKPiArCWludCAoKmV4aXRfZnJvbV9sMikoc3RydWN0IGR3X3Bj aWVfcnAgKnBwKTsKPiAgCWJvb2wgcG1fc3VwcG9ydDsKPiAgfTsKPiAgCj4gQEAgLTEyNSw3ICsx MjYsNyBAQCBzdGF0aWMgdm9pZCBsc19wY2llX3NlbmRfdHVybm9mZl9tc2coc3RydWN0IGR3X3Bj aWVfcnAgKnBwKQo+ICAJCWRldl9lcnIocGNpZS0+cGNpLT5kZXYsICJQTUVfVHVybl9vZmYgdGlt ZW91dFxuIik7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIGxzX3BjaWVfZXhpdF9mcm9tX2wyKHN0 cnVjdCBkd19wY2llX3JwICpwcCkKPiArc3RhdGljIGludCBsc19wY2llX2V4aXRfZnJvbV9sMihz dHJ1Y3QgZHdfcGNpZV9ycCAqcHApCj4gIHsKPiAgCXN0cnVjdCBkd19wY2llICpwY2kgPSB0b19k d19wY2llX2Zyb21fcHAocHApOwo+ICAJc3RydWN0IGxzX3BjaWUgKnBjaWUgPSB0b19sc19wY2ll KHBjaSk7Cj4gQEAgLTE1MCw2ICsxNTEsOCBAQCBzdGF0aWMgdm9pZCBsc19wY2llX2V4aXRfZnJv bV9sMihzdHJ1Y3QgZHdfcGNpZV9ycCAqcHApCj4gIAkJCQkgMTAwMDApOwo+ICAJaWYgKHJldCkK PiAgCQlkZXZfZXJyKHBjaWUtPnBjaS0+ZGV2LCAiTDIgZXhpdCB0aW1lb3V0XG4iKTsKPiArCj4g KwlyZXR1cm4gcmV0Owo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IGxzX3BjaWVfaG9zdF9pbml0KHN0 cnVjdCBkd19wY2llX3JwICpwcCkKPiBAQCAtMTgwLDYgKzE4Myw3IEBAIHN0YXRpYyBjb25zdCBz dHJ1Y3QgbHNfcGNpZV9kcnZkYXRhIGxzMTAyMWFfZHJ2ZGF0YSA9IHsKPiAgc3RhdGljIGNvbnN0 IHN0cnVjdCBsc19wY2llX2RydmRhdGEgbGF5ZXJzY2FwZV9kcnZkYXRhID0gewo+ICAJLnBmX29m ZiA9IDB4YzAwMDAsCj4gIAkucG1fc3VwcG9ydCA9IHRydWUsCj4gKwkuZXhpdF9mcm9tX2wyID0g bHNfcGNpZV9leGl0X2Zyb21fbDIsCj4gIH07Cj4gIAo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IG9m X2RldmljZV9pZCBsc19wY2llX29mX21hdGNoW10gPSB7Cj4gQEAgLTI0NywxMSArMjUxLDE0IEBA IHN0YXRpYyBpbnQgbHNfcGNpZV9zdXNwZW5kX25vaXJxKHN0cnVjdCBkZXZpY2UgKmRldikKPiAg c3RhdGljIGludCBsc19wY2llX3Jlc3VtZV9ub2lycShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gIHsK PiAgCXN0cnVjdCBsc19wY2llICpwY2llID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gKwlpbnQg cmV0Owo+ICAKPiAgCWlmICghcGNpZS0+ZHJ2ZGF0YS0+cG1fc3VwcG9ydCkKPiAgCQlyZXR1cm4g MDsKPiAgCj4gLQlsc19wY2llX2V4aXRfZnJvbV9sMigmcGNpZS0+cGNpLT5wcCk7Cj4gKwlyZXQg PSBwY2llLT5kcnZkYXRhLT5leGl0X2Zyb21fbDIoJnBjaWUtPnBjaS0+cHApOwo+ICsJaWYgKHJl dCkKPiArCQlyZXR1cm4gcmV0Owo+ICAKPiAgCXJldHVybiBkd19wY2llX3Jlc3VtZV9ub2lycShw Y2llLT5wY2kpOwo+ICB9Cj4gLS0gCj4gMi4zNC4xCj4gCgotLSAK4K6u4K6j4K6/4K614K6j4K+N 4K6j4K6p4K+NIOCumuCupOCuvuCumuCuv+CuteCuruCvjQoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=