From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A34020317 for ; Thu, 2 Nov 2023 17:39:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n1loOI1U" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-77784edc2edso67887985a.1 for ; Thu, 02 Nov 2023 10:39:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698946751; x=1699551551; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=yE6hYq/1M2NiVA4RY0gsdXB7HPtKFRVy440CKIJ1q9I=; b=n1loOI1Uhst9wsHzGZE4qqYETU1HrIGCGNC9ZTKGtx3ExX7nZfiTN6iEHPyUVqrjsh rgByibA8NBYmUQjMqi7086rLBHq1+hCDdyMjA/jEI2byM4IODe5CtNYQ/FbQfPaWmOvL 51OcurMDQpR+ipySpDRo90XiParOBy0AJGqlNe9wceBAS/nNBCOVfh89nffIXGUI6Bj9 BP43McdgJx+L9huAQz7TIx/DpPkX2JxVp7gxxm/eGNa67W2oiK8LYJpXTlaSaPKjE/d4 fgYGqYJJAxAf/CdAqDtywvwjwbJdXVc8SgMp4WGDUS7JV3HuUeB8Nn+6AtWdQEWYUtV/ BPhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698946751; x=1699551551; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yE6hYq/1M2NiVA4RY0gsdXB7HPtKFRVy440CKIJ1q9I=; b=Vc5zFgBP50JGF+v1uTPqi5XECXkmFMfgxThbYL1LJmiabZJM3rpna1OzvSaco38qYj 1Ad2Z1U8DTh9B9MC5A3MEwNU2uBq5ZD9OwRTNmOAG3HfnKGVaTIbXEL3IXmPXR6UbFja j2kVFl+0Sf3XEbOwXMrlA2+PDZ9riXJDQCbr6fILupcg8jPvJdFLkPKc7qphpryB/Wct MwVw/w2JKNg4irrQisZZWuxllnQ+sOALMxzO0kyXQCt5IspiRDbjYHYYhUEvQIDV08Gj UV2Kdm24Z73C5yaTuTVeCBaxrTb38SvGHgrlm0fufJIJW8tbPC5lLt2AcUOvyJu1srTK rFPg== X-Gm-Message-State: AOJu0YxR3P8Y4ShP1+43rY/RWszYxaBGF8Eb3pI/NJQtRLpBs0pWZKxM 7qjWA9pupCq+jRz/P50NHCVC X-Google-Smtp-Source: AGHT+IGJE7PRlsHRJBiWTBzJ7qskCfmYJqaSK0LlSGhhJCTuiYGeWOKAeIpbrsnv82Z6K6JfC4NtgA== X-Received: by 2002:a05:620a:2045:b0:779:d143:c1a7 with SMTP id d5-20020a05620a204500b00779d143c1a7mr18609776qka.26.1698946750692; Thu, 02 Nov 2023 10:39:10 -0700 (PDT) Received: from thinkpad ([117.217.189.228]) by smtp.gmail.com with ESMTPSA id bk2-20020a05620a1a0200b0076e672f535asm127918qkb.57.2023.11.02.10.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 10:39:10 -0700 (PDT) Date: Thu, 2 Nov 2023 23:09:00 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: bhelgaas@google.com, imx@lists.linux.dev, kw@linux.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, lpieralisi@kernel.org, minghuan.Lian@nxp.com, mingkai.hu@nxp.com, robh@kernel.org, roy.zang@nxp.com Subject: Re: [PATCH v3 4/4] PCI: layerscape: Add suspend/resume for ls1043a Message-ID: <20231102173900.GF20943@thinkpad> References: <20231017193145.3198380-1-Frank.Li@nxp.com> <20231017193145.3198380-5-Frank.Li@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231017193145.3198380-5-Frank.Li@nxp.com> On Tue, Oct 17, 2023 at 03:31:45PM -0400, Frank Li wrote: > ls1043a add suspend/resume support. > Implement ls1043a_pcie_send_turnoff_msg() to send PME_Turn_Off message. > Implement ls1043a_pcie_exit_from_l2() to exit from L2 state. > Please use the suggestion I gave in patch 2/4. > Signed-off-by: Frank Li > --- > > Notes: > Change from v2 to v3 > - Remove ls_pcie_lut_readl(writel) function > > Change from v1 to v2 > - Update subject 'a' to 'A' > > drivers/pci/controller/dwc/pci-layerscape.c | 86 ++++++++++++++++++++- > 1 file changed, 85 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c > index 4b663b20d8612..9656224960b0c 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape.c > +++ b/drivers/pci/controller/dwc/pci-layerscape.c > @@ -41,6 +41,15 @@ > #define SCFG_PEXSFTRSTCR 0x190 > #define PEXSR(idx) BIT(idx) > > +/* LS1043A PEX PME control register */ > +#define SCFG_PEXPMECR 0x144 > +#define PEXPME(idx) BIT(31 - (idx) * 4) > + > +/* LS1043A PEX LUT debug register */ > +#define LS_PCIE_LDBG 0x7fc > +#define LDBG_SR BIT(30) > +#define LDBG_WE BIT(31) > + > #define PCIE_IATU_NUM 6 > > #define LS_PCIE_DRV_SCFG BIT(0) > @@ -227,6 +236,68 @@ static int ls1021a_pcie_exit_from_l2(struct dw_pcie_rp *pp) > return 0; > } > > +static void ls1043a_pcie_send_turnoff_msg(struct dw_pcie_rp *pp) > +{ > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + struct ls_pcie *pcie = to_ls_pcie(pci); > + u32 val; > + > + if (!pcie->scfg) { > + dev_dbg(pcie->pci->dev, "SYSCFG is NULL\n"); > + return; > + } Why scfg is optional for this SoC and not for the other one added in patch 2/4? > + > + /* Send Turn_off message */ > + regmap_read(pcie->scfg, SCFG_PEXPMECR, &val); > + val |= PEXPME(pcie->index); > + regmap_write(pcie->scfg, SCFG_PEXPMECR, val); > + In my previous review, I asked you to use a common function and just pass the offsets, as the sequence is same for both the SoCs. But you ignored it :/ > + /* > + * There is no specific register to check for PME_To_Ack from endpoint. > + * So on the safe side, wait for PCIE_PME_TO_L2_TIMEOUT_US. > + */ > + mdelay(PCIE_PME_TO_L2_TIMEOUT_US/1000); > + > + /* > + * Layerscape hardware reference manual recommends clearing the PMXMTTURNOFF bit > + * to complete the PME_Turn_Off handshake. > + */ > + regmap_read(pcie->scfg, SCFG_PEXPMECR, &val); > + val &= ~PEXPME(pcie->index); > + regmap_write(pcie->scfg, SCFG_PEXPMECR, val); > +} > + > +static int ls1043a_pcie_exit_from_l2(struct dw_pcie_rp *pp) > +{ > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + struct ls_pcie *pcie = to_ls_pcie(pci); > + u32 val; > + > + /* > + * Only way let PEX module exit L2 is do a software reset. Same comment applies as patch 2/4. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B993C4167B for ; Thu, 2 Nov 2023 17:40:09 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=CEErf7JI; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SLrjz6h6Kz3ccf for ; Fri, 3 Nov 2023 04:40:07 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=CEErf7JI; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::732; helo=mail-qk1-x732.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=lists.ozlabs.org) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SLrhz1Gx2z3cVr for ; Fri, 3 Nov 2023 04:39:14 +1100 (AEDT) Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-7789577b53fso66239585a.3 for ; Thu, 02 Nov 2023 10:39:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698946751; x=1699551551; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=yE6hYq/1M2NiVA4RY0gsdXB7HPtKFRVy440CKIJ1q9I=; b=CEErf7JIV0JXuMUuxlBQ/KeBUYMVscuJC9SRvev3zLZDyY95zrYNp5HMAFEh5AhVxY SoxR7vX3oOFjwK7VtB7DELyDmPw1WdtfH+486+bZ3DPTHAXqUgAIwtx/2spZRQLoFHVW 1f4EB8HuBnyETumyzQDG1yStmwgQB/9nnsv0yQclCDQxSu77V4PNM10/gd5RosZmYN5w 4h3jkMovNhGURTUZ+o81IWoiuTQbIujXLeyOfMg+sHeE5p4LjWbv2sGEKkTVlu/nYSHE DCWOGISIbLH/guzRwd0mvTMJzCn8jTtWzaHe+G7ylbNQ4G8SqzY6q45EL+jerf2RH0i+ fKUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698946751; x=1699551551; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yE6hYq/1M2NiVA4RY0gsdXB7HPtKFRVy440CKIJ1q9I=; b=ka4+d3w2uxnOV5EZkvVUjLBYaXI8vGl0Nld+m5iehn5BNyXda8z0eVYOGAYe+0OpSW iXsm/zGUnXhMKIVYjwyKq+kzCpgVO09+LaKKHiIDRTMnw91HNa1ytgbKGVfr0l2ddkRW aLCVDnxTPW0wt5HQS3fj4pPYwG2IHqOiBHNwVcwAYda/453bL0dsoYnckkx0ugqk8Ivs DXJQC4ZS7Edzknm0DuCsRysQ2a6BpbC/NJe+sxnITGr3VFhjpRCKxxQEglRqa08yHoHF sNNKlR/i85vla4HqdBe0XB9IzwJDQld5p9bkkcPzbw5KsFOF+2xbRovtdqUhr5LgAUfS hKgQ== X-Gm-Message-State: AOJu0YwBBA4QRaG7Pqz3KLYsxX03XHsVZfULul4+fcHzSTpKoPCSbtix exrrtNj0gDkGzhTV3Bge0HT4 X-Google-Smtp-Source: AGHT+IGJE7PRlsHRJBiWTBzJ7qskCfmYJqaSK0LlSGhhJCTuiYGeWOKAeIpbrsnv82Z6K6JfC4NtgA== X-Received: by 2002:a05:620a:2045:b0:779:d143:c1a7 with SMTP id d5-20020a05620a204500b00779d143c1a7mr18609776qka.26.1698946750692; Thu, 02 Nov 2023 10:39:10 -0700 (PDT) Received: from thinkpad ([117.217.189.228]) by smtp.gmail.com with ESMTPSA id bk2-20020a05620a1a0200b0076e672f535asm127918qkb.57.2023.11.02.10.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 10:39:10 -0700 (PDT) Date: Thu, 2 Nov 2023 23:09:00 +0530 From: Manivannan Sadhasivam To: Frank Li Subject: Re: [PATCH v3 4/4] PCI: layerscape: Add suspend/resume for ls1043a Message-ID: <20231102173900.GF20943@thinkpad> References: <20231017193145.3198380-1-Frank.Li@nxp.com> <20231017193145.3198380-5-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231017193145.3198380-5-Frank.Li@nxp.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imx@lists.linux.dev, kw@linux.com, linux-pci@vger.kernel.org, lpieralisi@kernel.org, linux-kernel@vger.kernel.org, minghuan.Lian@nxp.com, mingkai.hu@nxp.com, roy.zang@nxp.com, bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org, robh@kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Oct 17, 2023 at 03:31:45PM -0400, Frank Li wrote: > ls1043a add suspend/resume support. > Implement ls1043a_pcie_send_turnoff_msg() to send PME_Turn_Off message. > Implement ls1043a_pcie_exit_from_l2() to exit from L2 state. > Please use the suggestion I gave in patch 2/4. > Signed-off-by: Frank Li > --- > > Notes: > Change from v2 to v3 > - Remove ls_pcie_lut_readl(writel) function > > Change from v1 to v2 > - Update subject 'a' to 'A' > > drivers/pci/controller/dwc/pci-layerscape.c | 86 ++++++++++++++++++++- > 1 file changed, 85 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c > index 4b663b20d8612..9656224960b0c 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape.c > +++ b/drivers/pci/controller/dwc/pci-layerscape.c > @@ -41,6 +41,15 @@ > #define SCFG_PEXSFTRSTCR 0x190 > #define PEXSR(idx) BIT(idx) > > +/* LS1043A PEX PME control register */ > +#define SCFG_PEXPMECR 0x144 > +#define PEXPME(idx) BIT(31 - (idx) * 4) > + > +/* LS1043A PEX LUT debug register */ > +#define LS_PCIE_LDBG 0x7fc > +#define LDBG_SR BIT(30) > +#define LDBG_WE BIT(31) > + > #define PCIE_IATU_NUM 6 > > #define LS_PCIE_DRV_SCFG BIT(0) > @@ -227,6 +236,68 @@ static int ls1021a_pcie_exit_from_l2(struct dw_pcie_rp *pp) > return 0; > } > > +static void ls1043a_pcie_send_turnoff_msg(struct dw_pcie_rp *pp) > +{ > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + struct ls_pcie *pcie = to_ls_pcie(pci); > + u32 val; > + > + if (!pcie->scfg) { > + dev_dbg(pcie->pci->dev, "SYSCFG is NULL\n"); > + return; > + } Why scfg is optional for this SoC and not for the other one added in patch 2/4? > + > + /* Send Turn_off message */ > + regmap_read(pcie->scfg, SCFG_PEXPMECR, &val); > + val |= PEXPME(pcie->index); > + regmap_write(pcie->scfg, SCFG_PEXPMECR, val); > + In my previous review, I asked you to use a common function and just pass the offsets, as the sequence is same for both the SoCs. But you ignored it :/ > + /* > + * There is no specific register to check for PME_To_Ack from endpoint. > + * So on the safe side, wait for PCIE_PME_TO_L2_TIMEOUT_US. > + */ > + mdelay(PCIE_PME_TO_L2_TIMEOUT_US/1000); > + > + /* > + * Layerscape hardware reference manual recommends clearing the PMXMTTURNOFF bit > + * to complete the PME_Turn_Off handshake. > + */ > + regmap_read(pcie->scfg, SCFG_PEXPMECR, &val); > + val &= ~PEXPME(pcie->index); > + regmap_write(pcie->scfg, SCFG_PEXPMECR, val); > +} > + > +static int ls1043a_pcie_exit_from_l2(struct dw_pcie_rp *pp) > +{ > + struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > + struct ls_pcie *pcie = to_ls_pcie(pci); > + u32 val; > + > + /* > + * Only way let PEX module exit L2 is do a software reset. Same comment applies as patch 2/4. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 663BBC4332F for ; Thu, 2 Nov 2023 17:39:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YT4NZNOQto7rBqu+XPSCCDxNxiQ3xS2sXpcSzkDBANk=; b=MEfSSyFKVH7Z34 w/5thLNLoDy12ab0QzGVAjSMzMv8Ql3+O+FqE6hT0CptQNw1wLwFU8EHrdEcfAZOtR05A3RqO+5Nh ZMYxXd6a2VhThn+nHXxxxiGI1bkUZMZFRJ/tC4spAo1DsGTzge/6Wy+0j8znx0eO8XkAQGhmcE5QG Zz0GN1QEuqzja/iYJg4m6DhCjKP21rJJ08CE5b6LyFPBXOn5Ry8+971TYIMHmAetkOSZAb0iYE1du PnYFY9g7x2EaJ3sovXaYo7QskiLt4e2YZM5WiEtqw3nLJbMnx6TCJGOtz8f8IFVLD12gUhJMDCMlo vMFGp+nQYj+8uFh4m0dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qybf3-009zmb-1U; Thu, 02 Nov 2023 17:39:17 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qybex-009zlM-2t for linux-arm-kernel@lists.infradead.org; Thu, 02 Nov 2023 17:39:15 +0000 Received: by mail-qk1-x72f.google.com with SMTP id af79cd13be357-779fb118fe4so66459185a.2 for ; Thu, 02 Nov 2023 10:39:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698946751; x=1699551551; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=yE6hYq/1M2NiVA4RY0gsdXB7HPtKFRVy440CKIJ1q9I=; b=fynJIVNgG3RUvwrIZZhPDbBrrXPWImsq5TThp/Cui/12AhbP4QZW77NF/HEP4yMCoj WP3n2xLZrQe8+jVr4T2ZT/D86jF2KlNSu7nRPKFkjOnN59OHkqReTLwCI9F6y9nvYgbf NsKDU+fY6LzgzlU2wpFU3An1tFATIqvns0QD5GVAHOadvY55LsAp9imABcoMI/Q+DpOk odanvoUGgVRpUodH7O+unR0bwrfUsXEQ4/ncCboqCpImifWl1w4fhH3kfypVSVfVudup KsGPluyCcUxvFr6i2ZTzzOXR4e+JespyqxqoPjYCDewq6kvS4Ctc1fCFfuMZefqObMaA UHPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698946751; x=1699551551; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yE6hYq/1M2NiVA4RY0gsdXB7HPtKFRVy440CKIJ1q9I=; b=Tc8FtjRWIM7JfxXTxHoDUXqmMV9oztd0nZV3MwcQ0jx2xHG2eecMamDJP1xPMxJVGI im7gmndzzaOHNP2dbxGqUVlFrUrE+xDPf+qvPfzpKfF7FGha16HD3f1iM2390YffmVjz ySziBAkzjeYuUsCOZbRC43fNA3S6sud9F3wdxKjS2+sGTZSv3VXPGohttxhaFsfrGXs9 hfnmDkCj1Jrl5E/VBrrgfDpeCPTws3qSaXVbB8gy+RTOpOHg2c37DIru41mfCxWWhFxl MPxfMsLeC0P/VHVFPZT0Fm0BgT/dQOoITHQVQkxW1506vDi9JUsdwhg8NxvvAQtcTn96 jCVg== X-Gm-Message-State: AOJu0YxRu3GJGxkoZqf0JhEVrjhss85FEwyhKGn/nxvcHAU7sIxJ3vUi YNvBQs0+m8Gmza52ywuutFaW X-Google-Smtp-Source: AGHT+IGJE7PRlsHRJBiWTBzJ7qskCfmYJqaSK0LlSGhhJCTuiYGeWOKAeIpbrsnv82Z6K6JfC4NtgA== X-Received: by 2002:a05:620a:2045:b0:779:d143:c1a7 with SMTP id d5-20020a05620a204500b00779d143c1a7mr18609776qka.26.1698946750692; Thu, 02 Nov 2023 10:39:10 -0700 (PDT) Received: from thinkpad ([117.217.189.228]) by smtp.gmail.com with ESMTPSA id bk2-20020a05620a1a0200b0076e672f535asm127918qkb.57.2023.11.02.10.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 10:39:10 -0700 (PDT) Date: Thu, 2 Nov 2023 23:09:00 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: bhelgaas@google.com, imx@lists.linux.dev, kw@linux.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, lpieralisi@kernel.org, minghuan.Lian@nxp.com, mingkai.hu@nxp.com, robh@kernel.org, roy.zang@nxp.com Subject: Re: [PATCH v3 4/4] PCI: layerscape: Add suspend/resume for ls1043a Message-ID: <20231102173900.GF20943@thinkpad> References: <20231017193145.3198380-1-Frank.Li@nxp.com> <20231017193145.3198380-5-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231017193145.3198380-5-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231102_103911_940869_0FCD3130 X-CRM114-Status: GOOD ( 25.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBPY3QgMTcsIDIwMjMgYXQgMDM6MzE6NDVQTSAtMDQwMCwgRnJhbmsgTGkgd3JvdGU6 Cj4gbHMxMDQzYSBhZGQgc3VzcGVuZC9yZXN1bWUgc3VwcG9ydC4KPiBJbXBsZW1lbnQgbHMxMDQz YV9wY2llX3NlbmRfdHVybm9mZl9tc2coKSB0byBzZW5kIFBNRV9UdXJuX09mZiBtZXNzYWdlLgo+ IEltcGxlbWVudCBsczEwNDNhX3BjaWVfZXhpdF9mcm9tX2wyKCkgdG8gZXhpdCBmcm9tIEwyIHN0 YXRlLgo+IAoKUGxlYXNlIHVzZSB0aGUgc3VnZ2VzdGlvbiBJIGdhdmUgaW4gcGF0Y2ggMi80LgoK PiBTaWduZWQtb2ZmLWJ5OiBGcmFuayBMaSA8RnJhbmsuTGlAbnhwLmNvbT4KPiAtLS0KPiAKPiBO b3RlczoKPiAgICAgQ2hhbmdlIGZyb20gdjIgdG8gdjMKPiAgICAgLSBSZW1vdmUgbHNfcGNpZV9s dXRfcmVhZGwod3JpdGVsKSBmdW5jdGlvbgo+ICAgICAKPiAgICAgQ2hhbmdlIGZyb20gdjEgdG8g djIKPiAgICAgLSBVcGRhdGUgc3ViamVjdCAnYScgdG8gJ0EnCj4gCj4gIGRyaXZlcnMvcGNpL2Nv bnRyb2xsZXIvZHdjL3BjaS1sYXllcnNjYXBlLmMgfCA4NiArKysrKysrKysrKysrKysrKysrKy0K PiAgMSBmaWxlIGNoYW5nZWQsIDg1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWxheWVyc2NhcGUuYyBi L2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1sYXllcnNjYXBlLmMKPiBpbmRleCA0YjY2 M2IyMGQ4NjEyLi45NjU2MjI0OTYwYjBjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGNpL2NvbnRy b2xsZXIvZHdjL3BjaS1sYXllcnNjYXBlLmMKPiArKysgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVy L2R3Yy9wY2ktbGF5ZXJzY2FwZS5jCj4gQEAgLTQxLDYgKzQxLDE1IEBACj4gICNkZWZpbmUgU0NG R19QRVhTRlRSU1RDUgkweDE5MAo+ICAjZGVmaW5lIFBFWFNSKGlkeCkJCUJJVChpZHgpCj4gIAo+ ICsvKiBMUzEwNDNBIFBFWCBQTUUgY29udHJvbCByZWdpc3RlciAqLwo+ICsjZGVmaW5lIFNDRkdf UEVYUE1FQ1IJCTB4MTQ0Cj4gKyNkZWZpbmUgUEVYUE1FKGlkeCkJCUJJVCgzMSAtIChpZHgpICog NCkKPiArCj4gKy8qIExTMTA0M0EgUEVYIExVVCBkZWJ1ZyByZWdpc3RlciAqLwo+ICsjZGVmaW5l IExTX1BDSUVfTERCRwkweDdmYwo+ICsjZGVmaW5lIExEQkdfU1IJCUJJVCgzMCkKPiArI2RlZmlu ZSBMREJHX1dFCQlCSVQoMzEpCj4gKwo+ICAjZGVmaW5lIFBDSUVfSUFUVV9OVU0JCTYKPiAgCj4g ICNkZWZpbmUgTFNfUENJRV9EUlZfU0NGRwlCSVQoMCkKPiBAQCAtMjI3LDYgKzIzNiw2OCBAQCBz dGF0aWMgaW50IGxzMTAyMWFfcGNpZV9leGl0X2Zyb21fbDIoc3RydWN0IGR3X3BjaWVfcnAgKnBw KQo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkIGxzMTA0M2FfcGNpZV9zZW5k X3R1cm5vZmZfbXNnKHN0cnVjdCBkd19wY2llX3JwICpwcCkKPiArewo+ICsJc3RydWN0IGR3X3Bj aWUgKnBjaSA9IHRvX2R3X3BjaWVfZnJvbV9wcChwcCk7Cj4gKwlzdHJ1Y3QgbHNfcGNpZSAqcGNp ZSA9IHRvX2xzX3BjaWUocGNpKTsKPiArCXUzMiB2YWw7Cj4gKwo+ICsJaWYgKCFwY2llLT5zY2Zn KSB7Cj4gKwkJZGV2X2RiZyhwY2llLT5wY2ktPmRldiwgIlNZU0NGRyBpcyBOVUxMXG4iKTsKPiAr CQlyZXR1cm47Cj4gKwl9CgpXaHkgc2NmZyBpcyBvcHRpb25hbCBmb3IgdGhpcyBTb0MgYW5kIG5v dCBmb3IgdGhlIG90aGVyIG9uZSBhZGRlZCBpbiBwYXRjaCAyLzQ/Cgo+ICsKPiArCS8qIFNlbmQg VHVybl9vZmYgbWVzc2FnZSAqLwo+ICsJcmVnbWFwX3JlYWQocGNpZS0+c2NmZywgU0NGR19QRVhQ TUVDUiwgJnZhbCk7Cj4gKwl2YWwgfD0gUEVYUE1FKHBjaWUtPmluZGV4KTsKPiArCXJlZ21hcF93 cml0ZShwY2llLT5zY2ZnLCBTQ0ZHX1BFWFBNRUNSLCB2YWwpOwo+ICsKCkluIG15IHByZXZpb3Vz IHJldmlldywgSSBhc2tlZCB5b3UgdG8gdXNlIGEgY29tbW9uIGZ1bmN0aW9uIGFuZCBqdXN0IHBh c3MgdGhlCm9mZnNldHMsIGFzIHRoZSBzZXF1ZW5jZSBpcyBzYW1lIGZvciBib3RoIHRoZSBTb0Nz LiBCdXQgeW91IGlnbm9yZWQgaXQgOi8KCj4gKwkvKgo+ICsJICogVGhlcmUgaXMgbm8gc3BlY2lm aWMgcmVnaXN0ZXIgdG8gY2hlY2sgZm9yIFBNRV9Ub19BY2sgZnJvbSBlbmRwb2ludC4KPiArCSAq IFNvIG9uIHRoZSBzYWZlIHNpZGUsIHdhaXQgZm9yIFBDSUVfUE1FX1RPX0wyX1RJTUVPVVRfVVMu Cj4gKwkgKi8KPiArCW1kZWxheShQQ0lFX1BNRV9UT19MMl9USU1FT1VUX1VTLzEwMDApOwo+ICsK PiArCS8qCj4gKwkgKiBMYXllcnNjYXBlIGhhcmR3YXJlIHJlZmVyZW5jZSBtYW51YWwgcmVjb21t ZW5kcyBjbGVhcmluZyB0aGUgUE1YTVRUVVJOT0ZGIGJpdAo+ICsJICogdG8gY29tcGxldGUgdGhl IFBNRV9UdXJuX09mZiBoYW5kc2hha2UuCj4gKwkgKi8KPiArCXJlZ21hcF9yZWFkKHBjaWUtPnNj ZmcsIFNDRkdfUEVYUE1FQ1IsICZ2YWwpOwo+ICsJdmFsICY9IH5QRVhQTUUocGNpZS0+aW5kZXgp Owo+ICsJcmVnbWFwX3dyaXRlKHBjaWUtPnNjZmcsIFNDRkdfUEVYUE1FQ1IsIHZhbCk7Cj4gK30K PiArCj4gK3N0YXRpYyBpbnQgbHMxMDQzYV9wY2llX2V4aXRfZnJvbV9sMihzdHJ1Y3QgZHdfcGNp ZV9ycCAqcHApCj4gK3sKPiArCXN0cnVjdCBkd19wY2llICpwY2kgPSB0b19kd19wY2llX2Zyb21f cHAocHApOwo+ICsJc3RydWN0IGxzX3BjaWUgKnBjaWUgPSB0b19sc19wY2llKHBjaSk7Cj4gKwl1 MzIgdmFsOwo+ICsKPiArCS8qCj4gKwkgKiBPbmx5IHdheSBsZXQgUEVYIG1vZHVsZSBleGl0IEwy IGlzIGRvIGEgc29mdHdhcmUgcmVzZXQuCgpTYW1lIGNvbW1lbnQgYXBwbGllcyBhcyBwYXRjaCAy LzQuCgotIE1hbmkKCi0tIArgrq7grqPgrr/grrXgrqPgr43grqPgrqngr40g4K6a4K6k4K6+4K6a 4K6/4K614K6u4K+NCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg==