* [meta-ti][master/kirkstone][PATCH 2/8] ti-linux-fw: Make CLEANBROKEN and FILES part of common include
2023-10-25 16:56 [meta-ti][master/kirkstone][PATCH 1/8] conf: machine: Move IMAGE_BOOT_FILES to the SoC inc for J721s2 and J784s4 Andrew Davis
@ 2023-10-25 16:56 ` Andrew Davis
2023-10-25 16:56 ` [meta-ti][master/kirkstone][PATCH 3/8] ti-linux-fw: Do not set source directory when including ti-linux-fw.inc Andrew Davis
` (5 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Andrew Davis @ 2023-10-25 16:56 UTC (permalink / raw)
To: Denys Dmytriyenko, Ryan Eatmon, meta-ti; +Cc: Andrew Davis
These are common for all recipes that include ti-linux-fw.inc, add
it to this include file and remove from each recipe.
Signed-off-by: Andrew Davis <afd@ti.com>
---
.../recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb | 4 ----
meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 5 -----
meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb | 4 ----
meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb | 4 ----
meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb | 4 ----
meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb | 5 -----
meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb | 4 ----
meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb | 4 ----
meta-ti-bsp/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb | 4 ----
meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb | 4 ----
meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb | 5 -----
meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb | 5 -----
meta-ti-bsp/recipes-bsp/ti-eth-fw/ti-eth-fw.bb | 5 -----
.../recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb | 4 ----
meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc | 5 +++++
meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb | 4 ----
meta-ti-bsp/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb | 5 -----
17 files changed, 5 insertions(+), 70 deletions(-)
diff --git a/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb b/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
index 5ae0cb7c..4263e40f 100644
--- a/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
@@ -8,8 +8,6 @@ LIC_FILES_CHKSUM = "file://LICENCE.cadence;md5=009f46816f6956cfb75ede13d3e1cee0"
PV = "${CADENCE_MHDP_FW_VERSION}"
PR = "${INC_PR}.0"
-CLEANBROKEN = "1"
-
COMPATIBLE_MACHINE = "j721e|j721s2|j784s4"
PACKAGE_ARCH = "${MACHINE_ARCH}"
@@ -21,5 +19,3 @@ do_install() {
install -d ${D}${nonarch_base_libdir}/firmware/cadence
install -m 0644 ${S}/cadence/${TARGET} ${D}${nonarch_base_libdir}/firmware/cadence/${TARGET}
}
-
-FILES:${PN} = "${nonarch_base_libdir}/firmware"
diff --git a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
index a667d335..b1bc20b9 100644
--- a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
@@ -11,8 +11,6 @@ LIC_FILES_CHKSUM = "file://LICENCE.cnm;md5=93b67e6bac7f8fec22b96b8ad0a1a9d0"
PV = "${CNM_WAVE521_FW_VERSION}"
PR = "${INC_PR}.1"
-CLEANBROKEN = "1"
-
COMPATIBLE_MACHINE = "j721s2|j784s4|am62axx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
@@ -34,9 +32,6 @@ do_install() {
install -m 0644 ${S}/cnm/${SOURCE_WAVE521C} ${D}${nonarch_base_libdir}/firmware/cnm/${TARGET_WAVE521C}
}
-# make sure that lib/firmware, and all its contents are part of the package
-FILES:${PN} = "${nonarch_base_libdir}/firmware"
-
# we don't want to configure and build the source code
do_compile[noexec] = "1"
do_configure[noexec] = "1"
diff --git a/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb b/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
index 00a6e51b..5cd6e131 100644
--- a/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
@@ -8,8 +8,6 @@ LIC_FILES_CHKSUM = "file://LICENCE.Spectrum-GT9271;md5=2a6de6be7af1fe46370c684da
PV = "${GOODIX_FW_VERSION}"
PR = "${INC_PR}.0"
-CLEANBROKEN = "1"
-
COMPATIBLE_MACHINE = "dra7xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
@@ -22,5 +20,3 @@ do_install() {
install -d ${D}${nonarch_base_libdir}/firmware
install -m 0644 ${S}/ti-evm/${ORIGIN} ${D}${nonarch_base_libdir}/firmware/${TARGET}
}
-
-FILES:${PN} = "${nonarch_base_libdir}/firmware"
diff --git a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
index 28c02698..5d95beab 100644
--- a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
+++ b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
@@ -5,8 +5,6 @@ require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
PV = "${PRUETH_FW_AM65X_SR2_VERSION}"
PR = "${INC_PR}.0"
-CLEANBROKEN = "1"
-
COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
@@ -29,6 +27,4 @@ do_install() {
done
}
-FILES:${PN} = "${nonarch_base_libdir}/firmware"
-
INSANE_SKIP:${PN} = "arch"
diff --git a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
index c656ceab..f0d4d16d 100644
--- a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
+++ b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
@@ -5,8 +5,6 @@ require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
PV = "${PRUETH_FW_AM65X_VERSION}"
PR = "${INC_PR}.0"
-CLEANBROKEN = "1"
-
COMPATIBLE_MACHINE = "am65xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
@@ -27,6 +25,4 @@ do_install() {
done
}
-FILES:${PN} = "${nonarch_base_libdir}/firmware"
-
INSANE_SKIP:${PN} = "arch"
diff --git a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
index 4f298a2c..c7db85fc 100644
--- a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
+++ b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
@@ -4,8 +4,6 @@ require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
PR = "${INC_PR}.0"
-CLEANBROKEN = "1"
-
COMPATIBLE_MACHINE = "ti33x|ti43x|am57xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
@@ -24,7 +22,4 @@ do_install() {
done
}
-
-FILES:${PN} = "${nonarch_base_libdir}/firmware"
-
INSANE_SKIP:${PN} = "arch"
diff --git a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
index c31af832..12f7b729 100644
--- a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
+++ b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
@@ -5,8 +5,6 @@ require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
PV = "${PRUETH_FW_AM65X_SR2_VERSION}"
PR = "${INC_PR}.0"
-CLEANBROKEN = "1"
-
COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
@@ -29,6 +27,4 @@ do_install() {
done
}
-FILES:${PN} = "${nonarch_base_libdir}/firmware"
-
INSANE_SKIP:${PN} = "arch"
diff --git a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb
index 69ccb31a..47c272a8 100644
--- a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb
+++ b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb
@@ -5,8 +5,6 @@ require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
PE = "1"
PR = "${INC_PR}.0"
-CLEANBROKEN = "1"
-
COMPATIBLE_MACHINE = "ti33x|ti43x|am57xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
@@ -25,6 +23,4 @@ do_install() {
done
}
-FILES:${PN} = "${nonarch_base_libdir}/firmware"
-
INSANE_SKIP:${PN} = "arch"
diff --git a/meta-ti-bsp/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb b/meta-ti-bsp/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb
index f774db58..fc8e423e 100644
--- a/meta-ti-bsp/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb
+++ b/meta-ti-bsp/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb
@@ -5,8 +5,6 @@ require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
PE = "1"
PR = "${INC_PR}.0"
-CLEANBROKEN = "1"
-
COMPATIBLE_MACHINE = "ti33x|ti43x|am57xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
@@ -25,6 +23,4 @@ do_install() {
done
}
-FILES:${PN} = "${nonarch_base_libdir}/firmware"
-
INSANE_SKIP:${PN} = "arch"
diff --git a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
index e0cf2cb5..208f8764 100644
--- a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
+++ b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
@@ -5,8 +5,6 @@ require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
PV = "${PRUETH_FW_AM65X_SR2_VERSION}"
PR = "${INC_PR}.0"
-CLEANBROKEN = "1"
-
COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
@@ -29,6 +27,4 @@ do_install() {
done
}
-FILES:${PN} = "${nonarch_base_libdir}/firmware"
-
INSANE_SKIP:${PN} = "arch"
diff --git a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb
index 5b38a048..68649cf2 100644
--- a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb
+++ b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb
@@ -4,8 +4,6 @@ require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
PR = "${INC_PR}.0"
-CLEANBROKEN = "1"
-
COMPATIBLE_MACHINE = "ti33x|ti43x|am57xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
@@ -24,7 +22,4 @@ do_install() {
done
}
-
-FILES:${PN} = "${nonarch_base_libdir}/firmware"
-
INSANE_SKIP:${PN} = "arch"
diff --git a/meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb b/meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb
index 49638ee9..06c57365 100644
--- a/meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb
+++ b/meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb
@@ -17,8 +17,6 @@ require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
PV = "${TI_DM_FW_VERSION}"
PR = "${INC_PR}.0"
-CLEANBROKEN = "1"
-
# Secure Build
inherit ti-secdev
@@ -101,9 +99,6 @@ ALTERNATIVE_TARGET[j784s4-mcu-r5f0_0-fw] = "${INSTALL_DM_FW_DIR}/${DM_FIRMWARE}"
ALTERNATIVE_PRIORITY = "10"
-# make sure that lib/firmware, and all its contents are part of the package
-FILES:${PN} += "${nonarch_base_libdir}/firmware"
-
# This is used to prevent the build system to_strip the executables
INHIBIT_PACKAGE_STRIP = "1"
INHIBIT_SYSROOT_STRIP = "1"
diff --git a/meta-ti-bsp/recipes-bsp/ti-eth-fw/ti-eth-fw.bb b/meta-ti-bsp/recipes-bsp/ti-eth-fw/ti-eth-fw.bb
index e1d442d3..4bf7f8f1 100644
--- a/meta-ti-bsp/recipes-bsp/ti-eth-fw/ti-eth-fw.bb
+++ b/meta-ti-bsp/recipes-bsp/ti-eth-fw/ti-eth-fw.bb
@@ -17,8 +17,6 @@ require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
PV = "${CORESDK_RTOS_VERSION}"
PR = "${INC_PR}.0"
-CLEANBROKEN = "1"
-
# Secure Build
inherit ti-secdev
@@ -102,9 +100,6 @@ ALTERNATIVE_TARGET[j784s4-main-r5f0_0-fw-sec] = "${INSTALL_ETH_FW_DIR}/${ETH_FW}
ALTERNATIVE_PRIORITY = "5"
-# make sure that lib/firmware, and all its contents are part of the package
-FILES:${PN} += "${nonarch_base_libdir}/firmware"
-
# This is used to prevent the build system to_strip the executables
INHIBIT_PACKAGE_STRIP = "1"
INHIBIT_SYSROOT_STRIP = "1"
diff --git a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
index bd103198..7fb8f8f5 100644
--- a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
@@ -7,8 +7,6 @@ require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
PV = "${IMG_DEC_FW_VERSION}"
PR = "${INC_PR}.0"
-CLEANBROKEN = "1"
-
COMPATIBLE_MACHINE = "j721e"
PACKAGE_ARCH = "${MACHINE_ARCH}"
@@ -20,5 +18,3 @@ do_install() {
install -d ${D}${nonarch_base_libdir}/firmware
install -m 0644 ${S}/ti-img/${TARGET} ${D}${nonarch_base_libdir}/firmware/${TARGET}
}
-
-FILES:${PN} = "${nonarch_base_libdir}/firmware"
diff --git a/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc b/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
index 149fcc07..f5132c56 100644
--- a/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
+++ b/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
@@ -25,3 +25,8 @@ BRANCH ?= "ti-linux-firmware"
SRC_URI = "git://git.ti.com/git/processor-firmware/ti-linux-firmware.git;protocol=https;branch=${BRANCH}"
S = "${WORKDIR}/git"
+
+CLEANBROKEN = "1"
+
+# Make sure that lib/firmware, and all its contents are part of the package
+FILES:${PN} = "${nonarch_base_libdir}/firmware"
diff --git a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
index 2ad93a5d..0eb03b92 100644
--- a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
@@ -14,8 +14,6 @@ LD[unexport] = "1"
PV = "${TI_SYSFW_VERSION}"
PR = "${INC_PR}.0"
-CLEANBROKEN = "1"
-
do_install() {
install -d ${D}${nonarch_base_libdir}/firmware/ti-sysfw
install -m 644 ${S}/ti-sysfw/ti-sci-firmware-* ${D}${nonarch_base_libdir}/firmware/ti-sysfw
@@ -23,8 +21,6 @@ do_install() {
install -m 644 ${S}/ti-sysfw/ti-fs-stub-firmware-* ${D}${nonarch_base_libdir}/firmware/ti-sysfw
}
-FILES:${PN} = "${nonarch_base_libdir}/firmware"
-
do_deploy(){
}
diff --git a/meta-ti-bsp/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb b/meta-ti-bsp/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
index 751b10d6..056576de 100644
--- a/meta-ti-bsp/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
+++ b/meta-ti-bsp/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
@@ -28,8 +28,6 @@ require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
PV = "${CORESDK_RTOS_VERSION}"
PR = "${INC_PR}.1"
-CLEANBROKEN = "1"
-
# Secure Build
inherit ti-secdev
@@ -350,9 +348,6 @@ ALTERNATIVE_TARGET[j784s4-c71_3-fw-sec] = "${INSTALL_IPC_FW_DIR}/${C7X_4_FW}.sig
ALTERNATIVE_PRIORITY = "10"
-# make sure that lib/firmware, and all its contents are part of the package
-FILES:${PN} += "${nonarch_base_libdir}/firmware"
-
# This is used to prevent the build system to_strip the executables
INHIBIT_PACKAGE_STRIP = "1"
INHIBIT_SYSROOT_STRIP = "1"
--
2.39.2
^ permalink raw reply related [flat|nested] 13+ messages in thread* [meta-ti][master/kirkstone][PATCH 3/8] ti-linux-fw: Do not set source directory when including ti-linux-fw.inc
2023-10-25 16:56 [meta-ti][master/kirkstone][PATCH 1/8] conf: machine: Move IMAGE_BOOT_FILES to the SoC inc for J721s2 and J784s4 Andrew Davis
2023-10-25 16:56 ` [meta-ti][master/kirkstone][PATCH 2/8] ti-linux-fw: Make CLEANBROKEN and FILES part of common include Andrew Davis
@ 2023-10-25 16:56 ` Andrew Davis
2023-10-25 16:56 ` [meta-ti][master/kirkstone][PATCH 4/8] ti-sci-fw: Do not unexport CFLAGS, LDFLAGS, AS, or LD Andrew Davis
` (4 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Andrew Davis @ 2023-10-25 16:56 UTC (permalink / raw)
To: Denys Dmytriyenko, Ryan Eatmon, meta-ti; +Cc: Andrew Davis
The common include ti-linux-fw.inc already includes setting this, no need
to set it in each recipe, remove that.
Signed-off-by: Andrew Davis <afd@ti.com>
---
meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb | 1 -
meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 1 -
meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb | 1 -
meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb | 2 --
meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb | 2 --
meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb | 2 --
meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb | 2 --
meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb | 2 --
meta-ti-bsp/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb | 2 --
meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb | 2 --
meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb | 2 --
meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb | 1 -
12 files changed, 20 deletions(-)
diff --git a/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb b/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
index 4263e40f..d88bca6e 100644
--- a/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
@@ -12,7 +12,6 @@ COMPATIBLE_MACHINE = "j721e|j721s2|j784s4"
PACKAGE_ARCH = "${MACHINE_ARCH}"
-S = "${WORKDIR}/git"
TARGET = "mhdp8546.bin"
do_install() {
diff --git a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
index b1bc20b9..a9ee7a8e 100644
--- a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
@@ -15,7 +15,6 @@ COMPATIBLE_MACHINE = "j721s2|j784s4|am62axx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
-S = "${WORKDIR}/git"
TARGET_WAVE521C = "wave521c_codec_fw.bin"
SOURCE_WAVE521C = "wave521c_k3_codec_fw.bin"
diff --git a/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb b/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
index 5cd6e131..e58f2d58 100644
--- a/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
@@ -12,7 +12,6 @@ COMPATIBLE_MACHINE = "dra7xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
-S = "${WORKDIR}/git"
ORIGIN = "DRA71x-RevA-GT9271_SpecDig_Config.bin"
TARGET = "goodix_9271_cfg.bin"
diff --git a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
index 5d95beab..8fe1f838 100644
--- a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
+++ b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
@@ -9,8 +9,6 @@ COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
-S = "${WORKDIR}/git"
-
TARGET = " \
am65x-sr2-pru0-prueth-fw.elf \
am65x-sr2-pru1-prueth-fw.elf \
diff --git a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
index f0d4d16d..4f648075 100644
--- a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
+++ b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
@@ -9,8 +9,6 @@ COMPATIBLE_MACHINE = "am65xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
-S = "${WORKDIR}/git"
-
TARGET = " \
am65x-pru0-prueth-fw.elf \
am65x-pru1-prueth-fw.elf \
diff --git a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
index c7db85fc..99b9e11c 100644
--- a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
+++ b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
@@ -8,8 +8,6 @@ COMPATIBLE_MACHINE = "ti33x|ti43x|am57xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
-S = "${WORKDIR}/git"
-
TARGET = ""
TARGET:ti33x = "am335x-pru0-prueth-fw.elf am335x-pru1-prueth-fw.elf"
TARGET:ti43x = "am437x-pru0-prueth-fw.elf am437x-pru1-prueth-fw.elf"
diff --git a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
index 12f7b729..a1fe13d3 100644
--- a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
+++ b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
@@ -9,8 +9,6 @@ COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
-S = "${WORKDIR}/git"
-
TARGET = " \
am65x-sr2-pru0-pruhsr-fw.elf \
am65x-sr2-pru1-pruhsr-fw.elf \
diff --git a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb
index 47c272a8..2cba6350 100644
--- a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb
+++ b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb
@@ -9,8 +9,6 @@ COMPATIBLE_MACHINE = "ti33x|ti43x|am57xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
-S = "${WORKDIR}/git"
-
TARGET = ""
TARGET:ti33x = "am335x-pru0-pruhsr-fw.elf am335x-pru1-pruhsr-fw.elf"
TARGET:ti43x = "am437x-pru0-pruhsr-fw.elf am437x-pru1-pruhsr-fw.elf"
diff --git a/meta-ti-bsp/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb b/meta-ti-bsp/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb
index fc8e423e..807cf941 100644
--- a/meta-ti-bsp/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb
+++ b/meta-ti-bsp/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb
@@ -9,8 +9,6 @@ COMPATIBLE_MACHINE = "ti33x|ti43x|am57xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
-S = "${WORKDIR}/git"
-
TARGET = ""
TARGET:ti33x = "am335x-pru0-pruprp-fw.elf am335x-pru1-pruprp-fw.elf"
TARGET:ti43x = "am437x-pru0-pruprp-fw.elf am437x-pru1-pruprp-fw.elf"
diff --git a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
index 208f8764..b89e8203 100644
--- a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
+++ b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
@@ -9,8 +9,6 @@ COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
-S = "${WORKDIR}/git"
-
TARGET = " \
am65x-sr2-pru0-prusw-fw.elf \
am65x-sr2-pru1-prusw-fw.elf \
diff --git a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb
index 68649cf2..d612cdf0 100644
--- a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb
+++ b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb
@@ -8,8 +8,6 @@ COMPATIBLE_MACHINE = "ti33x|ti43x|am57xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
-S = "${WORKDIR}/git"
-
TARGET = ""
TARGET:ti33x = "am335x-pru0-prusw-fw.elf am335x-pru1-prusw-fw.elf"
TARGET:ti43x = "am437x-pru0-prusw-fw.elf am437x-pru1-prusw-fw.elf"
diff --git a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
index 7fb8f8f5..d295a1c1 100644
--- a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
@@ -11,7 +11,6 @@ COMPATIBLE_MACHINE = "j721e"
PACKAGE_ARCH = "${MACHINE_ARCH}"
-S = "${WORKDIR}/git"
TARGET = "pvdec_full_bin.fw"
do_install() {
--
2.39.2
^ permalink raw reply related [flat|nested] 13+ messages in thread* [meta-ti][master/kirkstone][PATCH 4/8] ti-sci-fw: Do not unexport CFLAGS, LDFLAGS, AS, or LD
2023-10-25 16:56 [meta-ti][master/kirkstone][PATCH 1/8] conf: machine: Move IMAGE_BOOT_FILES to the SoC inc for J721s2 and J784s4 Andrew Davis
2023-10-25 16:56 ` [meta-ti][master/kirkstone][PATCH 2/8] ti-linux-fw: Make CLEANBROKEN and FILES part of common include Andrew Davis
2023-10-25 16:56 ` [meta-ti][master/kirkstone][PATCH 3/8] ti-linux-fw: Do not set source directory when including ti-linux-fw.inc Andrew Davis
@ 2023-10-25 16:56 ` Andrew Davis
2023-10-25 16:56 ` [meta-ti][master/kirkstone][PATCH 5/8] vpdma-fw: This firmware blob does not depend on the kernel Andrew Davis
` (3 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Andrew Davis @ 2023-10-25 16:56 UTC (permalink / raw)
To: Denys Dmytriyenko, Ryan Eatmon, meta-ti; +Cc: Andrew Davis
There is no compilation in this simple firmware recipe, no need for
these lines, remove them.
Signed-off-by: Andrew Davis <afd@ti.com>
---
meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb | 5 -----
1 file changed, 5 deletions(-)
diff --git a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
index 0eb03b92..12292c88 100644
--- a/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
@@ -6,11 +6,6 @@ require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
PACKAGE_ARCH = "${MACHINE_ARCH}"
-CFLAGS[unexport] = "1"
-LDFLAGS[unexport] = "1"
-AS[unexport] = "1"
-LD[unexport] = "1"
-
PV = "${TI_SYSFW_VERSION}"
PR = "${INC_PR}.0"
--
2.39.2
^ permalink raw reply related [flat|nested] 13+ messages in thread* [meta-ti][master/kirkstone][PATCH 5/8] vpdma-fw: This firmware blob does not depend on the kernel
2023-10-25 16:56 [meta-ti][master/kirkstone][PATCH 1/8] conf: machine: Move IMAGE_BOOT_FILES to the SoC inc for J721s2 and J784s4 Andrew Davis
` (2 preceding siblings ...)
2023-10-25 16:56 ` [meta-ti][master/kirkstone][PATCH 4/8] ti-sci-fw: Do not unexport CFLAGS, LDFLAGS, AS, or LD Andrew Davis
@ 2023-10-25 16:56 ` Andrew Davis
2023-10-25 16:56 ` [meta-ti][master/kirkstone][PATCH 6/8] ti-linux-fw: Add several more firmware helper lines to this common include Andrew Davis
` (2 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Andrew Davis @ 2023-10-25 16:56 UTC (permalink / raw)
To: Denys Dmytriyenko, Ryan Eatmon, meta-ti; +Cc: Andrew Davis
Signed-off-by: Andrew Davis <afd@ti.com>
---
meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb | 2 --
1 file changed, 2 deletions(-)
diff --git a/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb b/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb
index 673634da..2452d111 100644
--- a/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb
+++ b/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb
@@ -6,8 +6,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=fd463c9500441ed91d07a0331baa635c"
COMPATIBLE_MACHINE = "dra7xx"
PACKAGE_ARCH = "${MACHINE_ARCH}"
-DEPENDS += "virtual/kernel"
-
SRC_URI = "http://downloads.ti.com/dsps/dsps_public_sw/glsdk/vpdma-fw/03-2012/exports/vpdma-fw_03-2012.tar.gz;protocol=http;name=dra7xx-evm"
SRC_URI[dra7xx-evm.md5sum] = "80176df1350c21d9efa90171789c546e"
SRC_URI[dra7xx-evm.sha256sum] = "a0b254ffd0c7f481cb3989e632088f5e4a233c73a1c676faa3061721ea60dc90"
--
2.39.2
^ permalink raw reply related [flat|nested] 13+ messages in thread* [meta-ti][master/kirkstone][PATCH 6/8] ti-linux-fw: Add several more firmware helper lines to this common include
2023-10-25 16:56 [meta-ti][master/kirkstone][PATCH 1/8] conf: machine: Move IMAGE_BOOT_FILES to the SoC inc for J721s2 and J784s4 Andrew Davis
` (3 preceding siblings ...)
2023-10-25 16:56 ` [meta-ti][master/kirkstone][PATCH 5/8] vpdma-fw: This firmware blob does not depend on the kernel Andrew Davis
@ 2023-10-25 16:56 ` Andrew Davis
2023-10-25 16:56 ` [meta-ti][master/kirkstone][PATCH 7/8] recipes-bsp: Do not inherit deploy in recipes that do not deploy anything Andrew Davis
2023-10-25 16:56 ` [meta-ti][master/kirkstone][PATCH 8/8] recipes-bsp: Do not use MACHINE_ARCH when package is not machine specific Andrew Davis
6 siblings, 0 replies; 13+ messages in thread
From: Andrew Davis @ 2023-10-25 16:56 UTC (permalink / raw)
To: Denys Dmytriyenko, Ryan Eatmon, meta-ti; +Cc: Andrew Davis
These are all useful for firmware recipes but some recipes did not have
them. For firmware including ti-linux-fw.inc let's add these all to
one spot and remove them from any recipe that did already have these.
Signed-off-by: Andrew Davis <afd@ti.com>
---
.../recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 4 ----
.../prueth-fw/prueth-fw-am65x-sr2_git.bb | 2 --
.../recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb | 2 --
.../recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb | 2 --
.../pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb | 2 --
.../recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb | 2 --
.../recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb | 2 --
.../recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb | 2 --
meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb | 2 --
meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb | 12 ------------
meta-ti-bsp/recipes-bsp/ti-eth-fw/ti-eth-fw.bb | 12 ------------
.../recipes-bsp/ti-linux-fw/ti-linux-fw.inc | 14 ++++++++++++++
.../recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb | 12 ------------
13 files changed, 14 insertions(+), 56 deletions(-)
diff --git a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
index a9ee7a8e..3feca08c 100644
--- a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
@@ -30,7 +30,3 @@ do_install() {
install -d ${D}${nonarch_base_libdir}/firmware/cnm
install -m 0644 ${S}/cnm/${SOURCE_WAVE521C} ${D}${nonarch_base_libdir}/firmware/cnm/${TARGET_WAVE521C}
}
-
-# we don't want to configure and build the source code
-do_compile[noexec] = "1"
-do_configure[noexec] = "1"
diff --git a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
index 8fe1f838..2c0736ed 100644
--- a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
+++ b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
@@ -24,5 +24,3 @@ do_install() {
install -m 0644 ${S}/ti-pruss/$f ${D}${nonarch_base_libdir}/firmware/ti-pruss/$f
done
}
-
-INSANE_SKIP:${PN} = "arch"
diff --git a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
index 4f648075..8b15ab7f 100644
--- a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
+++ b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
@@ -22,5 +22,3 @@ do_install() {
install -m 0644 ${S}/ti-pruss/$f ${D}${nonarch_base_libdir}/firmware/ti-pruss/$f
done
}
-
-INSANE_SKIP:${PN} = "arch"
diff --git a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
index 99b9e11c..463f3faa 100644
--- a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
+++ b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw_5.6.15.bb
@@ -19,5 +19,3 @@ do_install() {
install -m 0644 ${S}/ti-pruss/$f ${D}${nonarch_base_libdir}/firmware/ti-pruss/$f
done
}
-
-INSANE_SKIP:${PN} = "arch"
diff --git a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
index a1fe13d3..ea39d73d 100644
--- a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
+++ b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
@@ -24,5 +24,3 @@ do_install() {
install -m 0644 ${S}/ti-pruss/$f ${D}${nonarch_base_libdir}/firmware/ti-pruss/$f
done
}
-
-INSANE_SKIP:${PN} = "arch"
diff --git a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb
index 2cba6350..fe99cb3e 100644
--- a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb
+++ b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw_2.17.25.bb
@@ -20,5 +20,3 @@ do_install() {
install -m 0644 ${S}/ti-pruss/$f ${D}${nonarch_base_libdir}/firmware/ti-pruss/$f
done
}
-
-INSANE_SKIP:${PN} = "arch"
diff --git a/meta-ti-bsp/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb b/meta-ti-bsp/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb
index 807cf941..842621f6 100644
--- a/meta-ti-bsp/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb
+++ b/meta-ti-bsp/recipes-bsp/pruprp-fw/pruprp-fw_2.17.25.bb
@@ -20,5 +20,3 @@ do_install() {
install -m 0644 ${S}/ti-pruss/$f ${D}${nonarch_base_libdir}/firmware/ti-pruss/$f
done
}
-
-INSANE_SKIP:${PN} = "arch"
diff --git a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
index b89e8203..63c2d311 100644
--- a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
+++ b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
@@ -24,5 +24,3 @@ do_install() {
install -m 0644 ${S}/ti-pruss/$f ${D}${nonarch_base_libdir}/firmware/ti-pruss/$f
done
}
-
-INSANE_SKIP:${PN} = "arch"
diff --git a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb
index d612cdf0..755f93b9 100644
--- a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb
+++ b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw_3.2.9.bb
@@ -19,5 +19,3 @@ do_install() {
install -m 0644 ${S}/ti-pruss/$f ${D}${nonarch_base_libdir}/firmware/ti-pruss/$f
done
}
-
-INSANE_SKIP:${PN} = "arch"
diff --git a/meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb b/meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb
index 06c57365..46876ba5 100644
--- a/meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb
+++ b/meta-ti-bsp/recipes-bsp/ti-dm-fw/ti-dm-fw.bb
@@ -99,16 +99,4 @@ ALTERNATIVE_TARGET[j784s4-mcu-r5f0_0-fw] = "${INSTALL_DM_FW_DIR}/${DM_FIRMWARE}"
ALTERNATIVE_PRIORITY = "10"
-# This is used to prevent the build system to_strip the executables
-INHIBIT_PACKAGE_STRIP = "1"
-INHIBIT_SYSROOT_STRIP = "1"
-# This is used to prevent the build system to split the debug info in a separate file
-INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
-# As it likely to be a different arch from the Yocto build, disable checking by adding "arch" to INSANE_SKIP
-INSANE_SKIP:${PN} += "arch"
-
-# we don't want to configure and build the source code
-do_compile[noexec] = "1"
-do_configure[noexec] = "1"
-
addtask deploy after do_install
diff --git a/meta-ti-bsp/recipes-bsp/ti-eth-fw/ti-eth-fw.bb b/meta-ti-bsp/recipes-bsp/ti-eth-fw/ti-eth-fw.bb
index 4bf7f8f1..b844eb38 100644
--- a/meta-ti-bsp/recipes-bsp/ti-eth-fw/ti-eth-fw.bb
+++ b/meta-ti-bsp/recipes-bsp/ti-eth-fw/ti-eth-fw.bb
@@ -99,15 +99,3 @@ ALTERNATIVE_TARGET[j784s4-main-r5f0_0-fw] = "${INSTALL_ETH_FW_DIR}/${ETH_FW}
ALTERNATIVE_TARGET[j784s4-main-r5f0_0-fw-sec] = "${INSTALL_ETH_FW_DIR}/${ETH_FW}.signed"
ALTERNATIVE_PRIORITY = "5"
-
-# This is used to prevent the build system to_strip the executables
-INHIBIT_PACKAGE_STRIP = "1"
-INHIBIT_SYSROOT_STRIP = "1"
-# This is used to prevent the build system to split the debug info in a separate file
-INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
-# As it likely to be a different arch from the Yocto build, disable checking by adding "arch" to INSANE_SKIP
-INSANE_SKIP:${PN} += "arch"
-
-# we don't want to configure and build the source code
-do_compile[noexec] = "1"
-do_configure[noexec] = "1"
diff --git a/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc b/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
index f5132c56..6e64a9cc 100644
--- a/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
+++ b/meta-ti-bsp/recipes-bsp/ti-linux-fw/ti-linux-fw.inc
@@ -30,3 +30,17 @@ CLEANBROKEN = "1"
# Make sure that lib/firmware, and all its contents are part of the package
FILES:${PN} = "${nonarch_base_libdir}/firmware"
+
+# This is used to prevent the build system from stripping the firmwares
+INHIBIT_PACKAGE_STRIP = "1"
+INHIBIT_SYSROOT_STRIP = "1"
+
+# This is used to prevent the build system from splitting out the firmware debug info into a separate file
+INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
+
+# Disable arch checking as firmware is likely to be a different arch from the Yocto build
+INSANE_SKIP:${PN} += "arch"
+
+# Firmware in Linux Firmware has no configure nor build steps
+do_compile[noexec] = "1"
+do_configure[noexec] = "1"
diff --git a/meta-ti-bsp/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb b/meta-ti-bsp/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
index 056576de..bde206f0 100644
--- a/meta-ti-bsp/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
+++ b/meta-ti-bsp/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
@@ -347,15 +347,3 @@ ALTERNATIVE_TARGET[j784s4-c71_3-fw] = "${INSTALL_IPC_FW_DIR}/${C7X_4_FW}"
ALTERNATIVE_TARGET[j784s4-c71_3-fw-sec] = "${INSTALL_IPC_FW_DIR}/${C7X_4_FW}.signed"
ALTERNATIVE_PRIORITY = "10"
-
-# This is used to prevent the build system to_strip the executables
-INHIBIT_PACKAGE_STRIP = "1"
-INHIBIT_SYSROOT_STRIP = "1"
-# This is used to prevent the build system to split the debug info in a separate file
-INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
-# As it likely to be a different arch from the Yocto build, disable checking by adding "arch" to INSANE_SKIP
-INSANE_SKIP:${PN} += "arch"
-
-# we don't want to configure and build the source code
-do_compile[noexec] = "1"
-do_configure[noexec] = "1"
--
2.39.2
^ permalink raw reply related [flat|nested] 13+ messages in thread* [meta-ti][master/kirkstone][PATCH 7/8] recipes-bsp: Do not inherit deploy in recipes that do not deploy anything
2023-10-25 16:56 [meta-ti][master/kirkstone][PATCH 1/8] conf: machine: Move IMAGE_BOOT_FILES to the SoC inc for J721s2 and J784s4 Andrew Davis
` (4 preceding siblings ...)
2023-10-25 16:56 ` [meta-ti][master/kirkstone][PATCH 6/8] ti-linux-fw: Add several more firmware helper lines to this common include Andrew Davis
@ 2023-10-25 16:56 ` Andrew Davis
2023-10-25 16:56 ` [meta-ti][master/kirkstone][PATCH 8/8] recipes-bsp: Do not use MACHINE_ARCH when package is not machine specific Andrew Davis
6 siblings, 0 replies; 13+ messages in thread
From: Andrew Davis @ 2023-10-25 16:56 UTC (permalink / raw)
To: Denys Dmytriyenko, Ryan Eatmon, meta-ti; +Cc: Andrew Davis
Signed-off-by: Andrew Davis <afd@ti.com>
---
meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 1 -
meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb | 1 -
meta-ti-bsp/recipes-bsp/ti-eth-fw/ti-eth-fw.bb | 1 -
meta-ti-bsp/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb | 1 -
4 files changed, 4 deletions(-)
diff --git a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
index 3feca08c..5b1d8be1 100644
--- a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
@@ -2,7 +2,6 @@ SUMMARY = "Chips&Media codec firmware files"
require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
-inherit deploy
inherit update-alternatives
LICENSE = "BSD-3-Clause"
diff --git a/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb b/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb
index cf26eb2d..6e2996ce 100755
--- a/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb
@@ -6,7 +6,6 @@ LIC_FILES_CHKSUM = "file://LICENSE.ti;md5=04ad0a015d4bb63c2b9e7b112debf3db"
PV = "6.2+git${SRCPV}"
PACKAGE_ARCH = "${MACHINE_ARCH}"
-inherit deploy
inherit update-alternatives
PROTOCOL = "https"
diff --git a/meta-ti-bsp/recipes-bsp/ti-eth-fw/ti-eth-fw.bb b/meta-ti-bsp/recipes-bsp/ti-eth-fw/ti-eth-fw.bb
index b844eb38..9532078b 100644
--- a/meta-ti-bsp/recipes-bsp/ti-eth-fw/ti-eth-fw.bb
+++ b/meta-ti-bsp/recipes-bsp/ti-eth-fw/ti-eth-fw.bb
@@ -9,7 +9,6 @@ PACKAGE_ARCH = "${MACHINE_ARCH}"
INHIBIT_DEFAULT_DEPS = "1"
-inherit deploy
inherit update-alternatives
require recipes-bsp/ti-linux-fw/ti-linux-fw.inc
diff --git a/meta-ti-bsp/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb b/meta-ti-bsp/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
index bde206f0..f1967f7f 100644
--- a/meta-ti-bsp/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
+++ b/meta-ti-bsp/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
@@ -9,7 +9,6 @@ PACKAGE_ARCH = "${MACHINE_ARCH}"
INHIBIT_DEFAULT_DEPS = "1"
-inherit deploy
inherit update-alternatives
PLAT_SFX = ""
--
2.39.2
^ permalink raw reply related [flat|nested] 13+ messages in thread* [meta-ti][master/kirkstone][PATCH 8/8] recipes-bsp: Do not use MACHINE_ARCH when package is not machine specific
2023-10-25 16:56 [meta-ti][master/kirkstone][PATCH 1/8] conf: machine: Move IMAGE_BOOT_FILES to the SoC inc for J721s2 and J784s4 Andrew Davis
` (5 preceding siblings ...)
2023-10-25 16:56 ` [meta-ti][master/kirkstone][PATCH 7/8] recipes-bsp: Do not inherit deploy in recipes that do not deploy anything Andrew Davis
@ 2023-10-25 16:56 ` Andrew Davis
2023-10-26 3:27 ` Denys Dmytriyenko
6 siblings, 1 reply; 13+ messages in thread
From: Andrew Davis @ 2023-10-25 16:56 UTC (permalink / raw)
To: Denys Dmytriyenko, Ryan Eatmon, meta-ti; +Cc: Andrew Davis
Signed-off-by: Andrew Davis <afd@ti.com>
---
meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb | 2 --
meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 2 --
meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb | 1 -
meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb | 2 --
meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb | 2 --
meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb | 2 --
meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb | 2 --
meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb | 2 --
meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb | 2 --
meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb | 1 -
meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb | 1 -
11 files changed, 19 deletions(-)
diff --git a/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb b/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
index d88bca6e..ed1c7817 100644
--- a/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
@@ -10,8 +10,6 @@ PR = "${INC_PR}.0"
COMPATIBLE_MACHINE = "j721e|j721s2|j784s4"
-PACKAGE_ARCH = "${MACHINE_ARCH}"
-
TARGET = "mhdp8546.bin"
do_install() {
diff --git a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
index 5b1d8be1..ef7bc2ad 100644
--- a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
@@ -12,8 +12,6 @@ PR = "${INC_PR}.1"
COMPATIBLE_MACHINE = "j721s2|j784s4|am62axx"
-PACKAGE_ARCH = "${MACHINE_ARCH}"
-
TARGET_WAVE521C = "wave521c_codec_fw.bin"
SOURCE_WAVE521C = "wave521c_k3_codec_fw.bin"
diff --git a/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb b/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb
index 6e2996ce..e333d212 100755
--- a/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb
@@ -4,7 +4,6 @@ LICENSE = "TI-TFL"
LIC_FILES_CHKSUM = "file://LICENSE.ti;md5=04ad0a015d4bb63c2b9e7b112debf3db"
PV = "6.2+git${SRCPV}"
-PACKAGE_ARCH = "${MACHINE_ARCH}"
inherit update-alternatives
diff --git a/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb b/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
index e58f2d58..ee3a94dc 100644
--- a/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
@@ -10,8 +10,6 @@ PR = "${INC_PR}.0"
COMPATIBLE_MACHINE = "dra7xx"
-PACKAGE_ARCH = "${MACHINE_ARCH}"
-
ORIGIN = "DRA71x-RevA-GT9271_SpecDig_Config.bin"
TARGET = "goodix_9271_cfg.bin"
diff --git a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
index 2c0736ed..4b6ef75d 100644
--- a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
+++ b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
@@ -7,8 +7,6 @@ PR = "${INC_PR}.0"
COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
-PACKAGE_ARCH = "${MACHINE_ARCH}"
-
TARGET = " \
am65x-sr2-pru0-prueth-fw.elf \
am65x-sr2-pru1-prueth-fw.elf \
diff --git a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
index 8b15ab7f..20b2bfb9 100644
--- a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
+++ b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
@@ -7,8 +7,6 @@ PR = "${INC_PR}.0"
COMPATIBLE_MACHINE = "am65xx"
-PACKAGE_ARCH = "${MACHINE_ARCH}"
-
TARGET = " \
am65x-pru0-prueth-fw.elf \
am65x-pru1-prueth-fw.elf \
diff --git a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
index ea39d73d..bc731094 100644
--- a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
+++ b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
@@ -7,8 +7,6 @@ PR = "${INC_PR}.0"
COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
-PACKAGE_ARCH = "${MACHINE_ARCH}"
-
TARGET = " \
am65x-sr2-pru0-pruhsr-fw.elf \
am65x-sr2-pru1-pruhsr-fw.elf \
diff --git a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
index 63c2d311..6e296e7c 100644
--- a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
+++ b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
@@ -7,8 +7,6 @@ PR = "${INC_PR}.0"
COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
-PACKAGE_ARCH = "${MACHINE_ARCH}"
-
TARGET = " \
am65x-sr2-pru0-prusw-fw.elf \
am65x-sr2-pru1-prusw-fw.elf \
diff --git a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
index d295a1c1..74729c16 100644
--- a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
+++ b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
@@ -9,8 +9,6 @@ PR = "${INC_PR}.0"
COMPATIBLE_MACHINE = "j721e"
-PACKAGE_ARCH = "${MACHINE_ARCH}"
-
TARGET = "pvdec_full_bin.fw"
do_install() {
diff --git a/meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb b/meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb
index 7d16ae39..4ec09a70 100644
--- a/meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb
+++ b/meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb
@@ -3,7 +3,6 @@ LICENSE = "TI-TSPA"
LIC_FILES_CHKSUM = "file://${S}/J6_VIS_DEMO_LINUX_BINARY_01.50.07.15-Manifest.html;md5=a59aa54b9470f555cf086b91dca0afa3"
COMPATIBLE_MACHINE = "dra7xx"
-PACKAGE_ARCH = "${MACHINE_ARCH}"
PR = "r1"
diff --git a/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb b/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb
index 2452d111..8af49577 100644
--- a/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb
+++ b/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb
@@ -4,7 +4,6 @@ LICENSE = "TI-TSPA"
LIC_FILES_CHKSUM = "file://COPYING;md5=fd463c9500441ed91d07a0331baa635c"
COMPATIBLE_MACHINE = "dra7xx"
-PACKAGE_ARCH = "${MACHINE_ARCH}"
SRC_URI = "http://downloads.ti.com/dsps/dsps_public_sw/glsdk/vpdma-fw/03-2012/exports/vpdma-fw_03-2012.tar.gz;protocol=http;name=dra7xx-evm"
SRC_URI[dra7xx-evm.md5sum] = "80176df1350c21d9efa90171789c546e"
--
2.39.2
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [meta-ti][master/kirkstone][PATCH 8/8] recipes-bsp: Do not use MACHINE_ARCH when package is not machine specific
2023-10-25 16:56 ` [meta-ti][master/kirkstone][PATCH 8/8] recipes-bsp: Do not use MACHINE_ARCH when package is not machine specific Andrew Davis
@ 2023-10-26 3:27 ` Denys Dmytriyenko
2023-10-26 14:00 ` Andrew Davis
0 siblings, 1 reply; 13+ messages in thread
From: Denys Dmytriyenko @ 2023-10-26 3:27 UTC (permalink / raw)
To: afd; +Cc: Denys Dmytriyenko, Ryan Eatmon, meta-ti
On Wed, Oct 25, 2023 at 11:56:30AM -0500, Andrew Davis via lists.yoctoproject.org wrote:
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb | 2 --
> meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 2 --
> meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb | 1 -
> meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb | 2 --
> meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb | 2 --
> meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb | 2 --
> meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb | 2 --
> meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb | 2 --
> meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb | 2 --
> meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb | 1 -
> meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb | 1 -
> 11 files changed, 19 deletions(-)
Overall I agree and fully support the first 7 patches in this series.
But for this last one I wanted to open a discussion.
On one hand I understand the desire to make components as generic as possible
and reduce the number of machine-specific components to a bare minimum.
But on another hand, marking the resulting package as machine-specific when it
has a short list of compatible machines is a standard practice. The reason is
that the list of compatible machines controls only compile time filtering, but
doesn't have any effect on run time. And marking packages as machine specific
helps with that. That closes the loophole of installing incompatible packages.
For example, first recipe below specifies that Cadence MHDP firmware is
compatible with 3 J7 platforms only (or their SoC families, to be exact).
But w/o marking resulting binary package as machine-specific (therefore
producing separate packages for those platforms), there will be a single
generic Aarch64 package made. And there's no protection from installing
this generic package on non-compatible platforms, like J7200 or AM65xx,
either manullay or by pulling it into a rootfs for those incompatible
platforms.
And you normally want to prevent this for regular components. But I guess
this doesn't fully apply to FW images that are loaded by corresponding
drivers anyway. Moreover, there's no compilation involved, just packaging
the binary blob.
In that case, should we also remove COMPATIBLE_MACHINE from these firmware
recipes?
> diff --git a/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb b/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
> index d88bca6e..ed1c7817 100644
> --- a/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
> +++ b/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
> @@ -10,8 +10,6 @@ PR = "${INC_PR}.0"
>
> COMPATIBLE_MACHINE = "j721e|j721s2|j784s4"
>
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> -
> TARGET = "mhdp8546.bin"
>
> do_install() {
> diff --git a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
> index 5b1d8be1..ef7bc2ad 100644
> --- a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
> +++ b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
> @@ -12,8 +12,6 @@ PR = "${INC_PR}.1"
>
> COMPATIBLE_MACHINE = "j721s2|j784s4|am62axx"
>
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> -
> TARGET_WAVE521C = "wave521c_codec_fw.bin"
>
> SOURCE_WAVE521C = "wave521c_k3_codec_fw.bin"
> diff --git a/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb b/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb
> index 6e2996ce..e333d212 100755
> --- a/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb
> +++ b/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb
> @@ -4,7 +4,6 @@ LICENSE = "TI-TFL"
> LIC_FILES_CHKSUM = "file://LICENSE.ti;md5=04ad0a015d4bb63c2b9e7b112debf3db"
>
> PV = "6.2+git${SRCPV}"
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> inherit update-alternatives
>
> diff --git a/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb b/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
> index e58f2d58..ee3a94dc 100644
> --- a/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
> +++ b/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
> @@ -10,8 +10,6 @@ PR = "${INC_PR}.0"
>
> COMPATIBLE_MACHINE = "dra7xx"
>
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> -
> ORIGIN = "DRA71x-RevA-GT9271_SpecDig_Config.bin"
> TARGET = "goodix_9271_cfg.bin"
>
> diff --git a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
> index 2c0736ed..4b6ef75d 100644
> --- a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
> +++ b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
> @@ -7,8 +7,6 @@ PR = "${INC_PR}.0"
>
> COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
>
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> -
> TARGET = " \
> am65x-sr2-pru0-prueth-fw.elf \
> am65x-sr2-pru1-prueth-fw.elf \
> diff --git a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
> index 8b15ab7f..20b2bfb9 100644
> --- a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
> +++ b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
> @@ -7,8 +7,6 @@ PR = "${INC_PR}.0"
>
> COMPATIBLE_MACHINE = "am65xx"
>
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> -
> TARGET = " \
> am65x-pru0-prueth-fw.elf \
> am65x-pru1-prueth-fw.elf \
> diff --git a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
> index ea39d73d..bc731094 100644
> --- a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
> +++ b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
> @@ -7,8 +7,6 @@ PR = "${INC_PR}.0"
>
> COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
>
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> -
> TARGET = " \
> am65x-sr2-pru0-pruhsr-fw.elf \
> am65x-sr2-pru1-pruhsr-fw.elf \
> diff --git a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
> index 63c2d311..6e296e7c 100644
> --- a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
> +++ b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
> @@ -7,8 +7,6 @@ PR = "${INC_PR}.0"
>
> COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
>
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> -
> TARGET = " \
> am65x-sr2-pru0-prusw-fw.elf \
> am65x-sr2-pru1-prusw-fw.elf \
> diff --git a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
> index d295a1c1..74729c16 100644
> --- a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
> +++ b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
> @@ -9,8 +9,6 @@ PR = "${INC_PR}.0"
>
> COMPATIBLE_MACHINE = "j721e"
>
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> -
> TARGET = "pvdec_full_bin.fw"
>
> do_install() {
> diff --git a/meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb b/meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb
> index 7d16ae39..4ec09a70 100644
> --- a/meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb
> +++ b/meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb
> @@ -3,7 +3,6 @@ LICENSE = "TI-TSPA"
> LIC_FILES_CHKSUM = "file://${S}/J6_VIS_DEMO_LINUX_BINARY_01.50.07.15-Manifest.html;md5=a59aa54b9470f555cf086b91dca0afa3"
>
> COMPATIBLE_MACHINE = "dra7xx"
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> PR = "r1"
>
> diff --git a/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb b/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb
> index 2452d111..8af49577 100644
> --- a/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb
> +++ b/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb
> @@ -4,7 +4,6 @@ LICENSE = "TI-TSPA"
> LIC_FILES_CHKSUM = "file://COPYING;md5=fd463c9500441ed91d07a0331baa635c"
>
> COMPATIBLE_MACHINE = "dra7xx"
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> SRC_URI = "http://downloads.ti.com/dsps/dsps_public_sw/glsdk/vpdma-fw/03-2012/exports/vpdma-fw_03-2012.tar.gz;protocol=http;name=dra7xx-evm"
> SRC_URI[dra7xx-evm.md5sum] = "80176df1350c21d9efa90171789c546e"
> --
> 2.39.2
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [meta-ti][master/kirkstone][PATCH 8/8] recipes-bsp: Do not use MACHINE_ARCH when package is not machine specific
2023-10-26 3:27 ` Denys Dmytriyenko
@ 2023-10-26 14:00 ` Andrew Davis
2023-11-02 14:57 ` Ryan Eatmon
0 siblings, 1 reply; 13+ messages in thread
From: Andrew Davis @ 2023-10-26 14:00 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: Denys Dmytriyenko, Ryan Eatmon, meta-ti
On 10/25/23 10:27 PM, Denys Dmytriyenko wrote:
> On Wed, Oct 25, 2023 at 11:56:30AM -0500, Andrew Davis via lists.yoctoproject.org wrote:
>> Signed-off-by: Andrew Davis <afd@ti.com>
>> ---
>> meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb | 2 --
>> meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 2 --
>> meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb | 1 -
>> meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb | 2 --
>> meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb | 2 --
>> meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb | 2 --
>> meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb | 2 --
>> meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb | 2 --
>> meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb | 2 --
>> meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb | 1 -
>> meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb | 1 -
>> 11 files changed, 19 deletions(-)
>
> Overall I agree and fully support the first 7 patches in this series.
>
> But for this last one I wanted to open a discussion.
>
I try to sort my series in least-to-most likely to be controversial, I was
just wondering how far we would get down the list, glad we got to 8 :)
> On one hand I understand the desire to make components as generic as possible
> and reduce the number of machine-specific components to a bare minimum.
>
> But on another hand, marking the resulting package as machine-specific when it
> has a short list of compatible machines is a standard practice. The reason is
> that the list of compatible machines controls only compile time filtering, but
> doesn't have any effect on run time. And marking packages as machine specific
> helps with that. That closes the loophole of installing incompatible packages.
>
> For example, first recipe below specifies that Cadence MHDP firmware is
> compatible with 3 J7 platforms only (or their SoC families, to be exact).
> But w/o marking resulting binary package as machine-specific (therefore
> producing separate packages for those platforms), there will be a single
> generic Aarch64 package made. And there's no protection from installing
> this generic package on non-compatible platforms, like J7200 or AM65xx,
> either manullay or by pulling it into a rootfs for those incompatible
> platforms.
>
> And you normally want to prevent this for regular components. But I guess
> this doesn't fully apply to FW images that are loaded by corresponding
> drivers anyway. Moreover, there's no compilation involved, just packaging
> the binary blob.
>
> In that case, should we also remove COMPATIBLE_MACHINE from these firmware
> recipes?
>
That is exactly where I was going to go next. These firmware packages are
not technically incompatible with the other machines.
We just use COMPATIBLE_MACHINE checks here to keep us from accidentily bundling
them with images where they wouldn't add any value (which you did with prusw-fw
which is what stated me thinking on all this). But since they don't break
anything either, forcing them to be machine specific seemed like overkill also.
Only place where we still need this is firmware recipes that only ship some of
the firmware based on machine (see prueth-fw for instance). I'd like to get
that cleaned up next. If we only want some of the firmware then we should split
it into different packages (prueth-fw-am57xx, etc.) and only install the one
we want for that platform.
Andrew
>
>
>> diff --git a/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb b/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
>> index d88bca6e..ed1c7817 100644
>> --- a/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
>> +++ b/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
>> @@ -10,8 +10,6 @@ PR = "${INC_PR}.0"
>>
>> COMPATIBLE_MACHINE = "j721e|j721s2|j784s4"
>>
>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>> -
>> TARGET = "mhdp8546.bin"
>>
>> do_install() {
>> diff --git a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
>> index 5b1d8be1..ef7bc2ad 100644
>> --- a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
>> +++ b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
>> @@ -12,8 +12,6 @@ PR = "${INC_PR}.1"
>>
>> COMPATIBLE_MACHINE = "j721s2|j784s4|am62axx"
>>
>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>> -
>> TARGET_WAVE521C = "wave521c_codec_fw.bin"
>>
>> SOURCE_WAVE521C = "wave521c_k3_codec_fw.bin"
>> diff --git a/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb b/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb
>> index 6e2996ce..e333d212 100755
>> --- a/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb
>> +++ b/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb
>> @@ -4,7 +4,6 @@ LICENSE = "TI-TFL"
>> LIC_FILES_CHKSUM = "file://LICENSE.ti;md5=04ad0a015d4bb63c2b9e7b112debf3db"
>>
>> PV = "6.2+git${SRCPV}"
>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>>
>> inherit update-alternatives
>>
>> diff --git a/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb b/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
>> index e58f2d58..ee3a94dc 100644
>> --- a/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
>> +++ b/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
>> @@ -10,8 +10,6 @@ PR = "${INC_PR}.0"
>>
>> COMPATIBLE_MACHINE = "dra7xx"
>>
>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>> -
>> ORIGIN = "DRA71x-RevA-GT9271_SpecDig_Config.bin"
>> TARGET = "goodix_9271_cfg.bin"
>>
>> diff --git a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
>> index 2c0736ed..4b6ef75d 100644
>> --- a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
>> +++ b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
>> @@ -7,8 +7,6 @@ PR = "${INC_PR}.0"
>>
>> COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
>>
>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>> -
>> TARGET = " \
>> am65x-sr2-pru0-prueth-fw.elf \
>> am65x-sr2-pru1-prueth-fw.elf \
>> diff --git a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
>> index 8b15ab7f..20b2bfb9 100644
>> --- a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
>> +++ b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
>> @@ -7,8 +7,6 @@ PR = "${INC_PR}.0"
>>
>> COMPATIBLE_MACHINE = "am65xx"
>>
>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>> -
>> TARGET = " \
>> am65x-pru0-prueth-fw.elf \
>> am65x-pru1-prueth-fw.elf \
>> diff --git a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
>> index ea39d73d..bc731094 100644
>> --- a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
>> +++ b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
>> @@ -7,8 +7,6 @@ PR = "${INC_PR}.0"
>>
>> COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
>>
>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>> -
>> TARGET = " \
>> am65x-sr2-pru0-pruhsr-fw.elf \
>> am65x-sr2-pru1-pruhsr-fw.elf \
>> diff --git a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
>> index 63c2d311..6e296e7c 100644
>> --- a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
>> +++ b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
>> @@ -7,8 +7,6 @@ PR = "${INC_PR}.0"
>>
>> COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
>>
>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>> -
>> TARGET = " \
>> am65x-sr2-pru0-prusw-fw.elf \
>> am65x-sr2-pru1-prusw-fw.elf \
>> diff --git a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
>> index d295a1c1..74729c16 100644
>> --- a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
>> +++ b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
>> @@ -9,8 +9,6 @@ PR = "${INC_PR}.0"
>>
>> COMPATIBLE_MACHINE = "j721e"
>>
>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>> -
>> TARGET = "pvdec_full_bin.fw"
>>
>> do_install() {
>> diff --git a/meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb b/meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb
>> index 7d16ae39..4ec09a70 100644
>> --- a/meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb
>> +++ b/meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb
>> @@ -3,7 +3,6 @@ LICENSE = "TI-TSPA"
>> LIC_FILES_CHKSUM = "file://${S}/J6_VIS_DEMO_LINUX_BINARY_01.50.07.15-Manifest.html;md5=a59aa54b9470f555cf086b91dca0afa3"
>>
>> COMPATIBLE_MACHINE = "dra7xx"
>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>>
>> PR = "r1"
>>
>> diff --git a/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb b/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb
>> index 2452d111..8af49577 100644
>> --- a/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb
>> +++ b/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb
>> @@ -4,7 +4,6 @@ LICENSE = "TI-TSPA"
>> LIC_FILES_CHKSUM = "file://COPYING;md5=fd463c9500441ed91d07a0331baa635c"
>>
>> COMPATIBLE_MACHINE = "dra7xx"
>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>>
>> SRC_URI = "http://downloads.ti.com/dsps/dsps_public_sw/glsdk/vpdma-fw/03-2012/exports/vpdma-fw_03-2012.tar.gz;protocol=http;name=dra7xx-evm"
>> SRC_URI[dra7xx-evm.md5sum] = "80176df1350c21d9efa90171789c546e"
>> --
>> 2.39.2
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [meta-ti][master/kirkstone][PATCH 8/8] recipes-bsp: Do not use MACHINE_ARCH when package is not machine specific
2023-10-26 14:00 ` Andrew Davis
@ 2023-11-02 14:57 ` Ryan Eatmon
2023-11-03 6:15 ` Denys Dmytriyenko
0 siblings, 1 reply; 13+ messages in thread
From: Ryan Eatmon @ 2023-11-02 14:57 UTC (permalink / raw)
To: Andrew Davis, Denys Dmytriyenko; +Cc: Denys Dmytriyenko, meta-ti
On 10/26/2023 9:00 AM, Andrew Davis wrote:
> On 10/25/23 10:27 PM, Denys Dmytriyenko wrote:
>> On Wed, Oct 25, 2023 at 11:56:30AM -0500, Andrew Davis via
>> lists.yoctoproject.org wrote:
>>> Signed-off-by: Andrew Davis <afd@ti.com>
>>> ---
>>> meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb | 2 --
>>> meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 2 --
>>> meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb | 1 -
>>> meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb | 2 --
>>> meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb | 2 --
>>> meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb | 2 --
>>> meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb | 2 --
>>> meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb | 2 --
>>> meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb | 2 --
>>> meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb | 1 -
>>> meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb | 1 -
>>> 11 files changed, 19 deletions(-)
>>
>> Overall I agree and fully support the first 7 patches in this series.
>>
>> But for this last one I wanted to open a discussion.
>>
>
> I try to sort my series in least-to-most likely to be controversial, I was
> just wondering how far we would get down the list, glad we got to 8 :)
>
>> On one hand I understand the desire to make components as generic as
>> possible
>> and reduce the number of machine-specific components to a bare minimum.
>>
>> But on another hand, marking the resulting package as machine-specific
>> when it
>> has a short list of compatible machines is a standard practice. The
>> reason is
>> that the list of compatible machines controls only compile time
>> filtering, but
>> doesn't have any effect on run time. And marking packages as machine
>> specific
>> helps with that. That closes the loophole of installing incompatible
>> packages.
>>
>> For example, first recipe below specifies that Cadence MHDP firmware is
>> compatible with 3 J7 platforms only (or their SoC families, to be exact).
>> But w/o marking resulting binary package as machine-specific (therefore
>> producing separate packages for those platforms), there will be a single
>> generic Aarch64 package made. And there's no protection from installing
>> this generic package on non-compatible platforms, like J7200 or AM65xx,
>> either manullay or by pulling it into a rootfs for those incompatible
>> platforms.
>>
>> And you normally want to prevent this for regular components. But I guess
>> this doesn't fully apply to FW images that are loaded by corresponding
>> drivers anyway. Moreover, there's no compilation involved, just packaging
>> the binary blob.
>>
>> In that case, should we also remove COMPATIBLE_MACHINE from these
>> firmware
>> recipes?
>>
>
> That is exactly where I was going to go next. These firmware packages are
> not technically incompatible with the other machines.
>
> We just use COMPATIBLE_MACHINE checks here to keep us from accidentily
> bundling
> them with images where they wouldn't add any value (which you did with
> prusw-fw
> which is what stated me thinking on all this). But since they don't break
> anything either, forcing them to be machine specific seemed like
> overkill also.
>
> Only place where we still need this is firmware recipes that only ship
> some of
> the firmware based on machine (see prueth-fw for instance). I'd like to get
> that cleaned up next. If we only want some of the firmware then we
> should split
> it into different packages (prueth-fw-am57xx, etc.) and only install the
> one
> we want for that platform.
>
> Andrew
Denys, does Andrew's response address your concerns?
>>
>>
>>> diff --git
>>> a/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
>>> b/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
>>> index d88bca6e..ed1c7817 100644
>>> --- a/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
>>> +++ b/meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb
>>> @@ -10,8 +10,6 @@ PR = "${INC_PR}.0"
>>> COMPATIBLE_MACHINE = "j721e|j721s2|j784s4"
>>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>>> -
>>> TARGET = "mhdp8546.bin"
>>> do_install() {
>>> diff --git a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
>>> b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
>>> index 5b1d8be1..ef7bc2ad 100644
>>> --- a/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
>>> +++ b/meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb
>>> @@ -12,8 +12,6 @@ PR = "${INC_PR}.1"
>>> COMPATIBLE_MACHINE = "j721s2|j784s4|am62axx"
>>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>>> -
>>> TARGET_WAVE521C = "wave521c_codec_fw.bin"
>>> SOURCE_WAVE521C = "wave521c_k3_codec_fw.bin"
>>> diff --git
>>> a/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb
>>> b/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb
>>> index 6e2996ce..e333d212 100755
>>> --- a/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb
>>> +++ b/meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb
>>> @@ -4,7 +4,6 @@ LICENSE = "TI-TFL"
>>> LIC_FILES_CHKSUM =
>>> "file://LICENSE.ti;md5=04ad0a015d4bb63c2b9e7b112debf3db"
>>> PV = "6.2+git${SRCPV}"
>>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>>> inherit update-alternatives
>>> diff --git a/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
>>> b/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
>>> index e58f2d58..ee3a94dc 100644
>>> --- a/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
>>> +++ b/meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb
>>> @@ -10,8 +10,6 @@ PR = "${INC_PR}.0"
>>> COMPATIBLE_MACHINE = "dra7xx"
>>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>>> -
>>> ORIGIN = "DRA71x-RevA-GT9271_SpecDig_Config.bin"
>>> TARGET = "goodix_9271_cfg.bin"
>>> diff --git
>>> a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
>>> b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
>>> index 2c0736ed..4b6ef75d 100644
>>> --- a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
>>> +++ b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb
>>> @@ -7,8 +7,6 @@ PR = "${INC_PR}.0"
>>> COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
>>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>>> -
>>> TARGET = " \
>>> am65x-sr2-pru0-prueth-fw.elf \
>>> am65x-sr2-pru1-prueth-fw.elf \
>>> diff --git a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
>>> b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
>>> index 8b15ab7f..20b2bfb9 100644
>>> --- a/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
>>> +++ b/meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb
>>> @@ -7,8 +7,6 @@ PR = "${INC_PR}.0"
>>> COMPATIBLE_MACHINE = "am65xx"
>>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>>> -
>>> TARGET = " \
>>> am65x-pru0-prueth-fw.elf \
>>> am65x-pru1-prueth-fw.elf \
>>> diff --git
>>> a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
>>> b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
>>> index ea39d73d..bc731094 100644
>>> --- a/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
>>> +++ b/meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb
>>> @@ -7,8 +7,6 @@ PR = "${INC_PR}.0"
>>> COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
>>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>>> -
>>> TARGET = " \
>>> am65x-sr2-pru0-pruhsr-fw.elf \
>>> am65x-sr2-pru1-pruhsr-fw.elf \
>>> diff --git
>>> a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
>>> b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
>>> index 63c2d311..6e296e7c 100644
>>> --- a/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
>>> +++ b/meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb
>>> @@ -7,8 +7,6 @@ PR = "${INC_PR}.0"
>>> COMPATIBLE_MACHINE = "am65xx-evm|am64xx"
>>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>>> -
>>> TARGET = " \
>>> am65x-sr2-pru0-prusw-fw.elf \
>>> am65x-sr2-pru1-prusw-fw.elf \
>>> diff --git
>>> a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
>>> b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
>>> index d295a1c1..74729c16 100644
>>> --- a/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
>>> +++ b/meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb
>>> @@ -9,8 +9,6 @@ PR = "${INC_PR}.0"
>>> COMPATIBLE_MACHINE = "j721e"
>>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>>> -
>>> TARGET = "pvdec_full_bin.fw"
>>> do_install() {
>>> diff --git a/meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb
>>> b/meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb
>>> index 7d16ae39..4ec09a70 100644
>>> --- a/meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb
>>> +++ b/meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb
>>> @@ -3,7 +3,6 @@ LICENSE = "TI-TSPA"
>>> LIC_FILES_CHKSUM =
>>> "file://${S}/J6_VIS_DEMO_LINUX_BINARY_01.50.07.15-Manifest.html;md5=a59aa54b9470f555cf086b91dca0afa3"
>>> COMPATIBLE_MACHINE = "dra7xx"
>>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>>> PR = "r1"
>>> diff --git a/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb
>>> b/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb
>>> index 2452d111..8af49577 100644
>>> --- a/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb
>>> +++ b/meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb
>>> @@ -4,7 +4,6 @@ LICENSE = "TI-TSPA"
>>> LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=fd463c9500441ed91d07a0331baa635c"
>>> COMPATIBLE_MACHINE = "dra7xx"
>>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>>> SRC_URI =
>>> "http://downloads.ti.com/dsps/dsps_public_sw/glsdk/vpdma-fw/03-2012/exports/vpdma-fw_03-2012.tar.gz;protocol=http;name=dra7xx-evm"
>>> SRC_URI[dra7xx-evm.md5sum] = "80176df1350c21d9efa90171789c546e"
>>> --
>>> 2.39.2
--
Ryan Eatmon reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc. - LCPD - MGTS
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [meta-ti][master/kirkstone][PATCH 8/8] recipes-bsp: Do not use MACHINE_ARCH when package is not machine specific
2023-11-02 14:57 ` Ryan Eatmon
@ 2023-11-03 6:15 ` Denys Dmytriyenko
2023-11-03 16:20 ` Ryan Eatmon
0 siblings, 1 reply; 13+ messages in thread
From: Denys Dmytriyenko @ 2023-11-03 6:15 UTC (permalink / raw)
To: Ryan Eatmon; +Cc: Andrew Davis, Denys Dmytriyenko, meta-ti
On Thu, Nov 02, 2023 at 09:57:11AM -0500, Ryan Eatmon wrote:
>
>
> On 10/26/2023 9:00 AM, Andrew Davis wrote:
> >On 10/25/23 10:27 PM, Denys Dmytriyenko wrote:
> >>On Wed, Oct 25, 2023 at 11:56:30AM -0500, Andrew Davis via
> >>lists.yoctoproject.org wrote:
> >>>Signed-off-by: Andrew Davis <afd@ti.com>
> >>>---
> >>> meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb | 2 --
> >>> meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 2 --
> >>> meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb | 1 -
> >>> meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb | 2 --
> >>> meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb | 2 --
> >>> meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb | 2 --
> >>> meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb | 2 --
> >>> meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb | 2 --
> >>> meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb | 2 --
> >>> meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb | 1 -
> >>> meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb | 1 -
> >>> 11 files changed, 19 deletions(-)
> >>
> >>Overall I agree and fully support the first 7 patches in this series.
> >>
> >>But for this last one I wanted to open a discussion.
> >>
> >
> >I try to sort my series in least-to-most likely to be controversial, I was
> >just wondering how far we would get down the list, glad we got to 8 :)
> >
> >>On one hand I understand the desire to make components as
> >>generic as possible
> >>and reduce the number of machine-specific components to a bare minimum.
> >>
> >>But on another hand, marking the resulting package as
> >>machine-specific when it
> >>has a short list of compatible machines is a standard practice.
> >>The reason is
> >>that the list of compatible machines controls only compile time
> >>filtering, but
> >>doesn't have any effect on run time. And marking packages as
> >>machine specific
> >>helps with that. That closes the loophole of installing
> >>incompatible packages.
> >>
> >>For example, first recipe below specifies that Cadence MHDP firmware is
> >>compatible with 3 J7 platforms only (or their SoC families, to be exact).
> >>But w/o marking resulting binary package as machine-specific (therefore
> >>producing separate packages for those platforms), there will be a single
> >>generic Aarch64 package made. And there's no protection from installing
> >>this generic package on non-compatible platforms, like J7200 or AM65xx,
> >>either manullay or by pulling it into a rootfs for those incompatible
> >>platforms.
> >>
> >>And you normally want to prevent this for regular components. But I guess
> >>this doesn't fully apply to FW images that are loaded by corresponding
> >>drivers anyway. Moreover, there's no compilation involved, just packaging
> >>the binary blob.
> >>
> >>In that case, should we also remove COMPATIBLE_MACHINE from
> >>these firmware
> >>recipes?
> >>
> >
> >That is exactly where I was going to go next. These firmware packages are
> >not technically incompatible with the other machines.
> >
> >We just use COMPATIBLE_MACHINE checks here to keep us from
> >accidentily bundling
> >them with images where they wouldn't add any value (which you did
> >with prusw-fw
> >which is what stated me thinking on all this). But since they don't break
> >anything either, forcing them to be machine specific seemed like
> >overkill also.
> >
> >Only place where we still need this is firmware recipes that only
> >ship some of
> >the firmware based on machine (see prueth-fw for instance). I'd like to get
> >that cleaned up next. If we only want some of the firmware then we
> >should split
> >it into different packages (prueth-fw-am57xx, etc.) and only
> >install the one
> >we want for that platform.
>
> Denys, does Andrew's response address your concerns?
Well, I do believe we are generally in agreement here. But I'm not sure if
that means we should merge patch #8 as is and address COMPATIBLE_MACHINE
changes later, or rework the patch to address that with MACHINE_ARCH together?
--
Denys
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [meta-ti][master/kirkstone][PATCH 8/8] recipes-bsp: Do not use MACHINE_ARCH when package is not machine specific
2023-11-03 6:15 ` Denys Dmytriyenko
@ 2023-11-03 16:20 ` Ryan Eatmon
0 siblings, 0 replies; 13+ messages in thread
From: Ryan Eatmon @ 2023-11-03 16:20 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: Andrew Davis, Denys Dmytriyenko, meta-ti
On 11/3/2023 1:15 AM, Denys Dmytriyenko wrote:
> On Thu, Nov 02, 2023 at 09:57:11AM -0500, Ryan Eatmon wrote:
>>
>>
>> On 10/26/2023 9:00 AM, Andrew Davis wrote:
>>> On 10/25/23 10:27 PM, Denys Dmytriyenko wrote:
>>>> On Wed, Oct 25, 2023 at 11:56:30AM -0500, Andrew Davis via
>>>> lists.yoctoproject.org wrote:
>>>>> Signed-off-by: Andrew Davis <afd@ti.com>
>>>>> ---
>>>>> meta-ti-bsp/recipes-bsp/cadence-mhdp-fw/cadence-mhdp-fw_git.bb | 2 --
>>>>> meta-ti-bsp/recipes-bsp/cnm-wave-fw/cnm-wave-fw_git.bb | 2 --
>>>>> meta-ti-bsp/recipes-bsp/cpsw9g-eth-fw/cpsw9g-eth-fw_git.bb | 1 -
>>>>> meta-ti-bsp/recipes-bsp/goodix-fw/goodix-fw_git.bb | 2 --
>>>>> meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x-sr2_git.bb | 2 --
>>>>> meta-ti-bsp/recipes-bsp/prueth-fw/prueth-fw-am65x_git.bb | 2 --
>>>>> meta-ti-bsp/recipes-bsp/pruhsr-fw/pruhsr-fw-am65x-sr2_git.bb | 2 --
>>>>> meta-ti-bsp/recipes-bsp/prusw-fw/prusw-fw-am65x-sr2_git.bb | 2 --
>>>>> meta-ti-bsp/recipes-bsp/ti-img-encode-decode/vxd-dec-fw_git.bb | 2 --
>>>>> meta-ti-bsp/recipes-bsp/vis-fw/vis_01.50.07.15.bb | 1 -
>>>>> meta-ti-bsp/recipes-bsp/vpdma-fw/vpdma-fw_03-2012.bb | 1 -
>>>>> 11 files changed, 19 deletions(-)
>>>>
>>>> Overall I agree and fully support the first 7 patches in this series.
>>>>
>>>> But for this last one I wanted to open a discussion.
>>>>
>>>
>>> I try to sort my series in least-to-most likely to be controversial, I was
>>> just wondering how far we would get down the list, glad we got to 8 :)
>>>
>>>> On one hand I understand the desire to make components as
>>>> generic as possible
>>>> and reduce the number of machine-specific components to a bare minimum.
>>>>
>>>> But on another hand, marking the resulting package as
>>>> machine-specific when it
>>>> has a short list of compatible machines is a standard practice.
>>>> The reason is
>>>> that the list of compatible machines controls only compile time
>>>> filtering, but
>>>> doesn't have any effect on run time. And marking packages as
>>>> machine specific
>>>> helps with that. That closes the loophole of installing
>>>> incompatible packages.
>>>>
>>>> For example, first recipe below specifies that Cadence MHDP firmware is
>>>> compatible with 3 J7 platforms only (or their SoC families, to be exact).
>>>> But w/o marking resulting binary package as machine-specific (therefore
>>>> producing separate packages for those platforms), there will be a single
>>>> generic Aarch64 package made. And there's no protection from installing
>>>> this generic package on non-compatible platforms, like J7200 or AM65xx,
>>>> either manullay or by pulling it into a rootfs for those incompatible
>>>> platforms.
>>>>
>>>> And you normally want to prevent this for regular components. But I guess
>>>> this doesn't fully apply to FW images that are loaded by corresponding
>>>> drivers anyway. Moreover, there's no compilation involved, just packaging
>>>> the binary blob.
>>>>
>>>> In that case, should we also remove COMPATIBLE_MACHINE from
>>>> these firmware
>>>> recipes?
>>>>
>>>
>>> That is exactly where I was going to go next. These firmware packages are
>>> not technically incompatible with the other machines.
>>>
>>> We just use COMPATIBLE_MACHINE checks here to keep us from
>>> accidentily bundling
>>> them with images where they wouldn't add any value (which you did
>>> with prusw-fw
>>> which is what stated me thinking on all this). But since they don't break
>>> anything either, forcing them to be machine specific seemed like
>>> overkill also.
>>>
>>> Only place where we still need this is firmware recipes that only
>>> ship some of
>>> the firmware based on machine (see prueth-fw for instance). I'd like to get
>>> that cleaned up next. If we only want some of the firmware then we
>>> should split
>>> it into different packages (prueth-fw-am57xx, etc.) and only
>>> install the one
>>> we want for that platform.
>>
>> Denys, does Andrew's response address your concerns?
>
> Well, I do believe we are generally in agreement here. But I'm not sure if
> that means we should merge patch #8 as is and address COMPATIBLE_MACHINE
> changes later, or rework the patch to address that with MACHINE_ARCH together?
Ok. I'll accept 1-7 and reject 8 for now. 8 can be resubmitted once
those additional changes are made and can be taken all at once.
--
Ryan Eatmon reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc. - LCPD - MGTS
^ permalink raw reply [flat|nested] 13+ messages in thread