All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: hmaied.benabdellatif@etictelecom.com
Cc: David Bender <codehero@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/openldap: bump version to 2.5.16
Date: Fri, 3 Nov 2023 10:54:58 +0100	[thread overview]
Message-ID: <20231103105458.36622fb1@windsurf> (raw)
In-Reply-To: <20231102143608.3231106-1-hmaied.benabdellatif@etictelecom.com>

Hello Hmaied,

On Thu,  2 Nov 2023 15:36:08 +0100
hmaied.benabdellatif@etictelecom.com wrote:

> From: Hmaied Ben Abdellatif <hmaied.benabdellatif@etictelecom.com>
> 
> Signed-off-by: Hmaied Ben Abdellatif <hmaied.benabdellatif@etictelecom.com>

Thanks for the updated patch. Could you please comment in the commit
log on why patches 0001-fix_cross_strip.patch and
0004-revert-ITS-3977-fix-libtool-static-behavior-to-match.patch are
removed?

Also, I see you rename 0002-fix-bignum.patch to 0001-fix-bignum.patch,
but it looks like you forgot to also rename 0003-disable-docs.patch to
have a correct sequence number.


> -# From https://www.openldap.org/software/download/OpenLDAP/openldap-release/openldap-2.4.59.md5
> -md5  6036a03b3a67b4a1fe1246e0a2c7265a  openldap-2.4.59.tgz
> -# From https://www.openldap.org/software/download/OpenLDAP/openldap-release/openldap-2.4.59.sha1
> -sha1  b154d06bbf40fafafb34fffc4b116946d931efef  openldap-2.4.59.tgz
>  # Locally computed
> -sha256  99f37d6747d88206c470067eda624d5e48c1011e943ec0ab217bae8712e22f34  openldap-2.4.59.tgz
> +sha512  ed0c3732c096807006a13df7484c889ccc6943ced3e50c0d01034e6c6823c0996ae1fda0348677243934fbe8715a467abc46f01dee87b7571f5392b0570eb04a   openldap-2.5.16.tgz

Why are you no longer taking the md5+sha256 from the upstream website?

Apparently, because they are now only providing
https://www.openldap.org/software/download/OpenLDAP/openldap-release/openldap-2.5.16.sha3-512
which is using SHA3-512, but we don't have support for SHA3-512 in
Buildroot. However, you could probably verify it on your side:

$ wget https://www.openldap.org/software/download/OpenLDAP/openldap-release/openldap-2.5.16.tgz
$ sha3sum -a 512 openldap-2.5.16.tgz 
5a1fcef237bbcf119dc1be15c366283814c29e6433ebe320ad186f184f52befc1f4f1dd81faf29b1d078e2f59e8de081699a153f0821f3741d7d24913276d577  openldap-2.5.16.tgz
$ wget -q -O - https://www.openldap.org/software/download/OpenLDAP/openldap-release/openldap-2.5.16.sha3-512
SHA3-512(openldap-2.5.16.tgz)= 5a1fcef237bbcf119dc1be15c366283814c29e6433ebe320ad186f184f52befc1f4f1dd81faf29b1d078e2f59e8de081699a153f0821f3741d7d24913276d577

They match, houra.

$ sha256sum openldap-2.5.16.tgz 
546ba591822e8bb0e467d40c4d4a30f89d937c3a507fe83a578f582f6a211327  openldap-2.5.16.tgz

And then in the .hash file:

# Verified by locally checking against the SHA3-512 hash available in
# https://www.openldap.org/software/download/OpenLDAP/openldap-release/openldap-2.5.16.sha3-512
sha256  546ba591822e8bb0e467d40c4d4a30f89d937c3a507fe83a578f582f6a211327  openldap-2.5.16.tgz

Could you rework again your patch according to these changes?

Also, when you send an updated version of the patch, we expect the new
version to be [PATCH v2] or [PATCH v3] and have a small changelog below
the --- line. See
https://buildroot.org/downloads/manual/manual.html#submitting-patches
for more details.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-11-03  9:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 14:36 [Buildroot] [PATCH 1/1] package/openldap: bump version to 2.5.16 hmaied.benabdellatif
2023-11-03  9:54 ` Thomas Petazzoni via buildroot [this message]
2023-11-03 11:48   ` Baruch Siach via buildroot
2023-11-03 13:13     ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231103105458.36622fb1@windsurf \
    --to=buildroot@buildroot.org \
    --cc=codehero@gmail.com \
    --cc=hmaied.benabdellatif@etictelecom.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.