From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [CI v8 14/18] drm/xe: Adjust to commit "drm/gpuvm: add an abstraction for a VM/BO combination"
Date: Fri, 3 Nov 2023 16:32:30 +0100 [thread overview]
Message-ID: <20231103153234.30407-14-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20231103153234.30407-1-thomas.hellstrom@linux.intel.com>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
drivers/gpu/drm/xe/xe_bo.c | 11 +++++++----
drivers/gpu/drm/xe/xe_vm.c | 32 +++++++++++++++++++++++++-------
2 files changed, 32 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index 6212e004c0cf..c23a5694a788 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -453,6 +453,7 @@ static int xe_bo_trigger_rebind(struct xe_device *xe, struct xe_bo *bo,
struct dma_fence *fence;
struct drm_gpuva *gpuva;
struct drm_gem_object *obj = &bo->ttm.base;
+ struct drm_gpuvm_bo *vm_bo;
int ret = 0;
dma_resv_assert_held(bo->ttm.base.resv);
@@ -465,11 +466,12 @@ static int xe_bo_trigger_rebind(struct xe_device *xe, struct xe_bo *bo,
dma_resv_iter_end(&cursor);
}
- drm_gem_for_each_gpuva(gpuva, obj) {
- struct xe_vma *vma = gpuva_to_vma(gpuva);
- struct xe_vm *vm = xe_vma_vm(vma);
+ drm_gem_for_each_gpuvm_bo(vm_bo, obj) {
+ drm_gpuvm_bo_for_each_va(gpuva, vm_bo) {
+ struct xe_vma *vma = gpuva_to_vma(gpuva);
+ struct xe_vm *vm = xe_vma_vm(vma);
- trace_xe_vma_evict(vma);
+ trace_xe_vma_evict(vma);
if (xe_vm_in_fault_mode(vm)) {
/* Wait for pending binds / unbinds. */
@@ -523,6 +525,7 @@ static int xe_bo_trigger_rebind(struct xe_device *xe, struct xe_bo *bo,
if (vm_resv_locked)
dma_resv_unlock(xe_vm_resv(vm));
}
+ }
}
return ret;
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index bb44e5ca224a..db5810f72911 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -911,12 +911,21 @@ static struct xe_vma *xe_vma_create(struct xe_vm *vm,
vma->gpuva.flags |= XE_VMA_ATOMIC_PTE_BIT;
if (bo) {
+ struct drm_gpuvm_bo *vm_bo;
+
xe_bo_assert_held(bo);
+ vm_bo = drm_gpuvm_bo_obtain(vma->gpuva.vm, &bo->ttm.base);
+ if (IS_ERR(vm_bo)) {
+ kfree(vma);
+ return ERR_CAST(vm_bo);
+ }
+
drm_gem_object_get(&bo->ttm.base);
vma->gpuva.gem.obj = &bo->ttm.base;
vma->gpuva.gem.offset = bo_offset_or_userptr;
- drm_gpuva_link(&vma->gpuva);
+ drm_gpuva_link(&vma->gpuva, vm_bo);
+ drm_gpuvm_bo_put(vm_bo);
} else /* userptr or null */ {
if (!is_null) {
u64 size = end - start + 1;
@@ -998,16 +1007,19 @@ static struct xe_vma *
bo_has_vm_references_locked(struct xe_bo *bo, struct xe_vm *vm,
struct xe_vma *ignore)
{
- struct drm_gpuva *gpuva;
+ struct drm_gpuvm_bo *vm_bo;
+ struct drm_gpuva *va;
struct drm_gem_object *obj = &bo->ttm.base;
xe_bo_assert_held(bo);
- drm_gem_for_each_gpuva(gpuva, obj) {
- struct xe_vma *vma = gpuva_to_vma(gpuva);
+ drm_gem_for_each_gpuvm_bo(vm_bo, obj) {
+ drm_gpuvm_bo_for_each_va(va, vm_bo) {
+ struct xe_vma *vma = gpuva_to_vma(va);
- if (vma != ignore && xe_vma_vm(vma) == vm)
- return vma;
+ if (vma != ignore && xe_vma_vm(vma) == vm)
+ return vma;
+ }
}
return NULL;
@@ -2169,6 +2181,7 @@ vm_bind_ioctl_ops_create(struct xe_vm *vm, struct xe_bo *bo,
struct drm_gpuva_ops *ops;
struct drm_gpuva_op *__op;
struct xe_vma_op *op;
+ struct drm_gpuvm_bo *vm_bo;
int err;
lockdep_assert_held_write(&vm->lock);
@@ -2226,7 +2239,12 @@ vm_bind_ioctl_ops_create(struct xe_vm *vm, struct xe_bo *bo,
err = xe_bo_lock(bo, true);
if (err)
return ERR_PTR(err);
- ops = drm_gpuvm_gem_unmap_ops_create(&vm->gpuvm, obj);
+
+ vm_bo = drm_gpuvm_bo_find(&vm->gpuvm, obj);
+ if (!vm_bo)
+ break;
+
+ ops = drm_gpuvm_bo_unmap_ops_create(vm_bo);
xe_bo_unlock(bo);
if (IS_ERR(ops))
return ops;
--
2.41.0
next prev parent reply other threads:[~2023-11-03 15:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 15:32 [Intel-xe] [CI v8 01/18] drm/gpuvm: convert WARN() to drm_WARN() variants Thomas Hellström
2023-11-03 15:32 ` [Intel-xe] [CI v8 02/18] drm/gpuvm: don't always WARN in drm_gpuvm_check_overflow() Thomas Hellström
2023-11-03 15:32 ` [Intel-xe] [CI v8 03/18] drm/gpuvm: export drm_gpuvm_range_valid() Thomas Hellström
2023-11-03 15:32 ` [Intel-xe] [CI v8 04/18] drm/nouveau: make use of drm_gpuvm_range_valid() Thomas Hellström
2023-11-03 15:32 ` [Intel-xe] [CI v8 05/18] drm/gpuvm: add common dma-resv per struct drm_gpuvm Thomas Hellström
2023-11-03 15:32 ` [Intel-xe] [CI v8 06/18] drm/xe: Adjust to "drm/gpuvm: add common dma-resv per struct drm_gpuvm" Thomas Hellström
2023-11-03 15:32 ` [Intel-xe] [CI v8 07/18] drm/nouveau: make use of the GPUVM's shared dma-resv Thomas Hellström
2023-11-03 15:32 ` [Intel-xe] [CI v8 08/18] drm/gpuvm: add drm_gpuvm_flags to drm_gpuvm Thomas Hellström
2023-11-03 15:32 ` [Intel-xe] [CI v8 09/18] drm/xe: Adjust to commit "drm/gpuvm: add drm_gpuvm_flags to drm_gpuvm" Thomas Hellström
2023-11-12 22:07 ` Dafna Hirschfeld
2023-11-03 15:32 ` [Intel-xe] [CI v8 10/18] drm/nouveau: separately allocate struct nouveau_uvmm Thomas Hellström
2023-11-03 15:32 ` [Intel-xe] [CI v8 11/18] drm/gpuvm: reference count drm_gpuvm structures Thomas Hellström
2023-11-03 15:32 ` [Intel-xe] [CI v8 12/18] drm/xe: Adjust to commit " Thomas Hellström
2023-11-13 6:14 ` Dafna Hirschfeld
2023-11-03 15:32 ` [Intel-xe] [CI v8 13/18] drm/gpuvm: add an abstraction for a VM / BO combination Thomas Hellström
2023-11-03 15:32 ` Thomas Hellström [this message]
2023-11-12 22:06 ` [Intel-xe] [CI v8 14/18] drm/xe: Adjust to commit "drm/gpuvm: add an abstraction for a VM/BO combination" Dafna Hirschfeld
2023-11-03 15:32 ` [Intel-xe] [CI v8 15/18] drm/gpuvm: track/lock/validate external/evicted objects Thomas Hellström
2023-11-03 15:32 ` [Intel-xe] [CI v8 16/18] drm/xe: Adapt to GPUVM tracking of external / evicted objects Thomas Hellström
2023-11-03 15:32 ` [Intel-xe] [CI v8 17/18] drm/xe: Use DRM_GPUVM_RESV_PROTECTED for gpuvm Thomas Hellström
2023-11-03 15:32 ` [Intel-xe] [CI v8 18/18] drm/nouveau: use GPUVM common infrastructure Thomas Hellström
2023-11-03 15:35 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [CI,v8,01/18] drm/gpuvm: convert WARN() to drm_WARN() variants Patchwork
2023-11-03 15:36 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-11-03 15:37 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-11-03 15:44 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-11-03 15:45 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-11-03 15:46 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-11-03 16:19 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231103153234.30407-14-thomas.hellstrom@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.