From: Jason Gunthorpe <jgg@ziepe.ca>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: zyjzyj2000@gmail.com, leon@kernel.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
rpearsonhpe@gmail.com, matsuda-daisuke@fujitsu.com,
bvanassche@acm.org, yi.zhang@redhat.com
Subject: Re: [PATCH RFC V2 4/6] RDMA/rxe: Use PAGE_SIZE and PAGE_SHIFT to extract address from page_list
Date: Fri, 3 Nov 2023 14:59:35 -0300 [thread overview]
Message-ID: <20231103175935.GC4634@ziepe.ca> (raw)
In-Reply-To: <20231103095549.490744-5-lizhijian@fujitsu.com>
On Fri, Nov 03, 2023 at 05:55:47PM +0800, Li Zhijian wrote:
> As we said in previous commit, page_list only stores PAGE_SIZE page, so
> when we extract an address from the page_list, we should use PAGE_SIZE
> and PAGE_SHIFT instead of the ibmr.page_size.
The concept was that the xarray could store anything larger than
PAGE_SIZE and the entry would point at the first struct page of the
contiguous chunk
That looks like it is right, or at least close to right, so lets try
to keep it
Jason
next prev parent reply other threads:[~2023-11-03 17:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 9:55 [PATCH RFC V2 0/6] rxe_map_mr_sg() fix cleanup and refactor Li Zhijian
2023-11-03 9:55 ` [PATCH RFC V2 1/6] RDMA/rxe: RDMA/rxe: don't allow registering !PAGE_SIZE mr Li Zhijian
2023-11-03 10:14 ` Greg Sword
2023-11-03 9:55 ` [PATCH RFC V2 2/6] RDMA/rxe: set RXE_PAGE_SIZE_CAP to PAGE_SIZE Li Zhijian
2023-11-03 9:55 ` [PATCH RFC V2 3/6] RDMA/rxe: remove unused rxe_mr.page_shift Li Zhijian
2023-11-03 9:55 ` [PATCH RFC V2 4/6] RDMA/rxe: Use PAGE_SIZE and PAGE_SHIFT to extract address from page_list Li Zhijian
2023-11-03 17:59 ` Jason Gunthorpe [this message]
2023-11-03 9:55 ` [PATCH RFC V2 5/6] RDMA/rxe: cleanup rxe_mr.{page_size,page_shift} Li Zhijian
2023-11-03 9:55 ` [PATCH RFC V2 6/6] RDMA/rxe: Support PAGE_SIZE aligned MR Li Zhijian
2023-11-03 15:04 ` Bart Van Assche
2023-11-06 3:07 ` Zhijian Li (Fujitsu)
2023-11-03 10:17 ` [PATCH RFC V2 0/6] rxe_map_mr_sg() fix cleanup and refactor Greg Sword
2023-11-06 3:46 ` Zhijian Li (Fujitsu)
2023-11-03 13:00 ` Zhu Yanjun
2023-11-06 4:07 ` Zhijian Li (Fujitsu)
2023-11-06 13:58 ` Zhu Yanjun
2023-11-09 2:24 ` Zhijian Li (Fujitsu)
2023-11-09 6:36 ` Zhu Yanjun
2023-11-09 7:16 ` Greg Sword
2023-11-09 7:26 ` Zhijian Li (Fujitsu)
2023-11-09 13:10 ` Jason Gunthorpe
2023-11-06 14:13 ` Jason Gunthorpe
2023-11-06 7:59 ` Zhijian Li (Fujitsu)
2023-11-06 9:35 ` Greg Sword
2023-11-06 9:55 ` Zhijian Li (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231103175935.GC4634@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bvanassche@acm.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=matsuda-daisuke@fujitsu.com \
--cc=rpearsonhpe@gmail.com \
--cc=yi.zhang@redhat.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.