From: kernel test robot <lkp@intel.com>
To: cros-kernel-buildreports@googlegroups.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: [android-common:android13-5.10 3314/30000] mm/swap.c:488: warning: Function parameter or member 'vma_flags' not described in '__lru_cache_add_inactive_or_unevictable'
Date: Sat, 4 Nov 2023 06:58:25 +0800 [thread overview]
Message-ID: <202311040644.8s6ACe40-lkp@intel.com> (raw)
tree: https://android.googlesource.com/kernel/common android13-5.10
head: 2fea3eca9608d8c14fb6963bfe830dfa5985d7de
commit: cbff8f39079ffd607e894aede8590d69cb6ba803 [3314/30000] FROMLIST: mm: introduce __lru_cache_add_active_or_unevictable
config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20231104/202311040644.8s6ACe40-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231104/202311040644.8s6ACe40-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311040644.8s6ACe40-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> mm/swap.c:488: warning: Function parameter or member 'vma_flags' not described in '__lru_cache_add_inactive_or_unevictable'
>> mm/swap.c:488: warning: Excess function parameter 'vma' description in '__lru_cache_add_inactive_or_unevictable'
vim +488 mm/swap.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 477
00501b531c4723 Johannes Weiner 2014-08-08 478 /**
b518154e59aab3 Joonsoo Kim 2020-08-11 479 * lru_cache_add_inactive_or_unevictable
00501b531c4723 Johannes Weiner 2014-08-08 480 * @page: the page to be added to LRU
00501b531c4723 Johannes Weiner 2014-08-08 481 * @vma: vma in which page is mapped for determining reclaimability
00501b531c4723 Johannes Weiner 2014-08-08 482 *
b518154e59aab3 Joonsoo Kim 2020-08-11 483 * Place @page on the inactive or unevictable LRU list, depending on its
12eab4289d3203 Miaohe Lin 2020-10-13 484 * evictability.
00501b531c4723 Johannes Weiner 2014-08-08 485 */
cbff8f39079ffd Laurent Dufour 2018-04-17 486 void __lru_cache_add_inactive_or_unevictable(struct page *page,
cbff8f39079ffd Laurent Dufour 2018-04-17 487 unsigned long vma_flags)
00501b531c4723 Johannes Weiner 2014-08-08 @488 {
b518154e59aab3 Joonsoo Kim 2020-08-11 489 bool unevictable;
b518154e59aab3 Joonsoo Kim 2020-08-11 490
00501b531c4723 Johannes Weiner 2014-08-08 491 VM_BUG_ON_PAGE(PageLRU(page), page);
00501b531c4723 Johannes Weiner 2014-08-08 492
cbff8f39079ffd Laurent Dufour 2018-04-17 493 unevictable = (vma_flags & (VM_LOCKED | VM_SPECIAL)) == VM_LOCKED;
b518154e59aab3 Joonsoo Kim 2020-08-11 494 if (unlikely(unevictable) && !TestSetPageMlocked(page)) {
0964730bf46b4e Hugh Dickins 2020-09-18 495 int nr_pages = thp_nr_pages(page);
00501b531c4723 Johannes Weiner 2014-08-08 496 /*
00501b531c4723 Johannes Weiner 2014-08-08 497 * We use the irq-unsafe __mod_zone_page_stat because this
00501b531c4723 Johannes Weiner 2014-08-08 498 * counter is not modified from interrupt context, and the pte
00501b531c4723 Johannes Weiner 2014-08-08 499 * lock is held(spinlock), which implies preemption disabled.
00501b531c4723 Johannes Weiner 2014-08-08 500 */
0964730bf46b4e Hugh Dickins 2020-09-18 501 __mod_zone_page_state(page_zone(page), NR_MLOCK, nr_pages);
0964730bf46b4e Hugh Dickins 2020-09-18 502 count_vm_events(UNEVICTABLE_PGMLOCKED, nr_pages);
00501b531c4723 Johannes Weiner 2014-08-08 503 }
9c4e6b1a7027f1 Shakeel Butt 2018-02-21 504 lru_cache_add(page);
00501b531c4723 Johannes Weiner 2014-08-08 505 }
00501b531c4723 Johannes Weiner 2014-08-08 506
:::::: The code at line 488 was first introduced by commit
:::::: 00501b531c4723972aa11d6d4ebcf8d6552007c8 mm: memcontrol: rewrite charge API
:::::: TO: Johannes Weiner <hannes@cmpxchg.org>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-11-03 22:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202311040644.8s6ACe40-lkp@intel.com \
--to=lkp@intel.com \
--cc=cros-kernel-buildreports@googlegroups.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.