From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0BB8C4332F for ; Sat, 4 Nov 2023 10:15:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230477AbjKDKPT (ORCPT ); Sat, 4 Nov 2023 06:15:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjKDKPS (ORCPT ); Sat, 4 Nov 2023 06:15:18 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AC0FD44; Sat, 4 Nov 2023 03:15:15 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qzDgN-0002ZA-HS; Sat, 04 Nov 2023 11:15:11 +0100 Date: Sat, 4 Nov 2023 11:15:11 +0100 From: Florian Westphal To: Randy Dunlap Cc: netdev@vger.kernel.org, Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , netfilter-devel@vger.kernel.org, coreteam@netfilter.org Subject: Re: [PATCH] netfilter: nat: add MODULE_DESCRIPTION Message-ID: <20231104101511.GC23268@breakpoint.cc> References: <20231104034017.14909-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231104034017.14909-1-rdunlap@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Randy Dunlap wrote: > Add a MODULE_DESCRIPTION() to iptable_nat.c to avoid a build warning: > > WARNING: modpost: missing MODULE_DESCRIPTION() in net/ipv4/netfilter/iptable_nat.o > > This is only exposed when using "W=n". Thanks, but I have just sent a patch to fill all of them, so I would take that one instead.