From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5527EC4332F for ; Sat, 4 Nov 2023 17:07:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232252AbjKDRHe (ORCPT ); Sat, 4 Nov 2023 13:07:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230346AbjKDRHd (ORCPT ); Sat, 4 Nov 2023 13:07:33 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00858D6 for ; Sat, 4 Nov 2023 10:07:29 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26100C433C7; Sat, 4 Nov 2023 17:07:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1699117649; bh=LJCA+OvIsfexwqTaGeqdAs8QrpD0uGcrfiZB987OFM4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Kd0A9owDY8wVZufuwy5gtqYTaM5gv7cAFOttxDjt0DEtjNERT2lrNklf2LyLuzu1F z5R7xXkvbK4a/K3bFMgpTm3HM9GtCvLBt3uyOPKeVIZYxibGQ6ktgXeb9Ck7ux+gbq mQBb4l4UYOnbjWT7pJO0QgxZC7cpscOIFfy2cnb4= Date: Sat, 4 Nov 2023 18:07:21 +0100 From: Greg Kroah-Hartman To: Willy Tarreau Cc: Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Arnd Bergmann , linux-kernel@vger.kernel.org, Zhangjin Wu , Yuan Tan Subject: Re: [PATCH RFC] misc/pvpanic: add support for normal shutdowns Message-ID: <2023110418-unreached-smith-5625@gregkh> References: <20231104-pvpanic-shutdown-v1-1-5ee7c9b3e301@weissschuh.net> <2023110407-unselect-uptight-b96d@gregkh> <365bbe1f-5ee8-40fe-bec0-53d9e7395c18@t-8ch.de> <2023110431-pacemaker-pruning-0e4c@gregkh> <59ed7f70-2953-443e-9fa5-d46c566e4a08@t-8ch.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 04, 2023 at 02:56:34PM +0100, Willy Tarreau wrote: > On Sat, Nov 04, 2023 at 02:53:37PM +0100, Thomas Weißschuh wrote: > > > > The real reason probably doesn't matter today as the header propably > > > > can't be dropped from Linux anyways for compatibility reasons. > > > > > > > > > And if they need to be here, why not use the proper BIT() macro for it? > > > > > > > > This was for uniformity with the existing code. > > > > I can send a (standalone?) patch to fix it up. > > > > > > If we keep it, sure, that would be nice. But let's try to drop it if > > > possible :) > > > > It will break the mentioned scripts/update-linux-headers.sh from qemu. > > > > > > Note: > > > > BIT() is part of include/vdso/bits.h which is not part of the > > uapi. How is it supposed to work? > > Some other uapi header also use BIT() but that seems to work by accident > > as the users have the macro defined themselves. > > Be careful here, we don't want to expose this kernel macro to userland, > it would break programs that define their own (possibly different) BIT > macro. BIT() is used in kernel headers but we should not presume that > it is available from userland. It's already there :( I thought we had a uapi-safe version somewhere, but I can't seem to find it anymore, so I don't remember what it is called. thanks, greg k-h